Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 5ef2a9bf5c
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 940b332ad0
Choose a head ref
  • 16 commits
  • 97 files changed
  • 13 contributors

Commits on Aug 18, 2023

  1. Redo ILVerfificaiton (#90418)

    * Now checks all assemblies in the output directory rather than just `test.exe`
    * Once again respects the the ability to skip verifying a single assembly via `[SkipIlVerify("foo.dll")]`
    * Now loads core libraries from the output directory (if they exist) instead of from the runtime install dir.
    * ALC logic was removed.  I do not understand what value this provided.
    * The class libraries lead to a lot of errors.  Rather than having to filter out a large number of errors, I added diff'ing.  ILVerify will check the input assembly and remove any errors that existed in the input assembly.  This makes verifying class libraries viable.  Without it, you'd have to use `[SkipIlverify]` on every core link test or filter out a lot of `VerifierError` values.
    * Moved IL verification back to `InitialChecking` where `PeVerifier` was
    * Add a test to verify that il verification is mostly working.  It doesn't give complete coverage over every behavior, but it's better than nothing.
    * `SkipPeVerify` renamed to `SkipIlVerify`
    * `SkipPeVerifyForToolchian` was removed.  There is only 1 tool now.
    * Removed `PeVerifier`.
    * Remove many [SkipIlVerify] attributes.  Diffing means they are no longer needed
    * `ValidateTypeRefsHaveValidAssemblyRefs` now runs regardless of whether or not the IL is verified.  It wasn't clear to me why this logic would only be useful when il was verified.
    * Change `UninitializedLocals` to use `ExpectIlFailure`.  This test seems to expect invalid il.  Might as well assert that rather than skip ilverify entirely.
    * Remove the logic that disables ilverify when a test uses the unsafe argument.  Diffing makes this obsolete.
    
    * IL Verification errors have been greatly improved.
    ** will now output all IL errors in the failure message rather than just the first invalid IL.
    ** Type and Method names are now displayed in the error message.  I didn't do an exhaustive implementation, SRM is so tedious to use, but it's better than not having it
    ** Tokens and Offsets are formatted nicely
    
    * Extension points opened up for Unity.
    ** We need to supply different search directories.
    ** We need to search for `.winmd` files since we support windows runtime.
    ** In general I opened some things up in case we need to call them
    mrvoorhe authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    6229f5f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9cc80c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3032f4b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b7aea6f View commit details
    Browse the repository at this point in the history
  5. [wasm] Relink for non-unicode tests should be running. (#89419)

    * Relink for non-unicode tests should be running.
    
    * Revert blocking.
    
    * Tests not failing anymore
    
    * Clean-up.
    
    * Windows has failures, block only them.
    
    * Add simple tests for relink and AOT.
    
    * Should pass on all platforms.
    
    * Typo.
    
    * AOT on Windows fails the same as relink.
    
    * Optional params do not work on TheoryData.
    
    * Revert unintentional.
    ilonatommy authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    162e601 View commit details
    Browse the repository at this point in the history
  6. [wasm] Make chrome version bumps for testing explicit, instead of aut…

    …omatic updates to latest (#90772)
    
    * [wasm] Remove automatic updates of chrome versions for testing
    
    Instead, add a `eng/testing/ChromeVersions.props` that has to be updated
    specifically to bump the chrome version used.
    
    * [wasm] Add `eng/testing/bump-chrome-version.proj`
    
    .. which can be used to update `ChromeVersions.props` to the latest
    stable version.
    
    * [wasm] Add a github action to open PRs that bump chrome versions
    
    * GetChromeVersions: Check for 75 new branch positions to find the snapshot
    
    * Update .github/workflows/bump-chrome-version.yml
    
    Co-authored-by: Ilona Tomkowicz <[email protected]>
    
    ---------
    
    Co-authored-by: Ilona Tomkowicz <[email protected]>
    radical and ilonatommy authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    e6f3f0c View commit details
    Browse the repository at this point in the history
  7. Fix SuperPMI assertion call in MethodContext::recGetHelperFtn() (#9…

    …0778)
    
    * Fix SuperPMI assertion call in `MethodContext::recGetHelperFtn()`
    
    We can't use string concatenation in an argument to the `AssertCodeMsg`
    macro, so construct the string we want to print first.
    
    * Feedback
    BruceForstall authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    028ad32 View commit details
    Browse the repository at this point in the history
  8. Implement IStatefulPinnedMarshalling test marshallers (#90685)

    * Implement test interfaces and marshallers and test them
    jtschuster authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    b7ba388 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f3fe768 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    8848123 View commit details
    Browse the repository at this point in the history
  11. Call SetupNuGetSources for installer jobs (#90756)

    Co-authored-by: Matt Mitchell <[email protected]>
    github-actions[bot] and mmitche authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5c92887 View commit details
    Browse the repository at this point in the history
  12. Improve linker performance by avoiding IndexOf (#90721)

    * Improve linker performance by avoiding IndexOf
    
    * Fix typos
    Youssef1313 authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    54fbd47 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    76d4549 View commit details
    Browse the repository at this point in the history
  14. Stop skipping tests in installer pipeline on linux_x64 (#89953)

    - Run tests in in installer pipeline on Linux_x64 even though it is cross-build. 
    - Fix uploading of binaries/symbols on failure
    elinor-fung authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    5b448cf View commit details
    Browse the repository at this point in the history
  15. Fix win-arm64 native varargs ABI (#90712)

    * Fix win-arm64 native varargs ABI
    
    SIMD vector types should be passed in integer registers.
    This might require splitting a Vector128 between x7 and stack.
    
    * Add more test cases
    
    * Update src/tests/JIT/Regression/JitBlue/Runtime_71375/Runtime_71375.cs
    
    Add additional varargs arguments after the vector
    
    Co-authored-by: Jan Kotas <[email protected]>
    
    ---------
    
    Co-authored-by: Jan Kotas <[email protected]>
    BruceForstall and jkotas authored Aug 18, 2023
    Configuration menu
    Copy the full SHA
    31234a8 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2023

  1. [mini] Fix typo in mono_decompose_vtype_opts (#90825)

    * Fix typo in mono_decompose_vtype_opts
    
    Without this, if some previous instruction already created a vreg for
    ins->dest (for example if we are doing multiple passes over the basic
    block because `restart == TRUE`) we will use an incorrect vreg when
    decomposing the current VMOVE
    
    Fixes #90800
    
    * Only emit an OP_LDTOKEN_FIELD if we loaded a field token
    
    This is used by a CreateSpan optimization that needs access to the
    MonoClassField*
    
    For other cases of a bare LDTOKEN (such as hand-written IL that calls
    LDTOKEN on a type but doesn't follow it up with a call to
    `GetTypeFromHandle` leave the opcode as a VMOVE (from the
    `EMIT_NEW_TEMPLOAD` above))
    lambdageek authored Aug 19, 2023
    Configuration menu
    Copy the full SHA
    940b332 View commit details
    Browse the repository at this point in the history
Loading