-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Comparing changes
Open a pull request
base repository: dotnet/runtime
base: 5ef2a9bf5c
head repository: dotnet/runtime
compare: 940b332ad0
- 16 commits
- 97 files changed
- 13 contributors
Commits on Aug 18, 2023
-
* Now checks all assemblies in the output directory rather than just `test.exe` * Once again respects the the ability to skip verifying a single assembly via `[SkipIlVerify("foo.dll")]` * Now loads core libraries from the output directory (if they exist) instead of from the runtime install dir. * ALC logic was removed. I do not understand what value this provided. * The class libraries lead to a lot of errors. Rather than having to filter out a large number of errors, I added diff'ing. ILVerify will check the input assembly and remove any errors that existed in the input assembly. This makes verifying class libraries viable. Without it, you'd have to use `[SkipIlverify]` on every core link test or filter out a lot of `VerifierError` values. * Moved IL verification back to `InitialChecking` where `PeVerifier` was * Add a test to verify that il verification is mostly working. It doesn't give complete coverage over every behavior, but it's better than nothing. * `SkipPeVerify` renamed to `SkipIlVerify` * `SkipPeVerifyForToolchian` was removed. There is only 1 tool now. * Removed `PeVerifier`. * Remove many [SkipIlVerify] attributes. Diffing means they are no longer needed * `ValidateTypeRefsHaveValidAssemblyRefs` now runs regardless of whether or not the IL is verified. It wasn't clear to me why this logic would only be useful when il was verified. * Change `UninitializedLocals` to use `ExpectIlFailure`. This test seems to expect invalid il. Might as well assert that rather than skip ilverify entirely. * Remove the logic that disables ilverify when a test uses the unsafe argument. Diffing makes this obsolete. * IL Verification errors have been greatly improved. ** will now output all IL errors in the failure message rather than just the first invalid IL. ** Type and Method names are now displayed in the error message. I didn't do an exhaustive implementation, SRM is so tedious to use, but it's better than not having it ** Tokens and Offsets are formatted nicely * Extension points opened up for Unity. ** We need to supply different search directories. ** We need to search for `.winmd` files since we support windows runtime. ** In general I opened some things up in case we need to call them
Configuration menu - View commit details
-
Copy full SHA for 6229f5f - Browse repository at this point
Copy the full SHA 6229f5fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cc80c3 - Browse repository at this point
Copy the full SHA 9cc80c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3032f4b - Browse repository at this point
Copy the full SHA 3032f4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7aea6f - Browse repository at this point
Copy the full SHA b7aea6fView commit details -
[wasm] Relink for non-unicode tests should be running. (#89419)
* Relink for non-unicode tests should be running. * Revert blocking. * Tests not failing anymore * Clean-up. * Windows has failures, block only them. * Add simple tests for relink and AOT. * Should pass on all platforms. * Typo. * AOT on Windows fails the same as relink. * Optional params do not work on TheoryData. * Revert unintentional.
Configuration menu - View commit details
-
Copy full SHA for 162e601 - Browse repository at this point
Copy the full SHA 162e601View commit details -
[wasm] Make chrome version bumps for testing explicit, instead of aut…
…omatic updates to latest (#90772) * [wasm] Remove automatic updates of chrome versions for testing Instead, add a `eng/testing/ChromeVersions.props` that has to be updated specifically to bump the chrome version used. * [wasm] Add `eng/testing/bump-chrome-version.proj` .. which can be used to update `ChromeVersions.props` to the latest stable version. * [wasm] Add a github action to open PRs that bump chrome versions * GetChromeVersions: Check for 75 new branch positions to find the snapshot * Update .github/workflows/bump-chrome-version.yml Co-authored-by: Ilona Tomkowicz <[email protected]> --------- Co-authored-by: Ilona Tomkowicz <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e6f3f0c - Browse repository at this point
Copy the full SHA e6f3f0cView commit details -
Fix SuperPMI assertion call in
MethodContext::recGetHelperFtn()
(#9……0778) * Fix SuperPMI assertion call in `MethodContext::recGetHelperFtn()` We can't use string concatenation in an argument to the `AssertCodeMsg` macro, so construct the string we want to print first. * Feedback
Configuration menu - View commit details
-
Copy full SHA for 028ad32 - Browse repository at this point
Copy the full SHA 028ad32View commit details -
Implement IStatefulPinnedMarshalling test marshallers (#90685)
* Implement test interfaces and marshallers and test them
Configuration menu - View commit details
-
Copy full SHA for b7ba388 - Browse repository at this point
Copy the full SHA b7ba388View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3fe768 - Browse repository at this point
Copy the full SHA f3fe768View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8848123 - Browse repository at this point
Copy the full SHA 8848123View commit details -
Call SetupNuGetSources for installer jobs (#90756)
Co-authored-by: Matt Mitchell <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 5c92887 - Browse repository at this point
Copy the full SHA 5c92887View commit details -
Improve linker performance by avoiding IndexOf (#90721)
* Improve linker performance by avoiding IndexOf * Fix typos
Configuration menu - View commit details
-
Copy full SHA for 54fbd47 - Browse repository at this point
Copy the full SHA 54fbd47View commit details -
Configuration menu - View commit details
-
Copy full SHA for 76d4549 - Browse repository at this point
Copy the full SHA 76d4549View commit details -
Stop skipping tests in installer pipeline on linux_x64 (#89953)
- Run tests in in installer pipeline on Linux_x64 even though it is cross-build. - Fix uploading of binaries/symbols on failure
Configuration menu - View commit details
-
Copy full SHA for 5b448cf - Browse repository at this point
Copy the full SHA 5b448cfView commit details -
Fix win-arm64 native varargs ABI (#90712)
* Fix win-arm64 native varargs ABI SIMD vector types should be passed in integer registers. This might require splitting a Vector128 between x7 and stack. * Add more test cases * Update src/tests/JIT/Regression/JitBlue/Runtime_71375/Runtime_71375.cs Add additional varargs arguments after the vector Co-authored-by: Jan Kotas <[email protected]> --------- Co-authored-by: Jan Kotas <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 31234a8 - Browse repository at this point
Copy the full SHA 31234a8View commit details
Commits on Aug 19, 2023
-
[mini] Fix typo in mono_decompose_vtype_opts (#90825)
* Fix typo in mono_decompose_vtype_opts Without this, if some previous instruction already created a vreg for ins->dest (for example if we are doing multiple passes over the basic block because `restart == TRUE`) we will use an incorrect vreg when decomposing the current VMOVE Fixes #90800 * Only emit an OP_LDTOKEN_FIELD if we loaded a field token This is used by a CreateSpan optimization that needs access to the MonoClassField* For other cases of a bare LDTOKEN (such as hand-written IL that calls LDTOKEN on a type but doesn't follow it up with a call to `GetTypeFromHandle` leave the opcode as a VMOVE (from the `EMIT_NEW_TEMPLOAD` above))
Configuration menu - View commit details
-
Copy full SHA for 940b332 - Browse repository at this point
Copy the full SHA 940b332View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 5ef2a9bf5c...940b332ad0