Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Performance regressions in writing Tar files #115155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
performanceautofiler bot opened this issue Apr 29, 2025 · 4 comments
Open

Performance regressions in writing Tar files #115155

performanceautofiler bot opened this issue Apr 29, 2025 · 4 comments
Assignees
@carlossanlop
Labels
arch-x64 area-System.Formats.Tar os-windows runtime-coreclr specific to the CoreCLR runtime
Milestone
10.0.0

Comments

@performanceautofiler
Copy link

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline 199ae8820492f05169529da1f262e9736007448a
Compare 5314b8c0722096ddac5840efc46451850820c134
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Formats.Tar.Tests.Perf_TarWriter

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
228.17 ns 268.15 ns 1.18 0.04 False
338.05 ns 370.10 ns 1.09 0.03 False
208.48 ns 255.50 ns 1.23 0.04 False
287.11 ns 317.36 ns 1.11 0.04 False
364.18 ns 387.46 ns 1.06 0.01 False
437.29 ns 462.34 ns 1.06 0.02 False

graph
graph
graph
graph
graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Formats.Tar.Tests.Perf_TarWriter*'

System.Formats.Tar.Tests.Perf_TarWriter.UstarTarEntry_WriteEntry

ETL Files

Histogram

JIT Disasms

System.Formats.Tar.Tests.Perf_TarWriter.V7TarEntry_WriteEntry_Async

ETL Files

Histogram

JIT Disasms

System.Formats.Tar.Tests.Perf_TarWriter.V7TarEntry_WriteEntry

ETL Files

Histogram

JIT Disasms

System.Formats.Tar.Tests.Perf_TarWriter.GnuTarEntry_WriteEntry

ETL Files

Histogram

JIT Disasms

System.Formats.Tar.Tests.Perf_TarWriter.UstarTarEntry_WriteEntry_Async

ETL Files

Histogram

JIT Disasms

System.Formats.Tar.Tests.Perf_TarWriter.GnuTarEntry_WriteEntry_Async

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Run Information

Name Value
Architecture x64
OS Windows 10.0.22621
Queue TigerWindows
Baseline 199ae8820492f05169529da1f262e9736007448a
Compare 5314b8c0722096ddac5840efc46451850820c134
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in System.Collections.Tests.Add_Remove_SteadyState<Int32>

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
6.92 ns 10.09 ns 1.46 0.24 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Collections.Tests.Add_Remove_SteadyState&lt;Int32&gt;*'

System.Collections.Tests.Add_Remove_SteadyState<Int32>.Queue(Count: 512)

ETL Files

Histogram

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arch-x64 os-windows runtime-coreclr specific to the CoreCLR runtime untriaged New issue has not been triaged by the area owner labels Apr 29, 2025
@performanceautofiler performanceautofiler bot mentioned this issue Apr 29, 2025
Closed
@AndyAyersMS
Copy link
Member

AndyAyersMS commented Apr 29, 2025 •
edited by EgorBo
Loading

#114940

Related:

Could be these are expected, but I didn't see any mention of this in the PR.

@AndyAyersMS AndyAyersMS transferred this issue from dotnet/perf-autofiling-issues Apr 29, 2025
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 29, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-formats-tar
See info in area-owners.md if you want to be subscribed.

@AndyAyersMS AndyAyersMS changed the title [Perf] Windows/x64: 7 Regressions on 4/24/2025 6:44:30 PM +00:00 Performance regressions in writing Tar files May 1, 2025
@teo-tsirpanis teo-tsirpanis removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label May 2, 2025
@ViktorHofer
Copy link
Member

ViktorHofer commented May 4, 2025 •
edited
Loading

@carlossanlop possibly related to the recent Tar changes?

@ericstj ericstj removed the untriaged New issue has not been triaged by the area owner label May 5, 2025
@ericstj ericstj added this to the 10.0.0 milestone May 5, 2025
@carlossanlop
Copy link
Member

Yes, it looks like it.

Since I have another PR open to fix more things, I will try to address this regression if it still makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlossanlop carlossanlop

Labels
arch-x64 area-System.Formats.Tar os-windows runtime-coreclr specific to the CoreCLR runtime
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
6 participants
@carlossanlop @ViktorHofer @ericstj @jeffschwMSFT @AndyAyersMS @teo-tsirpanis