Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Consider running System.Security.Cryptography tests on Windows 10 Threshold #115162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
vcsjones opened this issue Apr 29, 2025 · 4 comments
Open

Consider running System.Security.Cryptography tests on Windows 10 Threshold #115162

vcsjones opened this issue Apr 29, 2025 · 4 comments
Labels
area-Infrastructure-libraries needs-author-action An issue or pull request that requires more info or actions from the author. question Answer questions and provide assistance, not an issue with source code or documentation.
Milestone
10.0.0

Comments

@vcsjones
Copy link
Member

vcsjones commented Apr 29, 2025 •
edited
Loading

It appears that the JIT will run some of its tests in a pipeline with Windows 10 / Windows Server 2016 SP0 (Threshold). However, this pipeline will not be triggered for Libraries-only changes.

System.Security.Cryptography is a little sensitive to OS versions, particularly around PKCS12/PFX. There are known differences between Windows 8, Threshold, and Redstone 2+. This has led to a few cases where a test was green and merged because it ran on "new" Windows, only to later find out that the test fails on Windows 10 Threshold when a JIT pipeline runs.

Examples:

Ideally, Windows 10 SP0 / Threshold would be used for library runs that touch cryptography, or a reasonable as possible. A set of path filters might look like

- src/libraries/System.Security.Cryptography*/
- src/libraries/Common/src/System/Security/Cryptography/
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 29, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@vcsjones
Copy link
Member Author

/cc @dotnet/area-system-security

@vcsjones vcsjones mentioned this issue May 3, 2025
Merged
@ericstj
Copy link
Member

ericstj commented May 5, 2025

Here are the set of different libraries test runs for windows -

runtime/eng/pipelines/libraries/helix-queues-setup.yml

Lines 103 to 125 in 43955cb

# windows x64
- ${{ if eq(parameters.platform, 'windows_x64') }}:
# netcoreapp
- ${{ if notIn(parameters.jobParameters.framework, 'net481') }}:
# libraries on mono outerloop
- ${{ if and(eq(parameters.jobParameters.testScope, 'outerloop'), eq(parameters.jobParameters.runtimeFlavor, 'mono')) }}:
- Windows.Amd64.Server2022.Open
- Windows.Server2025.Amd64.Open
# libraries on coreclr (outerloop and innerloop), or libraries on mono innerloop
- ${{ if or(ne(parameters.jobParameters.testScope, 'outerloop'), ne(parameters.jobParameters.runtimeFlavor, 'mono')) }}:
- ${{ if or(eq(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.Amd64.Server2022.Open
- Windows.Server2025.Amd64.Open
- ${{ if ne(parameters.jobParameters.testScope, 'outerloop') }}:
- (Windows.10.Amd64.ServerRS5.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2019-helix-amd64
- ${{ if or(ne(parameters.jobParameters.isExtraPlatformsBuild, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.Amd64.Server2022.Open
- Windows.Server2025.Amd64.Open
- Windows.11.Amd64.Client.Open
- ${{ if eq(parameters.jobParameters.testScope, 'outerloop') }}:
- (Windows.10.Amd64.ServerRS5.Open)[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2019-helix-amd64
- ${{ if ne(parameters.jobParameters.runtimeFlavor, 'mono') }}:
- (Windows.Nano.1809.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64

Do you see something here that would cover this? Maybe outerloop or extra-platforms?

@ericstj ericstj added question Answer questions and provide assistance, not an issue with source code or documentation. needs-author-action An issue or pull request that requires more info or actions from the author. and removed untriaged New issue has not been triaged by the area owner labels May 5, 2025
@ericstj ericstj added this to the 10.0.0 milestone May 5, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

This issue has been marked needs-author-action and may be missing some important information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-Infrastructure-libraries needs-author-action An issue or pull request that requires more info or actions from the author. question Answer questions and provide assistance, not an issue with source code or documentation.
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
2 participants
@vcsjones @ericstj