-
Notifications
You must be signed in to change notification settings - Fork 5k
Fix managed implementation of HttpListener to match Windows implementation #20997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@hughbe any progress on this one? |
Yup I've submitted a bunch of PRs. This is a bit of an umbrella issue unfortunately - the more tests I add the more differences I find - so not sure how well it fits into milestones etc. |
Got it. |
I've gone through HttpListenerRequestStream, HttpListenerResponseStream, HttpListenerRequest and HttpListener. |
Sounds great, thanks! |
@hughbe What other issues is this one tracking? |
The main remaining issue this tracks are (assuming dotnet/corefx#19138 and dotnet/corefx#19219 are merged):
|
This is almost certainly too much work for before ZBB |
Networking has already exception from ZBB. |
@Priya91 ping? |
@karelz Looking at the tests, will update when I have more info. I would prioritize the issues with different platform behaviors, that is cases where exceptions are not thrown/thrown. |
I don't think we need the umbrela issue anymore, let's consider it addressed. |
@karelz, there are 14 tests disabled against this issue, and PR dotnet/corefx#19880 disables another 36 tests against it. |
Ooops, thanks for catching that. I have moved the issue to Future. I assume we already made our peace with the disabled tests, right? |
I wouldn't assume that. Most of these differences we're only just learning about as @hughbe writes the tests we never had before. To quote you from 5 days ago: |
Are you saying we didn't have time to look at the failures yet? That would be concerning ... |
They're marked against this issue, and you assigned this issue to hughbe. He's writing a ton of good tests and finding issues. To my knowledge no one has further investigated those issues, but you would know better than I. |
I think I mixed it up with "we need tests" - @Priya91 can you please review the test failures and help prioritize them? |
@karelz @stephentoub I've requested @hughbe to try to file separate issues for distinct known compat bugs, so that it's easier to surmarize what the issue is instead of reading the whole umbrella issue thread to figure out how much work is left. As to prioritizing the test failures, I'm not sure how to do that, all of them are differences in behavior between windows and unix, we need to fix all at equal priority for 2.0, since HttpListener was added for 2.0. |
Closing this issue as I've separated all the issues out into their own tests in dotnet/corefx#19880 |
In dotnet/corefx#17999 some tests are disabled on Unix due to different implementations of HttpListener. Most of these are argument validation, and can easily be corrected. Some may need further investigation and may be by-design due to inherent platform differences.
I'm grabbing this one, once dotnet/corefx#17999 is merged
The text was updated successfully, but these errors were encountered: