Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix managed implementation of HttpListener to match Windows implementation #20997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hughbe opened this issue Apr 9, 2017 · 20 comments
Closed
Assignees
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue enhancement Product code improvement that does NOT require public API changes/additions os-linux Linux OS (any supported distro) os-mac-os-x macOS aka OSX
Milestone

Comments

@hughbe
Copy link
Contributor

hughbe commented Apr 9, 2017

In dotnet/corefx#17999 some tests are disabled on Unix due to different implementations of HttpListener. Most of these are argument validation, and can easily be corrected. Some may need further investigation and may be by-design due to inherent platform differences.

I'm grabbing this one, once dotnet/corefx#17999 is merged

@karelz
Copy link
Member

karelz commented Apr 27, 2017

@hughbe any progress on this one?

@hughbe
Copy link
Contributor Author

hughbe commented Apr 28, 2017

Yup I've submitted a bunch of PRs. This is a bit of an umbrella issue unfortunately - the more tests I add the more differences I find - so not sure how well it fits into milestones etc.

@karelz
Copy link
Member

karelz commented Apr 28, 2017

Got it.
When do you expect to reach the point of "good enough" coverage? Do you have rough estimation?

@hughbe
Copy link
Contributor Author

hughbe commented Apr 28, 2017

I've gone through HttpListenerRequestStream, HttpListenerResponseStream, HttpListenerRequest and HttpListener.
I'm probably going to limit myself to HttpListenerResponse and authentication to conclude.
Maybe a good idea for me would be to close this issue once all the active issues are fixed - I dislike umbrella issues as much as anyone

@karelz
Copy link
Member

karelz commented Apr 28, 2017

Sounds great, thanks!

@Priya91
Copy link
Contributor

Priya91 commented May 9, 2017

@hughbe What other issues is this one tracking?

@hughbe
Copy link
Contributor Author

hughbe commented May 10, 2017

The main remaining issue this tracks are (assuming dotnet/corefx#19138 and dotnet/corefx#19219 are merged):

@hughbe
Copy link
Contributor Author

hughbe commented May 10, 2017

This is almost certainly too much work for before ZBB

@karelz
Copy link
Member

karelz commented May 10, 2017

Networking has already exception from ZBB.
@Priya91 can you please help prioritize the failures above? Which are likely impactful enough for us to take them?

@karelz
Copy link
Member

karelz commented May 11, 2017

@Priya91 ping?

@Priya91
Copy link
Contributor

Priya91 commented May 12, 2017

@karelz Looking at the tests, will update when I have more info. I would prioritize the issues with different platform behaviors, that is cases where exceptions are not thrown/thrown.

@karelz
Copy link
Member

karelz commented May 18, 2017

I don't think we need the umbrela issue anymore, let's consider it addressed.

@karelz karelz closed this as completed May 18, 2017
@stephentoub
Copy link
Member

@karelz, there are 14 tests disabled against this issue, and PR dotnet/corefx#19880 disables another 36 tests against it.

@stephentoub stephentoub reopened this May 18, 2017
@karelz
Copy link
Member

karelz commented May 18, 2017

Ooops, thanks for catching that. I have moved the issue to Future. I assume we already made our peace with the disabled tests, right?
Or is there any 2.0 work left here?

@stephentoub
Copy link
Member

I assume we already made our peace with the disabled tests, right?

I wouldn't assume that. Most of these differences we're only just learning about as @hughbe writes the tests we never had before. To quote you from 5 days ago:
https://github.com/dotnet/corefx/issues/19744#issuecomment-301279350

@karelz
Copy link
Member

karelz commented May 18, 2017

Are you saying we didn't have time to look at the failures yet? That would be concerning ...

@stephentoub
Copy link
Member

They're marked against this issue, and you assigned this issue to hughbe. He's writing a ton of good tests and finding issues. To my knowledge no one has further investigated those issues, but you would know better than I.

@karelz
Copy link
Member

karelz commented May 18, 2017

I think I mixed it up with "we need tests" - @Priya91 can you please review the test failures and help prioritize them?
We need to identify those that are must-have for 2.0.

@Priya91
Copy link
Contributor

Priya91 commented May 18, 2017

@karelz @stephentoub I've requested @hughbe to try to file separate issues for distinct known compat bugs, so that it's easier to surmarize what the issue is instead of reading the whole umbrella issue thread to figure out how much work is left. As to prioritizing the test failures, I'm not sure how to do that, all of them are differences in behavior between windows and unix, we need to fix all at equal priority for 2.0, since HttpListener was added for 2.0.

@hughbe
Copy link
Contributor Author

hughbe commented May 19, 2017

Closing this issue as I've separated all the issues out into their own tests in dotnet/corefx#19880
I'd like to grab some of the low hanging fruit this weekend, especially around HttpListenerResponse

@hughbe hughbe closed this as completed May 19, 2017
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.0.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Http disabled-test The test is disabled in source code against the issue enhancement Product code improvement that does NOT require public API changes/additions os-linux Linux OS (any supported distro) os-mac-os-x macOS aka OSX
Projects
None yet
Development

No branches or pull requests

5 participants