-
Notifications
You must be signed in to change notification settings - Fork 5k
WSL and WSL2 test runs #42011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Tagging subscribers to this area: @ViktorHofer |
there can be also WSL-specific performance issues, e.g. #24839 |
It would be nice to matrix it into the rolling runs somehow. What distro would be most interesting? I assume we need both WSL1 and WSL2 represented? @jaredpar owns this matrix. |
I wouldn't invest in WSL1. There are multiple test failures with it, because of the kernel not being complete. |
I wonder whether we would be confident enough to drop tests on distro X (presumably in docker) in favor of X in WSL2. |
AFAIK WSL2 remains to be a development only environment. I think we should always prefer execution environments over development only environments in our testing. Just my 5c. |
To be a useful development environment the tests need to reliably pass. |
this is true, but there are some tools like PowerShell Core that need to work properly in this environment ;)
I agree. This is why we should most probably add new CI leg(s) rather that change the existing ones |
You could start with Ubuntu LTS 18/20. |
This is WSL1 specific. Do we know if such issues can happen on WSL2 only? Wondering if we need the extra coverage if WSL2 behaves exactly the same as Debian/RedHat/CentOS/etc. |
I think about all related to Console. |
Another recent example of a WSL specific performance (concurrency related) issue that suggests test runs are needed: #42994 |
@dje-dev performance runs are tracked by issues in dotnet/performance. In that specific case, @adamsitnik it seems that we do have a test that sets/gets a thread static, but that scenario didn't not pop out for you in the WSL2 data submissions you analyzed (eg from me) right? |
it did not, most probably because there was no regression compared to 3.1 (5.0 was as slow as 3.1) I could install Ubuntu 18.04 WSL2 on my dual boot PC and compare bare-metal Ubuntu vs WSL2 Ubuntu using the same hardware. My only concern is how actionable would be such an analysis. So far we were trying to avoid WSL2-specific implementations on our side. I could identify WSL2 perf issues and report them as WSL2 product issues. @danmosemsft would that be useful? |
oh! of course.
Without more customer reports, I don't think that's necessary.. Also it's not clear what priority we collectively have for fixing such things. |
Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process. This process is part of our issue cleanup automation. |
This issue will now be closed since it had been marked |
#40727 has shown that it's possible to have WSL-specific bugs and that they are important to our customers and us
We have provided a fix (#40851) but it would be great if we could prevent similar issues to reoccur in the future.
@danmosemsft are there any plans to add WSL test runs to our CI?
The text was updated successfully, but these errors were encountered: