Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WSL and WSL2 test runs #42011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamsitnik opened this issue Sep 9, 2020 · 17 comments
Closed

WSL and WSL2 test runs #42011

adamsitnik opened this issue Sep 9, 2020 · 17 comments
Labels
area-Infrastructure backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity os-windows-wsl WSL (Windows Subsystem for Linux) OS - Linux binaries running on Windows

Comments

@adamsitnik
Copy link
Member

#40727 has shown that it's possible to have WSL-specific bugs and that they are important to our customers and us

We have provided a fix (#40851) but it would be great if we could prevent similar issues to reoccur in the future.

@danmosemsft are there any plans to add WSL test runs to our CI?

@adamsitnik adamsitnik added os-windows-wsl WSL (Windows Subsystem for Linux) OS - Linux binaries running on Windows area-Infrastructure labels Sep 9, 2020
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Sep 9, 2020
@ghost
Copy link

ghost commented Sep 9, 2020

Tagging subscribers to this area: @ViktorHofer
See info in area-owners.md if you want to be subscribed.

@EgorBo
Copy link
Member

EgorBo commented Sep 9, 2020

there can be also WSL-specific performance issues, e.g. #24839

@danmoseley
Copy link
Member

It would be nice to matrix it into the rolling runs somehow. What distro would be most interesting? I assume we need both WSL1 and WSL2 represented?

@jaredpar owns this matrix.

@ViktorHofer
Copy link
Member

I wouldn't invest in WSL1. There are multiple test failures with it, because of the kernel not being complete.

@danmoseley
Copy link
Member

I wonder whether we would be confident enough to drop tests on distro X (presumably in docker) in favor of X in WSL2.

@ViktorHofer
Copy link
Member

AFAIK WSL2 remains to be a development only environment. I think we should always prefer execution environments over development only environments in our testing. Just my 5c.

@danmoseley
Copy link
Member

To be a useful development environment the tests need to reliably pass.

@adamsitnik
Copy link
Member Author

WSL2 remains to be a development only environment

this is true, but there are some tools like PowerShell Core that need to work properly in this environment ;)

I think we should always prefer execution environments over development only environments in our testing.

I agree. This is why we should most probably add new CI leg(s) rather that change the existing ones

@Anipik Anipik removed the untriaged New issue has not been triaged by the area owner label Sep 11, 2020
@Anipik Anipik added this to the 6.0.0 milestone Sep 11, 2020
@iSazonov
Copy link
Contributor

What distro would be most interesting?

You could start with Ubuntu LTS 18/20.

@ViktorHofer
Copy link
Member

there can be also WSL-specific performance issues, e.g. #24839

This is WSL1 specific. Do we know if such issues can happen on WSL2 only? Wondering if we need the extra coverage if WSL2 behaves exactly the same as Debian/RedHat/CentOS/etc.

@ViktorHofer ViktorHofer modified the milestones: 6.0.0, Future Sep 26, 2020
@iSazonov
Copy link
Contributor

Do we know if such issues can happen on WSL2 only?

I think about all related to Console.

@dje-dev
Copy link

dje-dev commented Oct 16, 2020

Another recent example of a WSL specific performance (concurrency related) issue that suggests test runs are needed: #42994

@danmoseley
Copy link
Member

@dje-dev performance runs are tracked by issues in dotnet/performance. In that specific case, @adamsitnik it seems that we do have a test that sets/gets a thread static, but that scenario didn't not pop out for you in the WSL2 data submissions you analyzed (eg from me) right?

@adamsitnik
Copy link
Member Author

but that scenario didn't not pop out for you in the WSL2 data submissions you analyzed (eg from me) right

it did not, most probably because there was no regression compared to 3.1 (5.0 was as slow as 3.1)

I could install Ubuntu 18.04 WSL2 on my dual boot PC and compare bare-metal Ubuntu vs WSL2 Ubuntu using the same hardware. My only concern is how actionable would be such an analysis. So far we were trying to avoid WSL2-specific implementations on our side. I could identify WSL2 perf issues and report them as WSL2 product issues.

@danmosemsft would that be useful?

@danmoseley
Copy link
Member

did not, most probably because there was no regression compared to 3.1 (5.0 was as slow as 3.1)

oh! of course.

I could install Ubuntu 18.04 WSL2 on my dual boot PC and compare bare-metal Ubuntu vs WSL2 Ubuntu

Without more customer reports, I don't think that's necessary.. Also it's not clear what priority we collectively have for fixing such things.

Copy link
Contributor

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

@dotnet-policy-service dotnet-policy-service bot added backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity labels Apr 20, 2025
Copy link
Contributor

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.

@dotnet-policy-service dotnet-policy-service bot removed this from the Future milestone May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Infrastructure backlog-cleanup-candidate An inactive issue that has been marked for automated closure. no-recent-activity os-windows-wsl WSL (Windows Subsystem for Linux) OS - Linux binaries running on Windows
Projects
Status: Done
Development

No branches or pull requests

8 participants