@RussKeldorph this is Windows only right? Since there are no warnings on Unix - I have taken care of them a long time ago. Few of them had to be disabled (like comparing "this" to NULL at some places), but whatever was feasible was fixed and the warnings are treated as errors.

@janvorli It's everywhere. If warnings are already errors on Unix, great! One less thing to fix. :)

@RussKeldorph I guess I got confused - I have thought you meant native code build, but I think you must have meant managed build, since I don't get any warnings from Windows native code build either.
And in fact, from building mscorlib / System.Private.Corelib.dll, I am not getting any warnings either (except of two nuget warnings).
So is it just the tests?

@janvorli I acknowledge my description implies that there are warnings outside the test build on Windows, but I only intended to make a statement about the scope of the impact (all of coreclr on any platform), and not about the scope of work required to get there. I didn't verify where particular warnings originate prior to creating the issue. It comes as a pleasant surprise that some or all warnings are already disallowed in some contexts. I merely proposed to expand those contexts with when addressing this issue, by whatever means are required.

I thought tests had to be built on Windows, meaning Linux build doesn't build test

@wtgodbe are you planning to do this for 2.0?

@danmosemsft yes, this is one of the first bugs I'll work on post-4/21

Need to revisit this once we get the Unix test build sorted.

@jkoritzinsky @trylek do you know if this issue is still valid?

Yes this is still valid. We still issue a few warnings on Win x86 so we don’t have warn-as-error turned on.

Due to lack of recent activity, this issue has been marked as a candidate for backlog cleanup. It will be closed if no further activity occurs within 14 more days. Any new comment (by anyone, not necessarily the author) will undo this process.

This process is part of our issue cleanup automation.

This issue will now be closed since it had been marked no-recent-activity but received no further activity in the past 14 days. It is still possible to reopen or comment on the issue, but please note that the issue will be locked if it remains inactive for another 30 days.