-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Closed
Description
In #76642 , we added checks to exclude Arm related projects based on TargetArchitecture
.
<_IncludeArm64HWIntrinsicTests>false</_IncludeArm64HWIntrinsicTests> | |
<_IncludeArm64HWIntrinsicTests Condition="'$(CLRTestPriorityToBuild)' >= '1' OR '$(TargetArchitecture)' == 'arm64'">true</_IncludeArm64HWIntrinsicTests> |
However, when we build test managed components for AnyOS, we end up passing archType=x64
which translates to /p:TargetArchitecture=x64
:
- script: $(Build.SourcesDirectory)/src/tests/build$(scriptExt) $(logRootNameArg)Managed allTargets skipnative skipgeneratelayout skiptestwrappers $(buildConfig) $(archType) $(runtimeFlavorArgs) $(crossArg) $(priorityArg) $(testTreeFilterArg) ci /p:TargetOS=AnyOS |
This can be seen from the logs of coreclr Common Pri0 Test Build AnyOS AnyCPU checked
job:
2023-03-24T16:47:53.7325522Z /__w/1/s/src/tests/build.sh -log:Managed allTargets skipnative skipgeneratelayout skiptestwrappers checked x64 ci /p:TargetOS=AnyOS
2023-03-24T16:47:53.7326524Z ========================== Starting Command Output ===========================
2023-03-24T16:47:53.7345342Z [command]/usr/bin/bash --noprofile --norc /__w/_temp/249d4290-e028-48ef-84f2-448c189a994c.sh
2023-03-24T16:47:53.7629393Z __DistroRid: linux-x64
2023-03-24T16:47:53.7657493Z Building Tests...
2023-03-24T16:47:53.7686206Z __TargetOS: linux
2023-03-24T16:47:53.7686828Z __TargetArch: x64
2023-03-24T16:47:53.7687367Z __BuildType: Checked
2023-03-24T16:47:53.7688000Z __TestIntermediatesDir: /__w/1/s/artifacts/tests/coreclr/obj/linux.x64.Checked
2023-03-24T16:47:53.7688926Z __NativeTestIntermediatesDir: /__w/1/s/artifacts/tests/coreclr/obj/linux.x64.Checked/Native
2023-03-24T16:47:53.7689874Z __ManagedTestIntermediatesDir: /__w/1/s/artifacts/tests/coreclr/obj/linux.x64.Checked/Managed
2023-03-24T16:47:53.7690720Z Creating TestBinDir: /__w/1/s/artifacts/tests/coreclr/linux.x64.Checked
2023-03-24T16:47:53.7696258Z Creating LogsDir: /__w/1/s/artifacts/log
As a result, we do not include Arm
test cases in CI run. I downloaded the HardwareIntrinsics_ro.dll
and checked using ILSpy and I don't see AdvSimd.dll
project being referenced.