From 3e10b832a3396361bccd8ea386e09f45b98b3a3e Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Wed, 17 Jan 2024 10:10:21 +0000 Subject: [PATCH 01/28] Update dependencies from https://github.com/dotnet/arcade build 20240116.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24066.3 --- eng/Version.Details.xml | 80 +++++++++---------- eng/Versions.props | 32 ++++---- eng/common/build.cmd | 3 + eng/common/build.ps1 | 3 + eng/common/build.sh | 8 ++ eng/common/cross/build-rootfs.sh | 6 +- eng/common/cross/riscv64/sources.list.sid | 2 +- eng/common/helixpublish.proj | 1 + eng/common/internal/Directory.Build.props | 2 + eng/common/internal/Tools.csproj | 2 + eng/common/sdl/trim-assets-version.ps1 | 2 +- eng/common/templates/job/job.yml | 2 +- .../templates/job/publish-build-assets.yml | 6 +- .../templates/job/source-index-stage1.yml | 10 +-- .../templates/post-build/common-variables.yml | 2 +- .../templates/post-build/post-build.yml | 4 +- eng/common/templates/steps/publish-logs.yml | 2 +- eng/common/templates/steps/source-build.yml | 4 +- eng/common/tools.ps1 | 40 ++++++---- eng/common/tools.sh | 13 +-- global.json | 6 +- 21 files changed, 127 insertions(+), 103 deletions(-) create mode 100644 eng/common/build.cmd diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 4773294f452def..bc49fad10b0907 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -111,82 +111,82 @@ - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 https://github.com/dotnet/runtime-assets @@ -333,9 +333,9 @@ https://github.com/dotnet/xharness a855ee8bf3e90a5baef9de25ccff5be597390087 - + https://github.com/dotnet/arcade - 3faeb9817f465151aa4bbcdb315f0a6170206760 + d5ee27a55ec6383c29790f3ec666e7c87f7da022 https://dev.azure.com/dnceng/internal/_git/dotnet-optimization diff --git a/eng/Versions.props b/eng/Versions.props index 05b80956836830..d20542e85c8b6b 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -82,22 +82,22 @@ 9.0.100-alpha.1.23551.3 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 2.5.3-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 - 9.0.0-beta.23607.2 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 2.6.6-beta.24066.3 + 9.0.0-beta.24066.3 + 2.6.6-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 + 9.0.0-beta.24066.3 6.0.0-preview.1.102 diff --git a/eng/common/build.cmd b/eng/common/build.cmd new file mode 100644 index 00000000000000..99daf368abae74 --- /dev/null +++ b/eng/common/build.cmd @@ -0,0 +1,3 @@ +@echo off +powershell -ExecutionPolicy ByPass -NoProfile -command "& """%~dp0build.ps1""" %*" +exit /b %ErrorLevel% diff --git a/eng/common/build.ps1 b/eng/common/build.ps1 index 33a6f2d0e24811..066044f62f29b6 100644 --- a/eng/common/build.ps1 +++ b/eng/common/build.ps1 @@ -19,6 +19,7 @@ Param( [switch] $pack, [switch] $publish, [switch] $clean, + [switch] $verticalBuild, [switch][Alias('bl')]$binaryLog, [switch][Alias('nobl')]$excludeCIBinarylog, [switch] $ci, @@ -58,6 +59,7 @@ function Print-Usage() { Write-Host " -sign Sign build outputs" Write-Host " -publish Publish artifacts (e.g. symbols)" Write-Host " -clean Clean the solution" + Write-Host " -verticalBuild Run in 'vertical build' infra mode." Write-Host "" Write-Host "Advanced settings:" @@ -120,6 +122,7 @@ function Build { /p:Deploy=$deploy ` /p:Test=$test ` /p:Pack=$pack ` + /p:ArcadeBuildVertical=$verticalBuild ` /p:IntegrationTest=$integrationTest ` /p:PerformanceTest=$performanceTest ` /p:Sign=$sign ` diff --git a/eng/common/build.sh b/eng/common/build.sh index 2c17ba529b913b..5ce01dd161aaf2 100755 --- a/eng/common/build.sh +++ b/eng/common/build.sh @@ -59,6 +59,7 @@ scriptroot="$( cd -P "$( dirname "$source" )" && pwd )" restore=false build=false source_build=false +vertical_build=false rebuild=false test=false integration_test=false @@ -129,6 +130,12 @@ while [[ $# > 0 ]]; do restore=true pack=true ;; + -verticalbuild|-vb) + build=true + vertical_build=true + restore=true + pack=true + ;; -test|-t) test=true ;; @@ -220,6 +227,7 @@ function Build { /p:Restore=$restore \ /p:Build=$build \ /p:ArcadeBuildFromSource=$source_build \ + /p:ArcadeBuildVertical=$vertical_build \ /p:Rebuild=$rebuild \ /p:Test=$test \ /p:Pack=$pack \ diff --git a/eng/common/cross/build-rootfs.sh b/eng/common/cross/build-rootfs.sh index 4228f202e5bfa5..9b2791cf568aae 100755 --- a/eng/common/cross/build-rootfs.sh +++ b/eng/common/cross/build-rootfs.sh @@ -182,12 +182,12 @@ while :; do __AlpinePackages="${__AlpinePackages// lldb-dev/}" __QEMUArch=riscv64 __UbuntuArch=riscv64 - __UbuntuRepo="http://deb.debian.org/debian-ports" + __UbuntuRepo="http://deb.debian.org/debian" __UbuntuPackages="${__UbuntuPackages// libunwind8-dev/}" unset __LLDB_Package - if [[ -e "/usr/share/keyrings/debian-ports-archive-keyring.gpg" ]]; then - __Keyring="--keyring /usr/share/keyrings/debian-ports-archive-keyring.gpg --include=debian-ports-archive-keyring" + if [[ -e "/usr/share/keyrings/debian-archive-keyring.gpg" ]]; then + __Keyring="--keyring /usr/share/keyrings/debian-archive-keyring.gpg --include=debian-archive-keyring" fi ;; ppc64le) diff --git a/eng/common/cross/riscv64/sources.list.sid b/eng/common/cross/riscv64/sources.list.sid index 65f730d224caa6..b5f7a7e6e1eb53 100644 --- a/eng/common/cross/riscv64/sources.list.sid +++ b/eng/common/cross/riscv64/sources.list.sid @@ -1 +1 @@ -deb http://deb.debian.org/debian-ports sid main +deb http://deb.debian.org/debian sid main diff --git a/eng/common/helixpublish.proj b/eng/common/helixpublish.proj index d7f185856e7912..c1323bf4121052 100644 --- a/eng/common/helixpublish.proj +++ b/eng/common/helixpublish.proj @@ -1,3 +1,4 @@ + diff --git a/eng/common/internal/Directory.Build.props b/eng/common/internal/Directory.Build.props index dbf99d82a5c2ec..a735fe9a133ca4 100644 --- a/eng/common/internal/Directory.Build.props +++ b/eng/common/internal/Directory.Build.props @@ -1,4 +1,6 @@ + + diff --git a/eng/common/internal/Tools.csproj b/eng/common/internal/Tools.csproj index 7f5ce6d6081338..8fa77e5b181f89 100644 --- a/eng/common/internal/Tools.csproj +++ b/eng/common/internal/Tools.csproj @@ -1,5 +1,6 @@ + net472 false @@ -27,4 +28,5 @@ + diff --git a/eng/common/sdl/trim-assets-version.ps1 b/eng/common/sdl/trim-assets-version.ps1 index a2e0048770452f..0daa2a9e946289 100644 --- a/eng/common/sdl/trim-assets-version.ps1 +++ b/eng/common/sdl/trim-assets-version.ps1 @@ -72,4 +72,4 @@ catch { Write-Host $_ Write-PipelineTelemetryError -Force -Category 'Sdl' -Message $_ ExitWithExitCode 1 -} \ No newline at end of file +} diff --git a/eng/common/templates/job/job.yml b/eng/common/templates/job/job.yml index 0b01531357e3ad..01c0dd995e4b61 100644 --- a/eng/common/templates/job/job.yml +++ b/eng/common/templates/job/job.yml @@ -136,7 +136,7 @@ jobs: condition: and(succeeded(), in(variables['_SignType'], 'real', 'test'), eq(variables['Agent.Os'], 'Windows_NT')) - ${{ if and(eq(parameters.runAsPublic, 'false'), eq(variables['System.TeamProject'], 'internal')) }}: - - task: NuGetAuthenticate@0 + - task: NuGetAuthenticate@1 - ${{ if and(ne(parameters.artifacts.download, 'false'), ne(parameters.artifacts.download, '')) }}: - task: DownloadPipelineArtifact@2 diff --git a/eng/common/templates/job/publish-build-assets.yml b/eng/common/templates/job/publish-build-assets.yml index 3b25fd97923c6e..3115990d511474 100644 --- a/eng/common/templates/job/publish-build-assets.yml +++ b/eng/common/templates/job/publish-build-assets.yml @@ -63,6 +63,10 @@ jobs: steps: - ${{ if and(eq(parameters.runAsPublic, 'false'), ne(variables['System.TeamProject'], 'public'), notin(variables['Build.Reason'], 'PullRequest')) }}: + - checkout: self + fetchDepth: 3 + clean: true + - task: DownloadBuildArtifacts@0 displayName: Download artifact inputs: @@ -72,7 +76,7 @@ jobs: condition: ${{ parameters.condition }} continueOnError: ${{ parameters.continueOnError }} - - task: NuGetAuthenticate@0 + - task: NuGetAuthenticate@1 - task: PowerShell@2 displayName: Publish Build Assets diff --git a/eng/common/templates/job/source-index-stage1.yml b/eng/common/templates/job/source-index-stage1.yml index b98202aa02d824..795233662623dc 100644 --- a/eng/common/templates/job/source-index-stage1.yml +++ b/eng/common/templates/job/source-index-stage1.yml @@ -1,6 +1,6 @@ parameters: runAsPublic: false - sourceIndexPackageVersion: 1.0.1-20230228.2 + sourceIndexPackageVersion: 1.0.1-20231213.4 sourceIndexPackageSource: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json sourceIndexBuildCommand: powershell -NoLogo -NoProfile -ExecutionPolicy Bypass -Command "eng/common/build.ps1 -restore -build -binarylog -ci" preSteps: [] @@ -30,20 +30,20 @@ jobs: pool: ${{ if eq(variables['System.TeamProject'], 'public') }}: name: $(DncEngPublicBuildPool) - demands: ImageOverride -equals windows.vs2019.amd64.open + demands: ImageOverride -equals windows.vs2022.amd64.open ${{ if eq(variables['System.TeamProject'], 'internal') }}: name: $(DncEngInternalBuildPool) - demands: ImageOverride -equals windows.vs2019.amd64 + demands: ImageOverride -equals windows.vs2022.amd64 steps: - ${{ each preStep in parameters.preSteps }}: - ${{ preStep }} - task: UseDotNet@2 - displayName: Use .NET Core SDK 6 + displayName: Use .NET 8 SDK inputs: packageType: sdk - version: 6.0.x + version: 8.0.x installationPath: $(Agent.TempDirectory)/dotnet workingDirectory: $(Agent.TempDirectory) diff --git a/eng/common/templates/post-build/common-variables.yml b/eng/common/templates/post-build/common-variables.yml index 4ef7bd271fbde5..b9ede10bf099ae 100644 --- a/eng/common/templates/post-build/common-variables.yml +++ b/eng/common/templates/post-build/common-variables.yml @@ -18,7 +18,7 @@ variables: - name: SymbolToolVersion value: 1.0.1 - name: BinlogToolVersion - value: 1.0.8 + value: 1.0.11 - name: runCodesignValidationInjection value: false diff --git a/eng/common/templates/post-build/post-build.yml b/eng/common/templates/post-build/post-build.yml index d64236b28cfb12..bbc010fe73261e 100644 --- a/eng/common/templates/post-build/post-build.yml +++ b/eng/common/templates/post-build/post-build.yml @@ -169,7 +169,7 @@ stages: # This is necessary whenever we want to publish/restore to an AzDO private feed # Since sdk-task.ps1 tries to restore packages we need to do this authentication here # otherwise it'll complain about accessing a private feed. - - task: NuGetAuthenticate@0 + - task: NuGetAuthenticate@1 displayName: 'Authenticate to AzDO Feeds' # Signing validation will optionally work with the buildmanifest file which is downloaded from @@ -267,7 +267,7 @@ stages: BARBuildId: ${{ parameters.BARBuildId }} PromoteToChannelIds: ${{ parameters.PromoteToChannelIds }} - - task: NuGetAuthenticate@0 + - task: NuGetAuthenticate@1 - task: PowerShell@2 displayName: Publish Using Darc diff --git a/eng/common/templates/steps/publish-logs.yml b/eng/common/templates/steps/publish-logs.yml index dadf1c464cd1fb..80861297ddc074 100644 --- a/eng/common/templates/steps/publish-logs.yml +++ b/eng/common/templates/steps/publish-logs.yml @@ -3,7 +3,7 @@ parameters: JobLabel: '' CustomSensitiveDataList: '' # A default - in case value from eng/common/templates/post-build/common-variables.yml is not passed - BinlogToolVersion: '1.0.8' + BinlogToolVersion: '1.0.11' steps: - task: Powershell@2 diff --git a/eng/common/templates/steps/source-build.yml b/eng/common/templates/steps/source-build.yml index 41bbb915736a6e..1d79797363d930 100644 --- a/eng/common/templates/steps/source-build.yml +++ b/eng/common/templates/steps/source-build.yml @@ -105,7 +105,7 @@ steps: Contents: | **/*.log **/*.binlog - artifacts/source-build/self/prebuilt-report/** + artifacts/sb/prebuilt-report/** TargetFolder: '$(Build.StagingDirectory)/BuildLogs' CleanTargetFolder: true continueOnError: true @@ -126,4 +126,4 @@ steps: - task: ComponentGovernanceComponentDetection@0 displayName: Component Detection (Exclude upstream cache) inputs: - ignoreDirectories: '$(Build.SourcesDirectory)/artifacts/source-build/self/src/artifacts/obj/source-built-upstream-cache' + ignoreDirectories: '$(Build.SourcesDirectory)/artifacts/sb/src/artifacts/obj/source-built-upstream-cache' diff --git a/eng/common/tools.ps1 b/eng/common/tools.ps1 index e8def7e6a85f21..0da65b5748a7f8 100644 --- a/eng/common/tools.ps1 +++ b/eng/common/tools.ps1 @@ -165,11 +165,6 @@ function InitializeDotNetCli([bool]$install, [bool]$createSdkLocationFile) { $env:DOTNET_CLI_TELEMETRY_OPTOUT=1 } - # Source Build uses DotNetCoreSdkDir variable - if ($env:DotNetCoreSdkDir -ne $null) { - $env:DOTNET_INSTALL_DIR = $env:DotNetCoreSdkDir - } - # Find the first path on %PATH% that contains the dotnet.exe if ($useInstalledDotNetCli -and (-not $globalJsonHasRuntimes) -and ($env:DOTNET_INSTALL_DIR -eq $null)) { $dotnetExecutable = GetExecutableFileName 'dotnet' @@ -601,7 +596,15 @@ function InitializeBuildTool() { ExitWithExitCode 1 } $dotnetPath = Join-Path $dotnetRoot (GetExecutableFileName 'dotnet') - $buildTool = @{ Path = $dotnetPath; Command = 'msbuild'; Tool = 'dotnet'; Framework = 'net8.0' } + + # Use override if it exists - commonly set by source-build + if ($null -eq $env:_OverrideArcadeInitializeBuildToolFramework) { + $initializeBuildToolFramework="net9.0" + } else { + $initializeBuildToolFramework=$env:_OverrideArcadeInitializeBuildToolFramework + } + + $buildTool = @{ Path = $dotnetPath; Command = 'msbuild'; Tool = 'dotnet'; Framework = $initializeBuildToolFramework } } elseif ($msbuildEngine -eq "vs") { try { $msbuildPath = InitializeVisualStudioMSBuild -install:$restore @@ -676,8 +679,14 @@ function Read-ArcadeSdkVersion() { } function InitializeToolset() { - if (Test-Path variable:global:_ToolsetBuildProj) { - return $global:_ToolsetBuildProj + # For Unified Build/Source-build support, check whether the environment variable is + # set. If it is, then use this as the toolset build project. + if ($env:_InitializeToolset -ne $null) { + return $global:_InitializeToolset = $env:_InitializeToolset + } + + if (Test-Path variable:global:_InitializeToolset) { + return $global:_InitializeToolset } $nugetCache = GetNuGetPackageCachePath @@ -688,7 +697,7 @@ function InitializeToolset() { if (Test-Path $toolsetLocationFile) { $path = Get-Content $toolsetLocationFile -TotalCount 1 if (Test-Path $path) { - return $global:_ToolsetBuildProj = $path + return $global:_InitializeToolset = $path } } @@ -711,7 +720,7 @@ function InitializeToolset() { throw "Invalid toolset path: $path" } - return $global:_ToolsetBuildProj = $path + return $global:_InitializeToolset = $path } function ExitWithExitCode([int] $exitCode) { @@ -763,12 +772,10 @@ function MSBuild() { # new scripts need to work with old packages, so we need to look for the old names/versions (Join-Path $basePath (Join-Path $buildTool.Framework 'Microsoft.DotNet.ArcadeLogging.dll')), (Join-Path $basePath (Join-Path $buildTool.Framework 'Microsoft.DotNet.Arcade.Sdk.dll')), - (Join-Path $basePath (Join-Path netcoreapp2.1 'Microsoft.DotNet.ArcadeLogging.dll')), - (Join-Path $basePath (Join-Path netcoreapp2.1 'Microsoft.DotNet.Arcade.Sdk.dll')) - (Join-Path $basePath (Join-Path netcoreapp3.1 'Microsoft.DotNet.ArcadeLogging.dll')), - (Join-Path $basePath (Join-Path netcoreapp3.1 'Microsoft.DotNet.Arcade.Sdk.dll')) (Join-Path $basePath (Join-Path net7.0 'Microsoft.DotNet.ArcadeLogging.dll')), - (Join-Path $basePath (Join-Path net7.0 'Microsoft.DotNet.Arcade.Sdk.dll')) + (Join-Path $basePath (Join-Path net7.0 'Microsoft.DotNet.Arcade.Sdk.dll')), + (Join-Path $basePath (Join-Path net8.0 'Microsoft.DotNet.ArcadeLogging.dll')), + (Join-Path $basePath (Join-Path net8.0 'Microsoft.DotNet.Arcade.Sdk.dll')) ) $selectedPath = $null foreach ($path in $possiblePaths) { @@ -827,7 +834,8 @@ function MSBuild-Core() { } } - $env:ARCADE_BUILD_TOOL_COMMAND = "$($buildTool.Path) $cmdArgs" + # Be sure quote the path in case there are spaces in the dotnet installation location. + $env:ARCADE_BUILD_TOOL_COMMAND = "`"$($buildTool.Path)`" $cmdArgs" $exitCode = Exec-Process $buildTool.Path $cmdArgs diff --git a/eng/common/tools.sh b/eng/common/tools.sh index e98daf50c6b674..ece4b730795360 100755 --- a/eng/common/tools.sh +++ b/eng/common/tools.sh @@ -123,11 +123,6 @@ function InitializeDotNetCli { # so it doesn't output warnings to the console. export LTTNG_HOME="$HOME" - # Source Build uses DotNetCoreSdkDir variable - if [[ -n "${DotNetCoreSdkDir:-}" ]]; then - export DOTNET_INSTALL_DIR="$DotNetCoreSdkDir" - fi - # Find the first path on $PATH that contains the dotnet.exe if [[ "$use_installed_dotnet_cli" == true && $global_json_has_runtimes == false && -z "${DOTNET_INSTALL_DIR:-}" ]]; then local dotnet_path=`command -v dotnet` @@ -343,7 +338,7 @@ function InitializeBuildTool { _InitializeBuildToolCommand="msbuild" # use override if it exists - commonly set by source-build if [[ "${_OverrideArcadeInitializeBuildToolFramework:-x}" == "x" ]]; then - _InitializeBuildToolFramework="net8.0" + _InitializeBuildToolFramework="net9.0" else _InitializeBuildToolFramework="${_OverrideArcadeInitializeBuildToolFramework}" fi @@ -458,12 +453,10 @@ function MSBuild { local possiblePaths=() possiblePaths+=( "$toolset_dir/$_InitializeBuildToolFramework/Microsoft.DotNet.ArcadeLogging.dll" ) possiblePaths+=( "$toolset_dir/$_InitializeBuildToolFramework/Microsoft.DotNet.Arcade.Sdk.dll" ) - possiblePaths+=( "$toolset_dir/netcoreapp2.1/Microsoft.DotNet.ArcadeLogging.dll" ) - possiblePaths+=( "$toolset_dir/netcoreapp2.1/Microsoft.DotNet.Arcade.Sdk.dll" ) - possiblePaths+=( "$toolset_dir/netcoreapp3.1/Microsoft.DotNet.ArcadeLogging.dll" ) - possiblePaths+=( "$toolset_dir/netcoreapp3.1/Microsoft.DotNet.Arcade.Sdk.dll" ) possiblePaths+=( "$toolset_dir/net7.0/Microsoft.DotNet.ArcadeLogging.dll" ) possiblePaths+=( "$toolset_dir/net7.0/Microsoft.DotNet.Arcade.Sdk.dll" ) + possiblePaths+=( "$toolset_dir/net8.0/Microsoft.DotNet.ArcadeLogging.dll" ) + possiblePaths+=( "$toolset_dir/net8.0/Microsoft.DotNet.Arcade.Sdk.dll" ) for path in "${possiblePaths[@]}"; do if [[ -f $path ]]; then selectedPath=$path diff --git a/global.json b/global.json index 3f2d3ca7be9229..452529c0421108 100644 --- a/global.json +++ b/global.json @@ -8,9 +8,9 @@ "dotnet": "9.0.100-alpha.1.23615.4" }, "msbuild-sdks": { - "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.23607.2", - "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.23607.2", - "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.23607.2", + "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24066.3", + "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24066.3", + "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24066.3", "Microsoft.Build.NoTargets": "3.7.0", "Microsoft.Build.Traversal": "3.4.0", "Microsoft.NET.Sdk.IL": "9.0.0-alpha.1.23617.5" From 6c4130a02510002918288a5b69be5ab6ec917026 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 11:19:10 +0100 Subject: [PATCH 02/28] Update Versions.props --- eng/Versions.props | 2 ++ 1 file changed, 2 insertions(+) diff --git a/eng/Versions.props b/eng/Versions.props index d20542e85c8b6b..938cfc6c6397eb 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -98,6 +98,8 @@ 9.0.0-beta.24066.3 9.0.0-beta.24066.3 9.0.0-beta.24066.3 + + 1.4.0 6.0.0-preview.1.102 From f1813c8ca732afb440e671361d60505b26fbe90c Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 11:06:32 +0000 Subject: [PATCH 03/28] Make xunit.props respect different versions and assert libraries --- eng/testing/xunit/xunit.props | 10 ++++++---- .../tests/Canonicalization/Directory.Build.props | 10 ++++++++++ ...m.Runtime.Serialization.Xml.Canonicalization.csproj | 1 - 3 files changed, 16 insertions(+), 5 deletions(-) create mode 100644 src/libraries/System.Runtime.Serialization.Xml/tests/Canonicalization/Directory.Build.props diff --git a/eng/testing/xunit/xunit.props b/eng/testing/xunit/xunit.props index 64286ff55ea100..c05ed2e6a4ed7d 100644 --- a/eng/testing/xunit/xunit.props +++ b/eng/testing/xunit/xunit.props @@ -6,11 +6,13 @@ - - - - + + + + + + + + true + + + + + \ No newline at end of file diff --git a/src/libraries/System.Runtime.Serialization.Xml/tests/Canonicalization/System.Runtime.Serialization.Xml.Canonicalization.csproj b/src/libraries/System.Runtime.Serialization.Xml/tests/Canonicalization/System.Runtime.Serialization.Xml.Canonicalization.csproj index 9e332f12609925..a07418861d50d8 100644 --- a/src/libraries/System.Runtime.Serialization.Xml/tests/Canonicalization/System.Runtime.Serialization.Xml.Canonicalization.csproj +++ b/src/libraries/System.Runtime.Serialization.Xml/tests/Canonicalization/System.Runtime.Serialization.Xml.Canonicalization.csproj @@ -67,7 +67,6 @@ - \ No newline at end of file From 35a3e14e731cbc99276817367c7d04997bb475fb Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Wed, 17 Jan 2024 13:06:19 +0000 Subject: [PATCH 04/28] Update dependencies from https://github.com/dotnet/arcade build 20240116.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24066.3 From 51646af807953d2b8ac6a315063dfcbdc9103207 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 13:43:02 +0000 Subject: [PATCH 05/28] Avoid XUNIT_SPAN unambiguous call issues --- .../tests/SerialPort/ReadLine.cs | 2 +- .../tests/SerialPort/ReadTo.cs | 2 +- .../System.Memory/tests/Memory/CopyTo.cs | 2 +- .../tests/ReadOnlyMemory/CopyTo.cs | 2 +- .../tests/ReadOnlySpan/CopyTo.cs | 2 +- .../System.Memory/tests/Span/Clear.cs | 4 ++-- .../System.Memory/tests/Span/CopyTo.cs | 2 +- .../System.Memory/tests/Span/Fill.cs | 2 +- .../System.Memory/tests/Span/Reverse.cs | 6 ++--- .../tests/src/Tests/Assembly/AssemblyTests.cs | 24 +++++++++---------- .../Tests/Type/TypeTests.Get.CornerCases.cs | 4 ++-- .../tests/DataContractSerializer.cs | 6 ++--- .../Reflection/TypeTests.Get.CornerCases.cs | 2 +- .../System/StringComparerTests.cs | 4 ++-- .../tests/EnvelopedCms/GeneralTests.cs | 2 +- .../PrecompiledRegexScenarioTest.cs | 8 +++---- 16 files changed, 37 insertions(+), 37 deletions(-) diff --git a/src/libraries/System.IO.Ports/tests/SerialPort/ReadLine.cs b/src/libraries/System.IO.Ports/tests/SerialPort/ReadLine.cs index 66eac82998a62f..6523731aea69ed 100644 --- a/src/libraries/System.IO.Ports/tests/SerialPort/ReadLine.cs +++ b/src/libraries/System.IO.Ports/tests/SerialPort/ReadLine.cs @@ -493,7 +493,7 @@ public void Read_LargeBuffer() com1.Write(com1.NewLine); string receivedLine = com2.ReadLine(); - Assert.Equal(charactersToWrite, receivedLine); + Assert.Equal(charactersToWrite, receivedLine.ToCharArray()); } } diff --git a/src/libraries/System.IO.Ports/tests/SerialPort/ReadTo.cs b/src/libraries/System.IO.Ports/tests/SerialPort/ReadTo.cs index a2d5e6779152da..859f1de1cd6f55 100644 --- a/src/libraries/System.IO.Ports/tests/SerialPort/ReadTo.cs +++ b/src/libraries/System.IO.Ports/tests/SerialPort/ReadTo.cs @@ -517,7 +517,7 @@ public void Read_LargeBuffer() com1.Write(endString); string received = com2.ReadTo(endString); - Assert.Equal(buffer, received); + Assert.Equal(buffer, received.ToCharArray()); } } diff --git a/src/libraries/System.Memory/tests/Memory/CopyTo.cs b/src/libraries/System.Memory/tests/Memory/CopyTo.cs index 3c1b064ac24649..69f9f1fd2a4423 100644 --- a/src/libraries/System.Memory/tests/Memory/CopyTo.cs +++ b/src/libraries/System.Memory/tests/Memory/CopyTo.cs @@ -41,7 +41,7 @@ public static void TryCopyToArraySegmentImplicit() Memory srcMemory = src; bool success = srcMemory.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src, segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/ReadOnlyMemory/CopyTo.cs b/src/libraries/System.Memory/tests/ReadOnlyMemory/CopyTo.cs index a61b969de486d8..e9854fc87b4796 100644 --- a/src/libraries/System.Memory/tests/ReadOnlyMemory/CopyTo.cs +++ b/src/libraries/System.Memory/tests/ReadOnlyMemory/CopyTo.cs @@ -41,7 +41,7 @@ public static void TryCopyToArraySegmentImplicit() ReadOnlyMemory srcMemory = src; bool success = srcMemory.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src.AsSpan(), segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs b/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs index 208a5cbd8c4baf..578f7867ac96ce 100644 --- a/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs +++ b/src/libraries/System.Memory/tests/ReadOnlySpan/CopyTo.cs @@ -42,7 +42,7 @@ public static void TryCopyToArraySegmentImplicit() ReadOnlySpan srcSpan = new ReadOnlySpan(src); bool success = srcSpan.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src, segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/Clear.cs b/src/libraries/System.Memory/tests/Span/Clear.cs index 205ec76d5a483b..feb8a2a4ad784a 100644 --- a/src/libraries/System.Memory/tests/Span/Clear.cs +++ b/src/libraries/System.Memory/tests/Span/Clear.cs @@ -180,7 +180,7 @@ public static void ClearReferenceType() var span = new Span(actual); span.Clear(); - Assert.Equal(expected, actual); + Assert.Equal(expected, actual); } [Fact] @@ -195,7 +195,7 @@ public static void ClearReferenceTypeLonger() var span = new Span(actual); span.Clear(); - Assert.Equal(expected, actual); + Assert.Equal(expected, actual); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/CopyTo.cs b/src/libraries/System.Memory/tests/Span/CopyTo.cs index 5c72f2e71fb007..0e87eea54c61fc 100644 --- a/src/libraries/System.Memory/tests/Span/CopyTo.cs +++ b/src/libraries/System.Memory/tests/Span/CopyTo.cs @@ -42,7 +42,7 @@ public static void TryCopyToArraySegmentImplicit() Span srcSpan = new Span(src); bool success = srcSpan.TryCopyTo(segment); Assert.True(success); - Assert.Equal(src, segment); + Assert.Equal(src, segment); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/Fill.cs b/src/libraries/System.Memory/tests/Span/Fill.cs index 71ea23196584e6..331aefb4b845fd 100644 --- a/src/libraries/System.Memory/tests/Span/Fill.cs +++ b/src/libraries/System.Memory/tests/Span/Fill.cs @@ -84,7 +84,7 @@ public static void FillReferenceType() var span = new Span(actual); span.Fill("d"); - Assert.Equal(expected, actual); + Assert.Equal(expected, actual); } [Fact] diff --git a/src/libraries/System.Memory/tests/Span/Reverse.cs b/src/libraries/System.Memory/tests/Span/Reverse.cs index 359c21bc7a3c6e..9dd46b3a9464a9 100644 --- a/src/libraries/System.Memory/tests/Span/Reverse.cs +++ b/src/libraries/System.Memory/tests/Span/Reverse.cs @@ -40,7 +40,7 @@ public static void ReverseEmptyWithReference() span = actual; span.Slice(2, 0).Reverse(); - Assert.Equal(expected, span.ToArray()); + Assert.Equal(expected, span.ToArray()); } [Fact] @@ -228,7 +228,7 @@ public static void ReverseReferenceType() var span = new Span(actual); span.Reverse(); - Assert.Equal(expected, actual); + Assert.Equal(expected, actual); } [Fact] @@ -240,7 +240,7 @@ public static void ReverseReferenceTwiceReturnsOriginal() var span = new Span(actual); span.Reverse(); span.Reverse(); - Assert.Equal(expected, actual); + Assert.Equal(expected, actual); } [Fact] diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Assembly/AssemblyTests.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Assembly/AssemblyTests.cs index 2dc40fa00d1c94..f938983f131cf6 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Assembly/AssemblyTests.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Assembly/AssemblyTests.cs @@ -347,13 +347,13 @@ public static void AssemblyGetTypes1() Type[] types = upper.GetTypes().OrderBy(t => t.FullName).ToArray(); string[] fullNames = types.Select(t => t.FullName).ToArray(); - string[] expected = { - "Outer1", "Outer1+Inner1", "Outer1+Inner2", "Outer1+Inner3" ,"Outer1+Inner4" ,"Outer1+Inner5", - "Outer2", "Outer2+Inner1", "Outer2+Inner2", "Outer2+Inner3" ,"Outer2+Inner4" ,"Outer2+Inner5", + string[] expected = [ + "Outer1", "Outer1+Inner1", "Outer1+Inner2", "Outer1+Inner3", "Outer1+Inner4", "Outer1+Inner5", + "Outer2", "Outer2+Inner1", "Outer2+Inner2", "Outer2+Inner3", "Outer2+Inner4", "Outer2+Inner5", "Upper1", "Upper4" - }; + ]; - Assert.Equal(expected, fullNames); + Assert.Equal(expected, fullNames); } } @@ -366,8 +366,8 @@ public static void AssemblyGetExportedTypes1() Type[] types = upper.GetExportedTypes().OrderBy(t => t.FullName).ToArray(); string[] fullNames = types.Select(t => t.FullName).ToArray(); - string[] expected = { "Outer1", "Outer1+Inner1", "Upper1" }; - Assert.Equal(expected, fullNames); + string[] expected = [ "Outer1", "Outer1+Inner1", "Upper1" ]; + Assert.Equal(expected, fullNames); } } @@ -384,8 +384,8 @@ public static void AssemblyGetForwardedTypes1() Type[] types = upper.GetForwardedTypesThunk().OrderBy(t => t.FullName).ToArray(); string[] fullNames = types.Select(t => t.FullName).ToArray(); - string[] expected = { "Middle2", "Upper2", "Upper3", "Upper3+Upper3a" }; - Assert.Equal(expected, fullNames); + string[] expected = [ "Middle2", "Upper2", "Upper3", "Upper3+Upper3a" ]; + Assert.Equal(expected, fullNames); } } @@ -441,7 +441,7 @@ public static void AssemblyWithEmbeddedResources() Assembly a = lc.LoadFromByteArray(TestData.s_AssemblyWithEmbeddedResourcesImage); string[] names = a.GetManifestResourceNames().OrderBy(s => s).ToArray(); - Assert.Equal(new string[] { "MyRes1", "MyRes2", "MyRes3" }, names); + Assert.Equal([ "MyRes1", "MyRes2", "MyRes3" ], names); foreach (string name in names) { ManifestResourceInfo mri = a.GetManifestResourceInfo(name); @@ -491,7 +491,7 @@ public static void AssemblyWithResourcesInManifestFile() Assembly a = lc.LoadFromAssemblyPath(assemblyPath); string[] names = a.GetManifestResourceNames().OrderBy(s => s).ToArray(); - Assert.Equal(new string[] { "MyRes1", "MyRes2", "MyRes3" }, names); + Assert.Equal([ "MyRes1", "MyRes2", "MyRes3" ], names); foreach (string name in names) { ManifestResourceInfo mri = a.GetManifestResourceInfo(name); @@ -536,7 +536,7 @@ public static void AssemblyWithResourcesInModule() Assembly a = lc.LoadFromAssemblyPath(assemblyPath); string[] names = a.GetManifestResourceNames().OrderBy(s => s).ToArray(); - Assert.Equal(new string[] { "MyRes1", "MyRes2", "MyRes3" }, names); + Assert.Equal([ "MyRes1", "MyRes2", "MyRes3" ], names); foreach (string name in names) { ManifestResourceInfo mri = a.GetManifestResourceInfo(name); diff --git a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs index 14ecdecd23c9af..80305779cdf2a0 100644 --- a/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs +++ b/src/libraries/System.Reflection.MetadataLoadContext/tests/src/Tests/Type/TypeTests.Get.CornerCases.cs @@ -237,8 +237,8 @@ public static void GetPropertyHidesPropertiesByNameAndSigAndCallingConventionCom } names.Sort(); - string[] expected = { "Item", nameof(Base.MyInstanceThenStaticProp), nameof(Base.MyStaticThenInstanceProp), nameof(Base.MyStringThenDoubleProp) }; - Assert.Equal(expected, names.ToArray()); + string[] expected = [ "Item", nameof(Base.MyInstanceThenStaticProp), nameof(Base.MyStaticThenInstanceProp), nameof(Base.MyStringThenDoubleProp) ]; + Assert.Equal(expected, names.ToArray()); } private abstract class Base diff --git a/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs b/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs index a7ffda68b113aa..8a7acf0800596e 100644 --- a/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs +++ b/src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializer.cs @@ -1211,9 +1211,9 @@ public static void DCS_JaggedArrayAsRoot() string[][] jaggedStringArray = new string[][] { new string[] { "1", "3", "5", "7", "9" }, new string[] { "0", "2", "4", "6" }, new string[] { "11", "22" } }; var actualJaggedStringArray = DataContractSerializerHelper.SerializeAndDeserialize(jaggedStringArray, @"1357902461122"); - Assert.Equal(jaggedStringArray[0], actualJaggedStringArray[0]); - Assert.Equal(jaggedStringArray[1], actualJaggedStringArray[1]); - Assert.Equal(jaggedStringArray[2], actualJaggedStringArray[2]); + Assert.Equal(jaggedStringArray[0], actualJaggedStringArray[0]); + Assert.Equal(jaggedStringArray[1], actualJaggedStringArray[1]); + Assert.Equal(jaggedStringArray[2], actualJaggedStringArray[2]); object[] objectArray = new object[] { 1, 1.0F, 1.0, "string", Guid.Parse("2054fd3e-e118-476a-9962-1a882be51860"), new DateTime(2013, 1, 2) }; var actualObjectArray = DataContractSerializerHelper.SerializeAndDeserialize(objectArray, @"111string2054fd3e-e118-476a-9962-1a882be518602013-01-02T00:00:00"); diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/TypeTests.Get.CornerCases.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/TypeTests.Get.CornerCases.cs index 67c99cce94312e..5adab84fcc60e4 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/TypeTests.Get.CornerCases.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/Reflection/TypeTests.Get.CornerCases.cs @@ -244,7 +244,7 @@ public static void GetPropertyHidesPropertiesByNameAndSigAndCallingConventionCom names.Sort(); string[] expected = { "Item", nameof(Base.MyInstanceThenStaticProp), nameof(Base.MyStaticThenInstanceProp), nameof(Base.MyStringThenDoubleProp) }; - Assert.Equal(expected, names.ToArray()); + Assert.Equal(expected, names.ToArray()); } private abstract class Base diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/StringComparerTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/StringComparerTests.cs index b6160f82fcea42..a7cff83c06b185 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/StringComparerTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Tests/System/StringComparerTests.cs @@ -68,10 +68,10 @@ public void Compare_ViaSort_SortsAsExpected() string[] strings = new[] { "a", "b", "AB", "A", "cde", "abc", "f", "123", "ab" }; Array.Sort(strings, StringComparer.OrdinalIgnoreCase); - Assert.Equal(strings, new[] { "123", "a", "A", "AB", "ab", "abc", "b", "cde", "f" }); + Assert.Equal(strings, new[] { "123", "a", "A", "AB", "ab", "abc", "b", "cde", "f" }); Array.Sort(strings, StringComparer.Ordinal); - Assert.Equal(strings, new[] { "123", "A", "AB", "a", "ab", "abc", "b", "cde", "f" }); + Assert.Equal(strings, new[] { "123", "A", "AB", "a", "ab", "abc", "b", "cde", "f" }); } [Fact] diff --git a/src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/GeneralTests.cs b/src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/GeneralTests.cs index a9d532d6722f5f..2d4c1b8ac21931 100644 --- a/src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/GeneralTests.cs +++ b/src/libraries/System.Security.Cryptography.Pkcs/tests/EnvelopedCms/GeneralTests.cs @@ -132,7 +132,7 @@ private static void VerifyRecipients3(byte[] encodedMessage) col.CopyTo(recipients, 0); string[] actualIssuers = recipients.Select(r => r.RecipientIdentifier.Value).Cast().Select(xis => xis.IssuerName).OrderBy(s => s).ToArray(); - Assert.Equal(expectedIssuers, actualIssuers); + Assert.Equal(expectedIssuers, actualIssuers); } [Fact] diff --git a/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/PrecompiledRegexScenarioTest.cs b/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/PrecompiledRegexScenarioTest.cs index a22c493303b632..264abb8ef567d0 100644 --- a/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/PrecompiledRegexScenarioTest.cs +++ b/src/libraries/System.Text.RegularExpressions/tests/FunctionalTests/PrecompiledRegexScenarioTest.cs @@ -70,8 +70,8 @@ public void PrecompiledRegex_SplitTest() { RegexTestClass testClass = new RegexTestClass(); - Assert.Equal(["", "4", "success", "\n", "5", "success", "\n", "6", "success", "\n", "7", "success", ""], testClass.Split(textWithMultipleMatches)); - Assert.Equal(["", "4", "success", $"\nbsdf135success1245somethingelse{Environment.NewLine}csdf136success2245somethingnew{Environment.NewLine}dsdf137success3245somethingold"], testClass.Split(textWithMultipleMatches, 2)); + Assert.Equal(["", "4", "success", "\n", "5", "success", "\n", "6", "success", "\n", "7", "success", ""], testClass.Split(textWithMultipleMatches)); + Assert.Equal(["", "4", "success", $"\nbsdf135success1245somethingelse{Environment.NewLine}csdf136success2245somethingnew{Environment.NewLine}dsdf137success3245somethingold"], testClass.Split(textWithMultipleMatches, 2)); } [Fact] @@ -97,8 +97,8 @@ public void PrecompiledRegex_Groups() RegexTestClass testClass = new RegexTestClass(); Assert.Equal(text, testClass.Match(text).Groups[0].Value); - Assert.Equal([0, 1, 2], testClass.GetGroupNumbers()); - Assert.Equal(["0", "1", "output"], testClass.GetGroupNames()); + Assert.Equal(new int[] { 0, 1, 2 }, testClass.GetGroupNumbers()); + Assert.Equal(["0", "1", "output"], testClass.GetGroupNames()); } } } From 2aab1e241333509cd286bfbc5f6f6f3a02c65d3b Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 14:46:19 +0000 Subject: [PATCH 06/28] Disable obsoletion warning for xunit Delegating*Sink --- .../Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs b/src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs index 0cb4c94e4c8d12..86991cbd9bc4db 100644 --- a/src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs +++ b/src/libraries/Common/tests/SingleFileTestRunner/SingleFileTestRunner.cs @@ -44,11 +44,14 @@ public static int Main(string[] args) var diagnosticSink = new ConsoleDiagnosticMessageSink(); var testsFinished = new TaskCompletionSource(); var testSink = new TestMessageSink(); + +#pragma warning disable CS0618 // Delegating*Sink types are marked obsolete var summarySink = new DelegatingExecutionSummarySink(testSink, () => false, (completed, summary) => Console.WriteLine($"Tests run: {summary.Total}, Errors: {summary.Errors}, Failures: {summary.Failed}, Skipped: {summary.Skipped}. Time: {TimeSpan.FromSeconds((double)summary.Time).TotalSeconds}s")); var resultsXmlAssembly = new XElement("assembly"); var resultsSink = new DelegatingXmlCreationSink(summarySink, resultsXmlAssembly); +#pragma warning restore CS0618 testSink.Execution.TestSkippedEvent += args => { Console.WriteLine($"[SKIP] {args.Message.Test.DisplayName}"); }; testSink.Execution.TestFailedEvent += args => { Console.WriteLine($"[FAIL] {args.Message.Test.DisplayName}{Environment.NewLine}{Xunit.ExceptionUtility.CombineMessages(args.Message)}{Environment.NewLine}{Xunit.ExceptionUtility.CombineStackTraces(args.Message)}"); }; From ebfd0cb08c737370fa36ff18f0bd1ef4f35a4b20 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 18:35:26 +0000 Subject: [PATCH 07/28] Fix nullable collection test --- .../Conformance.dynamic.context.indexer.genclass.cs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs index 75c76c34c69615..c601ee0f46c3c9 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs @@ -801,7 +801,9 @@ public static void TryCatchFinally() } Assert.True(threwException); - Assert.Equal(new int?[] { null, null, null }, result); + // Assert.Equal doesn't allow to build collections with nulls in anymore. + // The official recommendation is to bypass the compiler check. + Assert.Equal(new int?[] { null, null, null }!, result!); Assert.Equal(1, MemberClass.t_status); } } From dd3ac471e5d9346abb9f04f0971be8539bcdf625 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 19:07:29 +0000 Subject: [PATCH 08/28] Fix "DynamicObject_MissingProperty" null test --- .../CustomConverterTests.Dynamic.Sample.Tests.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/CustomConverterTests/CustomConverterTests.Dynamic.Sample.Tests.cs b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/CustomConverterTests/CustomConverterTests.Dynamic.Sample.Tests.cs index 3e0f7c2de9b758..69c53e91e37d37 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/CustomConverterTests/CustomConverterTests.Dynamic.Sample.Tests.cs +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/CustomConverterTests/CustomConverterTests.Dynamic.Sample.Tests.cs @@ -314,7 +314,7 @@ public static void DynamicObject_MissingProperty() dynamic obj = JsonSerializer.Deserialize("{}", options); // We return null here; ExpandoObject throws for missing properties. - Assert.Equal(null, obj.NonExistingProperty); + Assert.Null(obj.NonExistingProperty); } [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))] From 00e9a4c3be6dd8559c70469b178e581d9bf47d04 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 19:17:57 +0000 Subject: [PATCH 09/28] Remove unnecessary Extensions references --- src/mono/wasm/symbolicator/WasmSymbolicator.csproj | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mono/wasm/symbolicator/WasmSymbolicator.csproj b/src/mono/wasm/symbolicator/WasmSymbolicator.csproj index a21bb42d0506af..6d290842a3080e 100644 --- a/src/mono/wasm/symbolicator/WasmSymbolicator.csproj +++ b/src/mono/wasm/symbolicator/WasmSymbolicator.csproj @@ -9,9 +9,9 @@ - - + + From e284d1f5d73b20874ec483652cef29412c1a7b91 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 20:18:52 +0100 Subject: [PATCH 10/28] Update dependencies from xharness 9.0.0-prerelease.24066.3 --- .config/dotnet-tools.json | 2 +- eng/Version.Details.xml | 12 ++++++------ eng/Versions.props | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index ce102f3f63e097..b161f32faf492d 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -15,7 +15,7 @@ ] }, "microsoft.dotnet.xharness.cli": { - "version": "9.0.0-prerelease.23611.1", + "version": "9.0.0-prerelease.24066.3", "commands": [ "xharness" ] diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index bc49fad10b0907..be93e87694d213 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -321,17 +321,17 @@ https://github.com/dotnet/runtime 4dffd80c4d77c27e772a0be26e8036af77fbb26e - + https://github.com/dotnet/xharness - a855ee8bf3e90a5baef9de25ccff5be597390087 + fa3b643cc0b028ae875546b7527927adcfcd9348 - + https://github.com/dotnet/xharness - a855ee8bf3e90a5baef9de25ccff5be597390087 + fa3b643cc0b028ae875546b7527927adcfcd9348 - + https://github.com/dotnet/xharness - a855ee8bf3e90a5baef9de25ccff5be597390087 + fa3b643cc0b028ae875546b7527927adcfcd9348 https://github.com/dotnet/arcade diff --git a/eng/Versions.props b/eng/Versions.props index 938cfc6c6397eb..e8cfca6efb4170 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -181,9 +181,9 @@ 1.4.0 17.4.0-preview-20220707-01 - 9.0.0-prerelease.23611.1 - 9.0.0-prerelease.23611.1 - 9.0.0-prerelease.23611.1 + 9.0.0-prerelease.24066.3 + 9.0.0-prerelease.24066.3 + 9.0.0-prerelease.24066.3 9.0.0-alpha.0.23618.4 3.12.0 4.1.0 From 031337b5518b5e6aff62fe4088c556223314aa77 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Wed, 17 Jan 2024 20:41:58 +0000 Subject: [PATCH 11/28] Try to fix TryCatchFinally test for real --- .../Conformance.dynamic.context.indexer.genclass.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs index c601ee0f46c3c9..8d726278937fd3 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs @@ -803,7 +803,7 @@ public static void TryCatchFinally() Assert.True(threwException); // Assert.Equal doesn't allow to build collections with nulls in anymore. // The official recommendation is to bypass the compiler check. - Assert.Equal(new int?[] { null, null, null }!, result!); + Assert.Equal((new int?[] { null, null, null })!, result!); Assert.Equal(1, MemberClass.t_status); } } From f14eb8748f4c76f04d31d204087191530e344dd5 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 18 Jan 2024 08:46:23 +0000 Subject: [PATCH 12/28] Fix TryCatchFinally for real real --- .../Conformance.dynamic.context.indexer.genclass.cs | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs index 8d726278937fd3..decf102c78871c 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs @@ -801,9 +801,8 @@ public static void TryCatchFinally() } Assert.True(threwException); - // Assert.Equal doesn't allow to build collections with nulls in anymore. - // The official recommendation is to bypass the compiler check. - Assert.Equal((new int?[] { null, null, null })!, result!); + // Assert.Equal doesn't allow to build collections with nulls in anymore. Use Assert.Collection instead. + Assert.Collection(result, (a) => Assert.Null(a), (b) => Assert.Null(b), (c) => Assert.Null(c)); Assert.Equal(1, MemberClass.t_status); } } From b6e0a812b7e23a8f1639342ad063a298d34ea296 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Thu, 18 Jan 2024 08:48:54 +0000 Subject: [PATCH 13/28] Update dependencies from https://github.com/dotnet/arcade build 20240117.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24067.4 --- eng/Version.Details.xml | 80 ++++++++++----------- eng/Versions.props | 32 ++++----- eng/common/build.ps1 | 3 + eng/common/build.sh | 13 ++++ eng/common/templates/steps/source-build.yml | 1 + global.json | 6 +- 6 files changed, 76 insertions(+), 59 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index be93e87694d213..be560c0b708655 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -111,82 +111,82 @@ - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 https://github.com/dotnet/runtime-assets @@ -333,9 +333,9 @@ https://github.com/dotnet/xharness fa3b643cc0b028ae875546b7527927adcfcd9348 - + https://github.com/dotnet/arcade - d5ee27a55ec6383c29790f3ec666e7c87f7da022 + 269a0e658ebd52b02a34072dc99277be43fe58f7 https://dev.azure.com/dnceng/internal/_git/dotnet-optimization diff --git a/eng/Versions.props b/eng/Versions.props index e8cfca6efb4170..4af995cab5b383 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -82,22 +82,22 @@ 9.0.100-alpha.1.23551.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 2.6.6-beta.24066.3 - 9.0.0-beta.24066.3 - 2.6.6-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 - 9.0.0-beta.24066.3 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 2.6.6-beta.24067.4 + 9.0.0-beta.24067.4 + 2.6.6-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 + 9.0.0-beta.24067.4 1.4.0 diff --git a/eng/common/build.ps1 b/eng/common/build.ps1 index 066044f62f29b6..510458eb35b84b 100644 --- a/eng/common/build.ps1 +++ b/eng/common/build.ps1 @@ -20,6 +20,7 @@ Param( [switch] $publish, [switch] $clean, [switch] $verticalBuild, + [switch][Alias('pb')]$productBuild, [switch][Alias('bl')]$binaryLog, [switch][Alias('nobl')]$excludeCIBinarylog, [switch] $ci, @@ -60,6 +61,7 @@ function Print-Usage() { Write-Host " -publish Publish artifacts (e.g. symbols)" Write-Host " -clean Clean the solution" Write-Host " -verticalBuild Run in 'vertical build' infra mode." + Write-Host " -productBuild Build the solution in the way it will be built in the full .NET product (VMR) build (short: -pb)" Write-Host "" Write-Host "Advanced settings:" @@ -122,6 +124,7 @@ function Build { /p:Deploy=$deploy ` /p:Test=$test ` /p:Pack=$pack ` + /p:DotNetBuildRepo=$($productBuild -or $verticalBuild) ` /p:ArcadeBuildVertical=$verticalBuild ` /p:IntegrationTest=$integrationTest ` /p:PerformanceTest=$performanceTest ` diff --git a/eng/common/build.sh b/eng/common/build.sh index 5ce01dd161aaf2..2dfb32f2ec4913 100755 --- a/eng/common/build.sh +++ b/eng/common/build.sh @@ -22,6 +22,9 @@ usage() echo " --sourceBuild Source-build the solution (short: -sb)" echo " Will additionally trigger the following actions: --restore, --build, --pack" echo " If --configuration is not set explicitly, will also set it to 'Release'" + echo " --productBuild Build the solution in the way it will be built in the full .NET product (VMR) build (short: -pb)" + echo " Will additionally trigger the following actions: --restore, --build, --pack" + echo " If --configuration is not set explicitly, will also set it to 'Release'" echo " --rebuild Rebuild solution" echo " --test Run all unit tests in the solution (short: -t)" echo " --integrationTest Run all integration tests in the solution" @@ -60,6 +63,7 @@ restore=false build=false source_build=false vertical_build=false +product_build=false rebuild=false test=false integration_test=false @@ -127,12 +131,20 @@ while [[ $# > 0 ]]; do -sourcebuild|-sb) build=true source_build=true + product_build=true + restore=true + pack=true + ;; + -productBuild|-pb) + build=true + product_build=true restore=true pack=true ;; -verticalbuild|-vb) build=true vertical_build=true + product_build=true restore=true pack=true ;; @@ -226,6 +238,7 @@ function Build { /p:RepoRoot="$repo_root" \ /p:Restore=$restore \ /p:Build=$build \ + /p:DotNetBuildRepo=$product_build \ /p:ArcadeBuildFromSource=$source_build \ /p:ArcadeBuildVertical=$vertical_build \ /p:Rebuild=$rebuild \ diff --git a/eng/common/templates/steps/source-build.yml b/eng/common/templates/steps/source-build.yml index 1d79797363d930..1793eb6beb9f7f 100644 --- a/eng/common/templates/steps/source-build.yml +++ b/eng/common/templates/steps/source-build.yml @@ -94,6 +94,7 @@ steps: $baseOsArgs \ /p:SourceBuildNonPortable=${{ parameters.platform.nonPortable }} \ /p:ArcadeBuildFromSource=true \ + /p:DotNetBuildRepo=true \ /p:AssetManifestFileName=$assetManifestFileName displayName: Build diff --git a/global.json b/global.json index 452529c0421108..198fde6d2109ba 100644 --- a/global.json +++ b/global.json @@ -8,9 +8,9 @@ "dotnet": "9.0.100-alpha.1.23615.4" }, "msbuild-sdks": { - "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24066.3", - "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24066.3", - "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24066.3", + "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24067.4", + "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24067.4", + "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24067.4", "Microsoft.Build.NoTargets": "3.7.0", "Microsoft.Build.Traversal": "3.4.0", "Microsoft.NET.Sdk.IL": "9.0.0-alpha.1.23617.5" From 67514c5b0e41542816ce17b6a083e12cd25dc2df Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Thu, 18 Jan 2024 09:24:37 +0000 Subject: [PATCH 14/28] Fix TryCatchFinally for real real real --- .../Conformance.dynamic.context.indexer.genclass.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs index decf102c78871c..ffbae381f5ad97 100644 --- a/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs +++ b/src/libraries/System.Runtime/tests/System.Dynamic.Runtime.Tests/Dynamic.Context/Conformance.dynamic.context.indexer.genclass.cs @@ -801,8 +801,9 @@ public static void TryCatchFinally() } Assert.True(threwException); + int?[] resultIntegers = result; // Assert.Equal doesn't allow to build collections with nulls in anymore. Use Assert.Collection instead. - Assert.Collection(result, (a) => Assert.Null(a), (b) => Assert.Null(b), (c) => Assert.Null(c)); + Assert.Collection(resultIntegers, (a) => Assert.Null(a), (b) => Assert.Null(b), (c) => Assert.Null(c)); Assert.Equal(1, MemberClass.t_status); } } From 976cdc31ec435cf80090e23b74cc0f78f159d30d Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Thu, 18 Jan 2024 13:06:21 +0000 Subject: [PATCH 15/28] Update dependencies from https://github.com/dotnet/arcade build 20240118.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24068.1 --- eng/Version.Details.xml | 80 ++++++++++++++++++++--------------------- eng/Versions.props | 32 ++++++++--------- global.json | 6 ++-- 3 files changed, 59 insertions(+), 59 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index be560c0b708655..f40e6a986bec96 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -111,82 +111,82 @@ - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc https://github.com/dotnet/runtime-assets @@ -333,9 +333,9 @@ https://github.com/dotnet/xharness fa3b643cc0b028ae875546b7527927adcfcd9348 - + https://github.com/dotnet/arcade - 269a0e658ebd52b02a34072dc99277be43fe58f7 + c246c9d7bfb98646ec52a18471d075219b26dccc https://dev.azure.com/dnceng/internal/_git/dotnet-optimization diff --git a/eng/Versions.props b/eng/Versions.props index 4af995cab5b383..f228490fa879fc 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -82,22 +82,22 @@ 9.0.100-alpha.1.23551.3 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 2.6.6-beta.24067.4 - 9.0.0-beta.24067.4 - 2.6.6-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 - 9.0.0-beta.24067.4 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 2.6.6-beta.24068.1 + 9.0.0-beta.24068.1 + 2.6.6-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 + 9.0.0-beta.24068.1 1.4.0 diff --git a/global.json b/global.json index 198fde6d2109ba..d2a332614dcdc6 100644 --- a/global.json +++ b/global.json @@ -8,9 +8,9 @@ "dotnet": "9.0.100-alpha.1.23615.4" }, "msbuild-sdks": { - "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24067.4", - "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24067.4", - "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24067.4", + "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24068.1", + "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24068.1", + "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24068.1", "Microsoft.Build.NoTargets": "3.7.0", "Microsoft.Build.Traversal": "3.4.0", "Microsoft.NET.Sdk.IL": "9.0.0-alpha.1.23617.5" From 913d0317bab0f9d47cd0ce6d7b70fecdde9466ed Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Thu, 18 Jan 2024 15:29:18 +0100 Subject: [PATCH 16/28] Work around Mono issue in AppDomainTests.AssemblyLoad --- .../System/AppDomainTests.cs | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs index f473d1dec82762..1ef1c6557a749d 100644 --- a/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs +++ b/src/libraries/System.Runtime/tests/System.Runtime.Extensions.Tests/System/AppDomainTests.cs @@ -512,9 +512,14 @@ public void AssemblyLoad() { RemoteExecutor.Invoke(() => { bool AssemblyLoadFlag = false; + bool isMono = PlatformDetection.IsMonoRuntime; AssemblyLoadEventHandler handler = (sender, args) => { - Assert.Equal(AppDomain.CurrentDomain, sender); + if (isMono) + Assert.True(AppDomain.CurrentDomain == sender); + else + Assert.Equal(AppDomain.CurrentDomain, sender); + Assert.NotNull(args); Assert.NotNull(args.LoadedAssembly); From e0813a382c2bf77f366b3f88c5bb0c552523e044 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Fri, 19 Jan 2024 13:06:03 +0000 Subject: [PATCH 17/28] Update dependencies from https://github.com/dotnet/arcade build 20240118.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24068.4 --- eng/Version.Details.xml | 80 ++++++++++++++++---------------- eng/Versions.props | 32 ++++++------- eng/common/cross/build-rootfs.sh | 16 +++---- global.json | 6 +-- 4 files changed, 67 insertions(+), 67 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index f40e6a986bec96..fdf0ff7c9a8bc4 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -111,82 +111,82 @@ - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 https://github.com/dotnet/runtime-assets @@ -333,9 +333,9 @@ https://github.com/dotnet/xharness fa3b643cc0b028ae875546b7527927adcfcd9348 - + https://github.com/dotnet/arcade - c246c9d7bfb98646ec52a18471d075219b26dccc + 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 https://dev.azure.com/dnceng/internal/_git/dotnet-optimization diff --git a/eng/Versions.props b/eng/Versions.props index f228490fa879fc..6490dd98d52a16 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -82,22 +82,22 @@ 9.0.100-alpha.1.23551.3 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 2.6.6-beta.24068.1 - 9.0.0-beta.24068.1 - 2.6.6-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 - 9.0.0-beta.24068.1 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 2.6.6-beta.24068.4 + 9.0.0-beta.24068.4 + 2.6.6-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 + 9.0.0-beta.24068.4 1.4.0 diff --git a/eng/common/cross/build-rootfs.sh b/eng/common/cross/build-rootfs.sh index 9b2791cf568aae..9fa764e78b0434 100755 --- a/eng/common/cross/build-rootfs.sh +++ b/eng/common/cross/build-rootfs.sh @@ -8,7 +8,7 @@ usage() echo "BuildArch can be: arm(default), arm64, armel, armv6, ppc64le, riscv64, s390x, x64, x86" echo "CodeName - optional, Code name for Linux, can be: xenial(default), zesty, bionic, alpine" echo " for alpine can be specified with version: alpineX.YY or alpineedge" - echo " for FreeBSD can be: freebsd12, freebsd13" + echo " for FreeBSD can be: freebsd13, freebsd14" echo " for illumos can be: illumos" echo " for Haiku can be: haiku." echo "lldbx.y - optional, LLDB version, can be: lldb3.9(default), lldb4.0, lldb5.0, lldb6.0 no-lldb. Ignored for alpine and FreeBSD" @@ -71,9 +71,9 @@ __AlpinePackages+=" krb5-dev" __AlpinePackages+=" openssl-dev" __AlpinePackages+=" zlib-dev" -__FreeBSDBase="12.4-RELEASE" -__FreeBSDPkg="1.17.0" -__FreeBSDABI="12" +__FreeBSDBase="13.2-RELEASE" +__FreeBSDPkg="1.20.0" +__FreeBSDABI="13" __FreeBSDPackages="libunwind" __FreeBSDPackages+=" icu" __FreeBSDPackages+=" libinotify" @@ -334,14 +334,14 @@ while :; do __AlpineVersion="$__AlpineMajorVersion.$__AlpineMinoVersion" fi ;; - freebsd12) + freebsd13) __CodeName=freebsd __SkipUnmount=1 ;; - freebsd13) + freebsd14) __CodeName=freebsd - __FreeBSDBase="13.2-RELEASE" - __FreeBSDABI="13" + __FreeBSDBase="14.0-RELEASE" + __FreeBSDABI="14" __SkipUnmount=1 ;; illumos) diff --git a/global.json b/global.json index d2a332614dcdc6..5a9d30d4b405d5 100644 --- a/global.json +++ b/global.json @@ -8,9 +8,9 @@ "dotnet": "9.0.100-alpha.1.23615.4" }, "msbuild-sdks": { - "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24068.1", - "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24068.1", - "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24068.1", + "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24068.4", + "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24068.4", + "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24068.4", "Microsoft.Build.NoTargets": "3.7.0", "Microsoft.Build.Traversal": "3.4.0", "Microsoft.NET.Sdk.IL": "9.0.0-alpha.1.23617.5" From bddd44418ae5ee60b659bd29ca4b63a3f7932403 Mon Sep 17 00:00:00 2001 From: "dotnet-maestro[bot]" Date: Fri, 19 Jan 2024 16:33:29 +0000 Subject: [PATCH 18/28] Update dependencies from https://github.com/dotnet/arcade build 20240119.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitAssert , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.23607.2 -> To Version 9.0.0-beta.24069.2 --- eng/Version.Details.xml | 80 ++++++++++++++++++++--------------------- eng/Versions.props | 32 ++++++++--------- global.json | 6 ++-- 3 files changed, 59 insertions(+), 59 deletions(-) diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index fdf0ff7c9a8bc4..acafc53479cb70 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -111,82 +111,82 @@ - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 https://github.com/dotnet/runtime-assets @@ -333,9 +333,9 @@ https://github.com/dotnet/xharness fa3b643cc0b028ae875546b7527927adcfcd9348 - + https://github.com/dotnet/arcade - 3ce3eaf210b1f815e5f90b33865d8cc5e9ed9849 + abddd0bd5145578246dcadda264c7557f2a935a9 https://dev.azure.com/dnceng/internal/_git/dotnet-optimization diff --git a/eng/Versions.props b/eng/Versions.props index 6490dd98d52a16..c6fdf1b26f29c9 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -82,22 +82,22 @@ 9.0.100-alpha.1.23551.3 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 2.6.6-beta.24068.4 - 9.0.0-beta.24068.4 - 2.6.6-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 - 9.0.0-beta.24068.4 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 2.6.7-beta.24069.2 + 9.0.0-beta.24069.2 + 2.6.7-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 + 9.0.0-beta.24069.2 1.4.0 diff --git a/global.json b/global.json index 5a9d30d4b405d5..6d0da0394c451f 100644 --- a/global.json +++ b/global.json @@ -8,9 +8,9 @@ "dotnet": "9.0.100-alpha.1.23615.4" }, "msbuild-sdks": { - "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24068.4", - "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24068.4", - "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24068.4", + "Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24069.2", + "Microsoft.DotNet.Helix.Sdk": "9.0.0-beta.24069.2", + "Microsoft.DotNet.SharedFramework.Sdk": "9.0.0-beta.24069.2", "Microsoft.Build.NoTargets": "3.7.0", "Microsoft.Build.Traversal": "3.4.0", "Microsoft.NET.Sdk.IL": "9.0.0-alpha.1.23617.5" From 913a9702720f91a6b969f68f9a30957aeb6756c8 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Fri, 19 Jan 2024 19:10:22 +0100 Subject: [PATCH 19/28] Update xunit.props --- eng/testing/xunit/xunit.props | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/eng/testing/xunit/xunit.props b/eng/testing/xunit/xunit.props index c05ed2e6a4ed7d..64286ff55ea100 100644 --- a/eng/testing/xunit/xunit.props +++ b/eng/testing/xunit/xunit.props @@ -6,13 +6,11 @@ - - - - - - + + + + - - + + + + + + + + true From f5729ce8fde51ebce389f3e2d505119cdfda7096 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Sun, 21 Jan 2024 18:10:18 +0100 Subject: [PATCH 23/28] Disable AmbiguousImplementationException.ilproj and Pause_ro.csproj too They also fail with https://github.com/dotnet/runtime/issues/97272 --- .../JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj | 6 +++++- .../AmbiguousImplementationException.ilproj | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj b/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj index 0594f730cc5cb4..3876174ce18510 100644 --- a/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj +++ b/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj @@ -5,7 +5,11 @@ true - true + true + + + true + Embedded True diff --git a/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj b/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj index 700e63400f8737..bc77733010e15a 100644 --- a/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj +++ b/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj @@ -2,6 +2,9 @@ true + + + true Full From 4a6bdb841eafab84acd1e0e0ae5423acc893651c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexander=20K=C3=B6plinger?= Date: Sun, 21 Jan 2024 19:31:30 +0100 Subject: [PATCH 24/28] Disable Regression2_Regressions.csproj too --- src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj b/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj index 6818e8aec539f6..d8d7f7f5bcd8ea 100644 --- a/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj +++ b/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj @@ -6,6 +6,9 @@ true true + + + true None From 464babf92b9b937b469393d7fe2057b746296352 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 22 Jan 2024 06:19:50 +0100 Subject: [PATCH 25/28] Revert "Disable Regression2_Regressions.csproj too" This reverts commit 4a6bdb841eafab84acd1e0e0ae5423acc893651c. --- src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj b/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj index d8d7f7f5bcd8ea..6818e8aec539f6 100644 --- a/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj +++ b/src/tests/JIT/opt/Regressions/Regression2_Regressions.csproj @@ -6,9 +6,6 @@ true true - - - true None From 5967c84bc9e2fd590e1d5a56de0008cc0537c7f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 22 Jan 2024 06:19:58 +0100 Subject: [PATCH 26/28] Revert "Disable AmbiguousImplementationException.ilproj and Pause_ro.csproj too" This reverts commit f5729ce8fde51ebce389f3e2d505119cdfda7096. --- .../JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj | 6 +----- .../AmbiguousImplementationException.ilproj | 3 --- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj b/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj index 3876174ce18510..0594f730cc5cb4 100644 --- a/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj +++ b/src/tests/JIT/HardwareIntrinsics/X86/X86Base/Pause_ro.csproj @@ -5,11 +5,7 @@ true - true - - - true - + true Embedded True diff --git a/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj b/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj index bc77733010e15a..700e63400f8737 100644 --- a/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj +++ b/src/tests/Loader/classloader/StaticVirtualMethods/NegativeTestCases/AmbiguousImplementationException.ilproj @@ -2,9 +2,6 @@ true - - - true Full From 8f2d412695a4cdf9f1dd6b469c26bb3038926c1c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 22 Jan 2024 06:20:07 +0100 Subject: [PATCH 27/28] Revert "Disable DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled test" This reverts commit 2267a5ccdf1d2c9cddd81d2175bc403b643fe89d. --- ...ledRuntimeMarshalling_Disabled_NativeAssemblyEnabled.csproj | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/tests/Interop/DisabledRuntimeMarshalling/DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled.csproj b/src/tests/Interop/DisabledRuntimeMarshalling/DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled.csproj index 85a791483440f4..7e67cdcfc9610b 100644 --- a/src/tests/Interop/DisabledRuntimeMarshalling/DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled.csproj +++ b/src/tests/Interop/DisabledRuntimeMarshalling/DisabledRuntimeMarshalling_Disabled_NativeAssemblyEnabled.csproj @@ -3,9 +3,6 @@ true true true - - - true From 36533db58c94bcf9ff632ebed7eda3d38645e5d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Strehovsk=C3=BD?= Date: Mon, 22 Jan 2024 06:44:19 +0100 Subject: [PATCH 28/28] Work around IsPrimitive compilation issue --- .../System.Private.CoreLib/src/System/Type.cs | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/libraries/System.Private.CoreLib/src/System/Type.cs b/src/libraries/System.Private.CoreLib/src/System/Type.cs index 1d798a494047e5..17e4636296c177 100644 --- a/src/libraries/System.Private.CoreLib/src/System/Type.cs +++ b/src/libraries/System.Private.CoreLib/src/System/Type.cs @@ -125,7 +125,15 @@ public virtual Type[] GetGenericParameterConstraints() public virtual bool IsEnum { [Intrinsic] get => IsSubclassOf(typeof(Enum)); } public bool IsMarshalByRef => IsMarshalByRefImpl(); protected virtual bool IsMarshalByRefImpl() => false; - public bool IsPrimitive { [Intrinsic] get => IsPrimitiveImpl(); } + public bool IsPrimitive + { +#if NATIVEAOT + // https://github.com/dotnet/runtime/issues/97272 + [MethodImpl(MethodImplOptions.NoOptimization)] +#endif + [Intrinsic] + get => IsPrimitiveImpl(); + } protected abstract bool IsPrimitiveImpl(); public bool IsValueType { [Intrinsic] get => IsValueTypeImpl(); } protected virtual bool IsValueTypeImpl() => IsSubclassOf(typeof(ValueType));