Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add telemetry for invalid global.json when running a command #50058

@elinor-fung

Description

@elinor-fung

We've gotten feedback over the years about how invalid global.json files (either invalid JSON or invalid data in the JSON) shouldn't just be silently ignored by the host (#49816, dotnet/runtime#96299). However, due to the potentially broad impact of taking a breaking change to fix it, we'd like to get a sense of how common this situation is via telemetry from the SDK.

The SDK already sends telemetry for commands that get run. We could augment those events with some additional data when the global.json is invalid JSON or invalid data. I'm not sure how exactly we'd get that information over to the SDK yet - maybe some AppContext property that is only set when the global.json is invalid (so it shouldn't affect most usage).

@dotnet/dotnet-cli Does this sound reasonable? Concerns about adding something like this?

cc @dotnet/appmodel @AaronRobinsonMSFT @richlander

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions