Discovery indicator fixes #50903
Merged
Discovery indicator fixes #50903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Sep 18, 2025
Member
Youssef1313
left a comment
There was a problem hiding this comment.
Do we need anything for MTP as well?
Youssef1313
reviewed
Sep 18, 2025
| { | ||
| PassedTests++; | ||
| DiscoveredTests.Add(new(displayName, uid)); | ||
| DiscoveredTests++; |
Member
There was a problem hiding this comment.
Unrelated to your changes. But do we guarantee this is not called concurrently from multiple threads? This is not only for discovery, but for reporting test results as well.
Member
Author
|
yes I will move the changes to mtp once the are merged here. |
Member
|
From the screenshot, I see |
This was referenced Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change progress bar color to neutral color on discovery
Show red message when 0 tests are discovered. E.g. when we do
--list-tests --unknown-option, to align with exit code 1.Related to #45927
fix #50786