Fix dll detection in dotnet test #50926
Merged
+40
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Sep 20, 2025
| private static bool ContainsBuiltTestSources(string[] args) | ||
| { | ||
| foreach (string arg in args) | ||
| for (int i = 0; i < args.Length; i++) |
Member
There was a problem hiding this comment.
What if I run dotnet test --filter "Category=.dll"?
Is this going to incorrectly return true?
Member
Author
There was a problem hiding this comment.
most likely not, it needs better fix, but right now we need to unblock the merge in vstest.
Youssef1313
approved these changes
Sep 22, 2025
Member
Youssef1313
left a comment
There was a problem hiding this comment.
Approving to unblock insertion
Member
Author
|
/backport to main |
Contributor
|
Started backporting to main: https://github.com/dotnet/sdk/actions/runs/18521625644 |
This was referenced Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50923
Also blocks update of arcade in vstest.