From 73a6a91a00fb8256489358b1603cb49d43542f78 Mon Sep 17 00:00:00 2001 From: Viktor Hofer Date: Fri, 24 Mar 2023 11:31:38 +0100 Subject: [PATCH 1/2] Move Microsoft.Windows.Compatibility into windowsdesktop Now that System.Drawing.Common is part of winforms, the Microsoft.Windows.Compatibility meta package needs to be moved into a higher layer as runtime can't depend on winforms' product dependencies. Moving TargetFramework property into the respective project files to allow this repository to have multi-targeting projects. --- Build.proj | 4 + Directory.Build.props | 3 - eng/Version.Details.xml | 112 ++++++++++++++++++ eng/Versions.props | 52 +++++++- global.json | 2 +- .../Microsoft.Windows.Compatibility.csproj | 75 ++++++++++++ .../src/README.md | 9 ++ src/publish/prepare-artifacts.proj | 1 + src/windowsdesktop/src/Directory.Build.props | 1 + .../Microsoft.WindowsDesktop.App.Tests.csproj | 4 + 10 files changed, 255 insertions(+), 8 deletions(-) create mode 100644 src/Microsoft.Windows.Compatibility/src/Microsoft.Windows.Compatibility.csproj create mode 100644 src/Microsoft.Windows.Compatibility/src/README.md diff --git a/Build.proj b/Build.proj index 716eea59c..abdf5e5fa 100644 --- a/Build.proj +++ b/Build.proj @@ -1,9 +1,13 @@ + + + + \ No newline at end of file diff --git a/Directory.Build.props b/Directory.Build.props index dacdf8f2b..bd8d0890a 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -16,9 +16,6 @@ $(MSBuildThisFileDirectory)THIRD-PARTY-NOTICES.TXT https://go.microsoft.com/fwlink/?LinkID=799421 - - $(NetCurrent) - 4 true diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index 0e8dcfd8c..7f38c7b96 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -37,6 +37,118 @@ https://github.com/dotnet/wpf 08940fbba6aed7b0edafb00914691035cf71cc7d + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/runtime + 7500625bd9303a48d0500b6123cec604e49039ae + + + https://github.com/dotnet/winforms + f777662b7d00d81e52255e3c3b699f401eaaea6c + diff --git a/eng/Versions.props b/eng/Versions.props index f70500741..b54823ea2 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -1,4 +1,5 @@ + 8 0 @@ -9,25 +10,68 @@ false release - + 8.0.0-beta.23174.1 8.0.0-beta.23174.1 8.0.0-beta.23174.1 8.0.0-beta.23174.1 + + 4.5.0 + 4.8.5 + 4.7.0 + 4.7.0 + 4.7.0 + + 4.9.4 + 8.0.0-preview.4.23172.1 8.0.0-preview.4.23172.1 8.0.0-preview.4.23172.1 - 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 5.0.0 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 5.0.0 + 8.0.0-preview.4.23172.1 + 5.0.0 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 6.0.0 + 5.0.0 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 5.0.0 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 + 8.0.0-preview.4.23172.1 8.0.0-preview.4.23172.1 + + 4.10.0 8.0.0-preview.4.23172.4 8.0.0-preview.4.23172.4 + 8.0.0-preview.4.23172.4 8.0.0-preview.4.23177.1 8.0.0-preview.4.23177.1 - - 4.9.4 + diff --git a/global.json b/global.json index 69eff9072..2fba7fd63 100644 --- a/global.json +++ b/global.json @@ -6,6 +6,6 @@ "Microsoft.DotNet.Arcade.Sdk": "8.0.0-beta.23174.1", "Microsoft.DotNet.SharedFramework.Sdk": "8.0.0-beta.23174.1", "Microsoft.Build.NoTargets": "3.7.0", - "Microsoft.Build.Traversal": "3.3.0" + "Microsoft.Build.Traversal": "3.4.0" } } diff --git a/src/Microsoft.Windows.Compatibility/src/Microsoft.Windows.Compatibility.csproj b/src/Microsoft.Windows.Compatibility/src/Microsoft.Windows.Compatibility.csproj new file mode 100644 index 000000000..abd2bb60e --- /dev/null +++ b/src/Microsoft.Windows.Compatibility/src/Microsoft.Windows.Compatibility.csproj @@ -0,0 +1,75 @@ + + + + + $(NetCurrent);$(NetPrevious);$(NetMinimum);netstandard2.1;netstandard2.0 + + false + true + + $(NoWarn);NU5128 + true + This Windows Compatibility Pack provides access to APIs that were previously available only for .NET Framework. It can be used from both .NET as well as .NET Standard. + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/src/Microsoft.Windows.Compatibility/src/README.md b/src/Microsoft.Windows.Compatibility/src/README.md new file mode 100644 index 000000000..e3b8b81e2 --- /dev/null +++ b/src/Microsoft.Windows.Compatibility/src/README.md @@ -0,0 +1,9 @@ +# Microsoft.Windows.Compatibility package + +This Windows Compatibility Pack provides access to APIs that were previously available only for .NET Framework. It can be used from both .NET as well as .NET Standard. + +### How to add a new dependency +1. Add the package version to the repository's Versions.props file. +2. Add the package dependency to the repository's Version.Details.xml file. If the dependency doesn't come from a repository with a direct subscription to (i.e. winforms and runtime), add the `CoherentParentDependency` attribute to the dependency. +3. Add the package reference into the Microsoft.Windows.Compatibility.csproj file and use the version just defined in the Versions.props file. +4. If a `CoherentParentDependency` attribute was required, a dependency must be added to the repository dependency chain as well. I.e. to add a new dependency from runtime, a dependency must also be added in winforms and wpf's Version.Details.xml file. \ No newline at end of file diff --git a/src/publish/prepare-artifacts.proj b/src/publish/prepare-artifacts.proj index 6e897ae6d..9909cd1cf 100644 --- a/src/publish/prepare-artifacts.proj +++ b/src/publish/prepare-artifacts.proj @@ -1,6 +1,7 @@ + $(NetCurrent) false true diff --git a/src/windowsdesktop/src/Directory.Build.props b/src/windowsdesktop/src/Directory.Build.props index 7d32339cc..15836a620 100644 --- a/src/windowsdesktop/src/Directory.Build.props +++ b/src/windowsdesktop/src/Directory.Build.props @@ -3,6 +3,7 @@ + $(NetCurrent) Microsoft Windows Desktop + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/runtime 7500625bd9303a48d0500b6123cec604e49039ae - + https://github.com/dotnet/winforms f777662b7d00d81e52255e3c3b699f401eaaea6c