Fix Admin Client api version checking; only test ACL integration on 0.11+

dpkp · dpkp · commit 98ebff87a78b · 2019-09-28T17:06:57.000-07:00
diff --git a/kafka/admin/client.py b/kafka/admin/client.py
@@ -232,14 +232,20 @@ def _matching_api_version(self, operation):
         :param operation: A list of protocol operation versions from kafka.protocol.
         :return: The max matching version number between client and broker.
         """
-        version = min(len(operation) - 1,
-                      self._client.get_api_versions()[operation[0].API_KEY][1])
-        if version < self._client.get_api_versions()[operation[0].API_KEY][0]:
+        broker_api_versions = self._client.get_api_versions()
+        api_key = operation[0].API_KEY
+        if broker_api_versions is None or api_key not in broker_api_versions:
+            raise IncompatibleBrokerVersion(
+                "Kafka broker does not support the '{}' Kafka protocol."
+                .format(operation[0].__name__))
+        min_version, max_version = broker_api_versions[api_key]
+        version = min(len(operation) - 1, max_version)
+        if version < min_version:
             # max library version is less than min broker version. Currently,
             # no Kafka versions specify a min msg version. Maybe in the future?
             raise IncompatibleBrokerVersion(
                 "No version of the '{}' Kafka protocol is supported by both the client and broker."
-                .format(operation.__name__))
+                .format(operation[0].__name__))
         return version
 
     def _validate_timeout(self, timeout_ms):
diff --git a/test/test_admin_integration.py b/test/test_admin_integration.py
@@ -8,30 +8,33 @@
 from kafka.admin import KafkaAdminClient, ACLFilter, ACLOperation, ACLPermissionType, ResourcePattern, ResourceType, ACL
 
 
+# TODO: Convert to pytest / fixtures
+# Note that ACL features require broker 0.11, but other admin apis may work on
+# earlier broker versions
 class TestAdminClientIntegration(KafkaIntegrationTestCase):
     @classmethod
     def setUpClass(cls):  # noqa
-        if env_kafka_version() < (0, 10):
+        if env_kafka_version() < (0, 11):
             return
 
         cls.zk = ZookeeperFixture.instance()
         cls.server = KafkaFixture.instance(0, cls.zk)
 
     @classmethod
     def tearDownClass(cls):  # noqa
-        if env_kafka_version() < (0, 10):
+        if env_kafka_version() < (0, 11):
             return
 
         cls.server.close()
         cls.zk.close()
 
     def setUp(self):
-        if env_kafka_version() < (0, 10):
-            self.skipTest('Admin Integration test requires KAFKA_VERSION >= 0.10')
+        if env_kafka_version() < (0, 11):
+            self.skipTest('Admin ACL Integration test requires KAFKA_VERSION >= 0.11')
         super(TestAdminClientIntegration, self).setUp()
 
     def tearDown(self):
-        if env_kafka_version() < (0, 10):
+        if env_kafka_version() < (0, 11):
             return
         super(TestAdminClientIntegration, self).tearDown()
 
