Improve safety/robustness of config:pull so that it halts if the export did not report a destination path. (#4099)

weitzman · web-flow · commit 2737f70c10e8 · 2019-06-21T07:08:48.000-04:00
diff --git a/src/Commands/config/ConfigPullCommands.php b/src/Commands/config/ConfigPullCommands.php
@@ -51,8 +51,15 @@ public function pull($source, $destination, $options = ['safe' => false, 'label'
         $this->logger()->notice(dt('Starting to export configuration on :destination.', [':destination' => $destination]));
         $process = $this->processManager()->drush($sourceRecord, 'config-export', [], $export_options + $global_options);
         $process->mustRun();
-        // Trailing slash assures that we transfer files and not the containing dir.
-        $export_path = $this->getConfig()->simulate() ? '/simulated/path' : trim($process->getOutput()) . '/';
+
+        if ($this->getConfig()->simulate()) {
+            $export_path = '/simulated/path';
+        } elseif (empty(trim($process->getOutput()))) {
+            throw new \Exception(dt('The Drush config:export command did not report the path to the export directory.'));
+        } else {
+            // Trailing slash ensures that we transfer files and not the containing dir.
+            $export_path = trim($process->getOutput()) . '/';
+        }
 
         if (strpos($destination, ':') === false) {
             $destination .= ':%config-' . $options['label'];
