Merge branch 'Chi-teck-sql-dump-message'

weitzman · weitzman · commit cf62a51ee939 · 2019-04-03T06:51:31.000-04:00
diff --git a/src/Commands/sql/SqlCommands.php b/src/Commands/sql/SqlCommands.php
@@ -236,7 +236,10 @@ public function dump($options = ['result-file' => self::REQ, 'create-db' => fals
             throw new \Exception('Unable to dump database. Rerun with --debug to see any error message.');
         }
 
-        $this->logger()->success(dt('Database dump saved to !path', ['!path' => $return]));
+        // SqlBase::dump() returns null if 'result-file' option is empty.
+        if ($return) {
+            $this->logger()->success(dt('Database dump saved to !path', ['!path' => $return]));
+        }
         return new PropertyList(['path' => $return]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -236,7 +236,10 @@ public function dump($options = ['result-file' => self::REQ, 'create-db' => fals`
`236`	`236`	`throw new \Exception('Unable to dump database. Rerun with --debug to see any error message.');`
`237`	`237`	`}`
`238`	`238`
`239`		`- $this->logger()->success(dt('Database dump saved to !path', ['!path' => $return]));`
	`239`	`+ // SqlBase::dump() returns null if 'result-file' option is empty.`
	`240`	`+ if ($return) {`
	`241`	`+ $this->logger()->success(dt('Database dump saved to !path', ['!path' => $return]));`
	`242`	`+ }`
`240`	`243`	`return new PropertyList(['path' => $return]);`
`241`	`244`	`}`
`242`	`245`