PORT showStartPage setting fix (microsoft#13706) (microsoft#13758)

David Kutugata · web-flow · commit a664e3f0161a · 2020-09-02T13:16:51.000-07:00
* fix showStartPage setting on configSettings.ts (microsoft#13706) * fix showStartPage setting on configSettings.ts * add news file * Fix unit tests * oops * update changelog
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@
 
 1. Fixed connection to a Compute Instance from the quickpicks history options.
    ([#13387](https://github.com/Microsoft/vscode-python/issues/13387))
+1. Fixed the behavior of the 'python.showStartPage' setting.
+   ([#13347](https://github.com/microsoft/vscode-python/issues/13347))
 
 ### Thanks
 
diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts
@@ -544,6 +544,11 @@ export class PythonSettings implements IPythonSettings {
             this.datascience = dataScienceSettings;
         }
 
+        const showStartPage = pythonSettings.get<boolean>('showStartPage');
+        if (showStartPage !== undefined) {
+            this.showStartPage = showStartPage;
+        }
+
         this.insidersChannel = pythonSettings.get<ExtensionChannels>('insidersChannel')!;
     }
 
diff --git a/src/test/common/configSettings/configSettings.unit.test.ts b/src/test/common/configSettings/configSettings.unit.test.ts
@@ -47,7 +47,7 @@ suite('Python Settings', async () => {
     let settings: CustomPythonSettings;
     setup(() => {
         sinon.stub(EnvFileTelemetry, 'sendSettingTelemetry').returns();
-        config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Strict);
+        config = TypeMoq.Mock.ofType<WorkspaceConfiguration>(undefined, TypeMoq.MockBehavior.Loose);
         expected = new CustomPythonSettings(undefined, new MockAutoSelectionService());
         settings = new CustomPythonSettings(undefined, new MockAutoSelectionService());
         expected.defaultInterpreterPath = 'python';

Original file line number	Diff line number	Diff line change
`@@ -544,6 +544,11 @@ export class PythonSettings implements IPythonSettings {`
`544`	`544`	`this.datascience = dataScienceSettings;`
`545`	`545`	`}`
`546`	`546`
	`547`	`+ const showStartPage = pythonSettings.get<boolean>('showStartPage');`
	`548`	`+ if (showStartPage !== undefined) {`
	`549`	`+ this.showStartPage = showStartPage;`
	`550`	`+ }`
	`551`	`+`
`547`	`552`	`this.insidersChannel = pythonSettings.get<ExtensionChannels>('insidersChannel')!;`
`548`	`553`	`}`
`549`	`554`