bug symfony#49292 [VarDumper] Fix error when reflected class has default Enum parameter in constructor (kapiwko)

nicolas-grekas · nicolas-grekas · commit 2a633cf5ffc4 · 2023-02-23T11:00:35.000+01:00
This PR was submitted for the 6.3 branch but it was squashed and merged into the 5.4 branch instead. Discussion ---------- [VarDumper] Fix error when reflected class has default Enum parameter in constructor | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT | Doc PR | no Have classes: ``` enum GeometryType: string { case Geometry = 'GEOMETRY'; } ``` ``` final class Geometry { public function __construct(GeometryType $type = GeometryType::Geometry) { } } ``` Try to dump reflection of class Geometry: ``` $reflection = new \ReflectionClass(Geometry::class); dump($reflection); ``` Have error: `Symfony\Component\VarDumper\Caster\ConstStub::__construct(): Argument #2 ($value) must be of type string|int|float|null, App\Infrastructure\Geometry\GeometryType given, called in [...]/vendor/symfony/var-dumper/Caster/ReflectionCaster.php on line 296` Commits ------- d6a7730 [VarDumper] Fix error when reflected class has default Enum parameter in constructor
diff --git a/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php b/src/Symfony/Component/VarDumper/Caster/ReflectionCaster.php
@@ -292,7 +292,7 @@ public static function castParameter(\ReflectionParameter $c, array $a, Stub $st
         if ($c->isOptional()) {
             try {
                 $a[$prefix.'default'] = $v = $c->getDefaultValue();
-                if ($c->isDefaultValueConstant()) {
+                if ($c->isDefaultValueConstant() && !\is_object($v)) {
                     $a[$prefix.'default'] = new ConstStub($c->getDefaultValueConstantName(), $v);
                 }
                 if (null === $v) {

Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ public static function castParameter(\ReflectionParameter $c, array $a, Stub $st`
`292`	`292`	`if ($c->isOptional()) {`
`293`	`293`	`try {`
`294`	`294`	`$a[$prefix.'default'] = $v = $c->getDefaultValue();`
`295`		`- if ($c->isDefaultValueConstant()) {`
	`295`	`+ if ($c->isDefaultValueConstant() && !\is_object($v)) {`
`296`	`296`	`$a[$prefix.'default'] = new ConstStub($c->getDefaultValueConstantName(), $v);`
`297`	`297`	`}`
`298`	`298`	`if (null === $v) {`