bug symfony#46608 [Console] Fix deprecation when description is null (HypeMC)

fabpot · fabpot · commit 2cbbec41cf0d · 2022-06-07T07:54:00.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Console] Fix deprecation when description is null | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Fixes `str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated` when `getDefaultDescription()` returns `null`, caused by symfony#46574. Commits ------- 7a08b52 [Console] Fix deprecation when description is null
diff --git a/src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php b/src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php
@@ -124,7 +124,7 @@ public function process(ContainerBuilder $container)
                 if (!$r->isSubclassOf(Command::class)) {
                     throw new InvalidArgumentException(sprintf('The service "%s" tagged "%s" must be a subclass of "%s".', $id, $this->commandTag, Command::class));
                 }
-                $description = str_replace('%', '%%', $class::getDefaultDescription());
+                $description = str_replace('%', '%%', $class::getDefaultDescription() ?? '');
             }
 
             if ($description) {

Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,7 @@ public function process(ContainerBuilder $container)`
`124`	`124`	`if (!$r->isSubclassOf(Command::class)) {`
`125`	`125`	`throw new InvalidArgumentException(sprintf('The service "%s" tagged "%s" must be a subclass of "%s".', $id, $this->commandTag, Command::class));`
`126`	`126`	`}`
`127`		`- $description = str_replace('%', '%%', $class::getDefaultDescription());`
	`127`	`+ $description = str_replace('%', '%%', $class::getDefaultDescription() ?? '');`
`128`	`128`	`}`
`129`	`129`
`130`	`130`	`if ($description) {`