fix(datadog): use http.target not http.path (open-telemetry#810)

majorgreys · web-flow · commit e35d84f9ae50 · 2020-06-16T20:55:23.000-07:00
diff --git a/ext/opentelemetry-ext-datadog/src/opentelemetry/ext/datadog/exporter.py b/ext/opentelemetry-ext-datadog/src/opentelemetry/ext/datadog/exporter.py
@@ -191,9 +191,7 @@ def _get_span_name(span):
 def _get_resource(span):
     """Get resource name for span"""
     if "http.method" in span.attributes:
-        route = span.attributes.get(
-            "http.route", span.attributes.get("http.path")
-        )
+        route = span.attributes.get("http.route")
         return (
             span.attributes["http.method"] + " " + route
             if route
diff --git a/ext/opentelemetry-ext-datadog/tests/test_datadog_exporter.py b/ext/opentelemetry-ext-datadog/tests/test_datadog_exporter.py
@@ -222,8 +222,8 @@ def test_export(self):
     def test_resources(self):
         test_attributes = [
             {},
-            {"http.method": "GET", "http.route": "/foo"},
-            {"http.method": "GET", "http.path": "/foo"},
+            {"http.method": "GET", "http.route": "/foo/<int:id>"},
+            {"http.method": "GET", "http.target": "/foo/200"},
         ]
 
         for index, test in enumerate(test_attributes):
@@ -235,7 +235,7 @@ def test_resources(self):
         self.assertEqual(len(datadog_spans), 3)
 
         actual = [span["resource"] for span in datadog_spans]
-        expected = ["0", "GET /foo", "GET /foo"]
+        expected = ["0", "GET /foo/<int:id>", "GET"]
 
         self.assertEqual(actual, expected)
 
