VertxHttpHeaders#add(CharSequence,CharSequence) does not used AsciiString cached hashcode value - fixes #2446

vietj · vietj · commit e1f6fedf8f7f · 2018-09-19T10:35:43.000+02:00
diff --git a/src/main/java/io/vertx/core/http/impl/headers/VertxHttpHeaders.java b/src/main/java/io/vertx/core/http/impl/headers/VertxHttpHeaders.java
@@ -78,13 +78,18 @@ public boolean contentTypeSet() {
   }
 
   @Override
-  public VertxHttpHeaders add(CharSequence name, Object value) {
+  public VertxHttpHeaders add(CharSequence name, CharSequence value) {
     int h = AsciiString.hashCode(name);
     int i = index(h);
-    add0(h, i, name, (CharSequence) value);
+    add0(h, i, name, value);
     return this;
   }
 
+  @Override
+  public VertxHttpHeaders add(CharSequence name, Object value) {
+    return add(name, (CharSequence)value);
+  }
+
   @Override
   public VertxHttpHeaders add(final String name, final String strVal) {
     int h = AsciiString.hashCode(name);
@@ -373,11 +378,6 @@ public boolean contains(CharSequence name) {
     return get0(name) != null;
   }
 
-  @Override
-  public VertxHttpHeaders add(CharSequence name, CharSequence value) {
-    return add(name.toString(), value.toString());
-  }
-
   @Override
   public VertxHttpHeaders add(CharSequence name, Iterable values) {
     String n = name.toString();
