Include labels with value >= 0

destiny-wu · destiny-wu · commit 3e58fc271f0a · 2021-12-08T17:24:20.000-05:00
diff --git a/draftlogs/6051_fix.md b/draftlogs/6051_fix.md
@@ -0,0 +1 @@
+- Discard negative values from pie chart post-aggregation instead of during summation [[#6051](https://github.com/plotly/plotly.js/pull/6051)]
diff --git a/src/traces/pie/calc.js b/src/traces/pie/calc.js
@@ -76,7 +76,7 @@ function calc(gd, trace) {
     }
 
     // Drop aggregate sums of value 0 or less
-    cd = cd.filter(function(elem) { return elem.v > 0; });
+    cd = cd.filter(function(elem) { return elem.v >= 0; });
 
     var shouldSort = (trace.type === 'funnelarea') ? isAggregated : trace.sort;
     if(shouldSort) cd.sort(function(a, b) { return b.v - a.v; });
diff --git a/test/image/baselines/pie_negative_values.png b/test/image/baselines/pie_negative_values.png
diff --git a/test/image/mocks/pie_negative_values.json b/test/image/mocks/pie_negative_values.json
@@ -38,5 +38,4 @@
       "height": 300,
       "width": 500
     }
-  }
-  
+}

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+- Discard negative values from pie chart post-aggregation instead of during summation [[#6051](https://github.com/plotly/plotly.js/pull/6051)]`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ function calc(gd, trace) {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`// Drop aggregate sums of value 0 or less`
`79`		`- cd = cd.filter(function(elem) { return elem.v > 0; });`
	`79`	`+ cd = cd.filter(function(elem) { return elem.v >= 0; });`
`80`	`80`
`81`	`81`	`var shouldSort = (trace.type === 'funnelarea') ? isAggregated : trace.sort;`
`82`	`82`	`if(shouldSort) cd.sort(function(a, b) { return b.v - a.v; });`