Improve error report for invalid action.yml (actions#3106)

jsoref · web-flow · commit fa874cf3147f · 2024-02-06T13:40:53.000Z
diff --git a/src/Runner.Worker/ActionManifestManager.cs b/src/Runner.Worker/ActionManifestManager.cs
@@ -144,7 +144,7 @@ public ActionDefinitionData Load(IExecutionContext executionContext, string mani
                     executionContext.Error(error.Message);
                 }
 
-                throw new ArgumentException($"Fail to load {fileRelativePath}");
+                throw new ArgumentException($"Failed to load {fileRelativePath}");
             }
 
             if (actionDefinition.Execution == null)
diff --git a/src/Test/L0/Worker/ActionManifestManagerL0.cs b/src/Test/L0/Worker/ActionManifestManagerL0.cs
@@ -757,7 +757,7 @@ public void Load_CompositeActionNoUsing()
 
                 //Assert
                 var err = Assert.Throws<ArgumentException>(() => actionManifest.Load(_ec.Object, action_path));
-                Assert.Contains($"Fail to load {action_path}", err.Message);
+                Assert.Contains($"Failed to load {action_path}", err.Message);
                 _ec.Verify(x => x.AddIssue(It.Is<Issue>(s => s.Message.Contains("Missing 'using' value. 'using' requires 'composite', 'docker', 'node12', 'node16' or 'node20'.")), It.IsAny<ExecutionContextLogOptions>()), Times.Once);
             }
             finally

Original file line number	Diff line number	Diff line change
`@@ -144,7 +144,7 @@ public ActionDefinitionData Load(IExecutionContext executionContext, string mani`
`144`	`144`	`executionContext.Error(error.Message);`
`145`	`145`	`}`
`146`	`146`
`147`		`- throw new ArgumentException($"Fail to load {fileRelativePath}");`
	`147`	`+ throw new ArgumentException($"Failed to load {fileRelativePath}");`
`148`	`148`	`}`
`149`	`149`
`150`	`150`	`if (actionDefinition.Execution == null)`
Original file line number	Diff line number	Diff line change
`@@ -757,7 +757,7 @@ public void Load_CompositeActionNoUsing()`
`757`	`757`
`758`	`758`	`//Assert`
`759`	`759`	`var err = Assert.Throws<ArgumentException>(() => actionManifest.Load(_ec.Object, action_path));`
`760`		`- Assert.Contains($"Fail to load {action_path}", err.Message);`
	`760`	`+ Assert.Contains($"Failed to load {action_path}", err.Message);`
`761`	`761`	`_ec.Verify(x => x.AddIssue(It.Is<Issue>(s => s.Message.Contains("Missing 'using' value. 'using' requires 'composite', 'docker', 'node12', 'node16' or 'node20'.")), It.IsAny<ExecutionContextLogOptions>()), Times.Once);`
`762`	`762`	`}`
`763`	`763`	`finally`