lint in scattergl.plot

etpinard · etpinard · commit 4aca3157a5bd · 2018-10-31T15:32:50.000-04:00
diff --git a/src/traces/scattergl/index.js b/src/traces/scattergl/index.js
@@ -395,15 +395,16 @@ function plot(gd, subplot, cdata) {
             scene.line2d.update(scene.lineOptions);
             scene.lineOptions = scene.lineOptions.map(function(lineOptions) {
                 if(lineOptions && lineOptions.positions) {
-                    var pos = [], srcPos = lineOptions.positions;
+                    var pos = [];
+                    var srcPos = lineOptions.positions;
 
                     var firstptdef = 0;
                     while(isNaN(srcPos[firstptdef]) || isNaN(srcPos[firstptdef + 1])) {
                         firstptdef += 2;
                     }
                     var lastptdef = srcPos.length - 2;
                     while(isNaN(srcPos[lastptdef]) || isNaN(srcPos[lastptdef + 1])) {
-                        lastptdef += -2;
+                        lastptdef -= 2;
                     }
                     pos = pos.concat(srcPos.slice(firstptdef, lastptdef + 2));
                     lineOptions.positions = pos;
@@ -437,36 +438,38 @@ function plot(gd, subplot, cdata) {
                 if(trace._nexttrace) fillData.push(i + 1);
                 if(fillData.length) scene.fillOrder[i] = fillData;
 
-                var pos = [], srcPos = (lineOptions && lineOptions.positions) || stash.positions;
+                var pos = [];
+                var srcPos = (lineOptions && lineOptions.positions) || stash.positions;
+                var firstptdef, lastptdef;
 
                 if(trace.fill === 'tozeroy') {
-                    var firstpdef = 0;
                     while(isNaN(srcPos[firstpdef + 1])) {
-                        firstpdef += 2;
+                    firstptdef = 0;
+                        firstptdef += 2;
                     }
-                    var lastpdef = srcPos.length - 2;
                     while(isNaN(srcPos[lastpdef + 1])) {
-                        lastpdef += -2;
+                    lastptdef = srcPos.length - 2;
+                        lastptdef -= 2;
                     }
-                    if(srcPos[firstpdef + 1] !== 0) {
-                        pos = [ srcPos[firstpdef], 0 ];
+                    if(srcPos[firstptdef + 1] !== 0) {
+                        pos = [srcPos[firstptdef], 0];
                     }
-                    pos = pos.concat(srcPos.slice(firstpdef, lastpdef + 2));
-                    if(srcPos[lastpdef + 1] !== 0) {
-                        pos = pos.concat([ srcPos[lastpdef], 0 ]);
+                    pos = pos.concat(srcPos.slice(firstptdef, lastptdef + 2));
+                    if(srcPos[lastptdef + 1] !== 0) {
+                        pos = pos.concat([srcPos[lastptdef], 0]);
                     }
                 }
                 else if(trace.fill === 'tozerox') {
-                    var firstptdef = 0;
                     while(isNaN(srcPos[firstptdef])) {
+                    firstptdef = 0;
                         firstptdef += 2;
                     }
-                    var lastptdef = srcPos.length - 2;
                     while(isNaN(srcPos[lastptdef])) {
-                        lastptdef += -2;
+                    lastptdef = srcPos.length - 2;
+                        lastptdef -= 2;
                     }
                     if(srcPos[firstptdef] !== 0) {
-                        pos = [ 0, srcPos[firstptdef + 1] ];
+                        pos = [0, srcPos[firstptdef + 1]];
                     }
                     pos = pos.concat(srcPos.slice(firstptdef, lastptdef + 2));
                     if(srcPos[lastptdef] !== 0) {
