remove apply arg from _storeDirectGUIEdit

alexcjohnson · alexcjohnson · commit 86b90d4e00ca · 2018-11-10T08:39:12.000-05:00
diff --git a/src/plot_api/plot_api.js b/src/plot_api/plot_api.js
@@ -1438,22 +1438,21 @@ function storeCurrent(attr, val, newVal, preGUI) {
     }
 }
 
-/*
+/**
  * storeDirectGUIEdit: for routines that skip restyle/relayout and mock it
  * by emitting a plotly_restyle or plotly_relayout event, this routine
- * applies the changes to the input objects and keeps track of the initial state
- * in _preGUI for use by uirevision
+ * keeps track of the initial state in _preGUI for use by uirevision
+ * Does *not* apply these changes to data/layout - that's the responsibility
+ * of the calling routine.
  *
  * @param {object} container: the input attributes container (eg `layout` or a `trace`)
  * @param {object} fullContainer: the full partner to `container`
  * @param {object} edits: the {attr: val} object as normally passed to `relayout` etc
- * @param {boolean} apply: should we apply these changes to the input object?
  */
-exports._storeDirectGUIEdit = function(container, preGUI, edits, apply) {
+exports._storeDirectGUIEdit = function(container, preGUI, edits) {
     for(var attr in edits) {
         var np = nestedProperty(container, attr);
         storeCurrent(attr, np.get(), edits[attr], preGUI);
-        if(apply) np.set(edits[attr]);
     }
 };
 
diff --git a/src/plots/gl2d/scene2d.js b/src/plots/gl2d/scene2d.js
@@ -316,15 +316,25 @@ proto.relayoutCallback = function() {
     var graphDiv = this.graphDiv;
     var xaxis = this.xaxis;
     var yaxis = this.yaxis;
+    var layout = graphDiv.layout;
 
     // make a meaningful value to be passed on to possible 'plotly_relayout' subscriber(s)
     var update = {};
-    update[xaxis._name + '.range'] = xaxis.range.slice();
-    update[yaxis._name + '.range'] = yaxis.range.slice();
+    var xrange = update[xaxis._name + '.range'] = xaxis.range.slice();
+    var yrange = update[yaxis._name + '.range'] = yaxis.range.slice();
     update[xaxis._name + '.autorange'] = xaxis.autorange;
     update[yaxis._name + '.autorange'] = yaxis.autorange;
 
-    Registry.call('_storeDirectGUIEdit', graphDiv.layout, graphDiv._fullLayout._preGUI, update, true);
+    Registry.call('_storeDirectGUIEdit', graphDiv.layout, graphDiv._fullLayout._preGUI, update);
+
+    // update the input layout
+    var xaIn = layout[xaxis._name];
+    xaIn.range = xrange;
+    xaIn.autorange = xaxis.autorange;
+
+    var yaIn = layout[yaxis._name];
+    yaIn.range = yrange;
+    yaIn.autorange = yaxis.autorange;
 
     // lastInputTime helps determine which one is the latest input (if async)
     update.lastInputTime = this.camera.lastInputTime;
