fix: do not proxify class instances in forge config (#3039)

MarshallOfSound · web-flow · commit a89ed7d375dd · 2022-10-31T18:02:05.000-07:00
* fix: do not proxify class instances in forge config

* spec: fix config tests
diff --git a/packages/api/core/src/util/forge-config.ts b/packages/api/core/src/util/forge-config.ts
@@ -28,7 +28,7 @@ const proxify = <T extends ProxiedObject>(buildIdentifier: string | (() => strin
   }
 
   for (const [key, val] of Object.entries(proxifiedObject)) {
-    if (typeof val === 'object' && key !== 'pluginInterface' && !(val instanceof RegExp)) {
+    if (typeof val === 'object' && (val.constructor === Object || val.constructor === Array) && key !== 'pluginInterface' && !(val instanceof RegExp)) {
       (newObject as any)[key] = proxify(buildIdentifier, (proxifiedObject as any)[key], `${envPrefix}_${underscoreCase(key)}`);
     } else {
       (newObject as any)[key] = (proxifiedObject as any)[key];

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ const proxify = <T extends ProxiedObject>(buildIdentifier: string \| (() => strin`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`for (const [key, val] of Object.entries(proxifiedObject)) {`
`31`		`- if (typeof val === 'object' && key !== 'pluginInterface' && !(val instanceof RegExp)) {`
	`31`	`+ if (typeof val === 'object' && (val.constructor === Object \|\| val.constructor === Array) && key !== 'pluginInterface' && !(val instanceof RegExp)) {`
`32`	`32`	(newObject as any)[key] = proxify(buildIdentifier, (proxifiedObject as any)[key], `${envPrefix}_${underscoreCase(key)}`);
`33`	`33`	`} else {`
`34`	`34`	`(newObject as any)[key] = (proxifiedObject as any)[key];`