feat!: bump engines to Node.js >=22.12.0#139
Conversation
BREAKING CHANGE: Requires Node.js v22.12.0 LTS or higher. ESM-only.
| }; | ||
|
|
||
| export const verifyFileTree = async (dirPath: string) => { | ||
| const { expect } = await import('vitest'); |
There was a problem hiding this comment.
Why is the dynamic import required here? 🤔
There was a problem hiding this comment.
TBH, I don't remember the exact error, but this test util gets imported during a part of the test lifecycle where Vitest was complaining about being imported, so I shifted it to where it was actually needed.
| return Buffer.concat(chunks); | ||
| }; | ||
|
|
||
| export const fsMove = async (oldPath: string, newPath: string) => { |
There was a problem hiding this comment.
Needing to port code like this makes me wonder if fs-extra is worth keeping around just for the extra utility since we're still using graceful-fs for the most part 🫨
There was a problem hiding this comment.
It's definitely a bit annoying, but I think it's still worth it to drop fs-extra, personally, since that's like 4 dependencies.
Co-authored-by: Erick Zhao <[email protected]>
This reverts commit 56ff860.
| uses: azure/cli@089eac9d8cc39f5d003e94f8b65efc51076c9cbd # v2.1.0 | ||
| with: | ||
| inlineScript: | | ||
| az storage blob upload-batch --account-name ${{ secrets.AZURE_ECOSYSTEM_PACKAGES_STORAGE_ACCOUNT_NAME }} -d '$web/${{ github.event.repository.name }}/${{ github.ref_name }}' -s ./docs --overwrite --auth-mode login |
There was a problem hiding this comment.
TIL about github.event.repository.name lol i've been hard-coding this variable for all my other repos
There was a problem hiding this comment.
Yea, to be fair I haven't tested it, but it should work. 😅 Was just making this workflow fully generic so we don't get copy-paste issues as we roll it out to more repos.
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
BREAKING CHANGE: Requires Node.js v22.12.0 LTS or higher. ESM-only.