|
| 1 | +package main |
| 2 | + |
| 3 | +import ( |
| 4 | + "fmt" |
| 5 | + "io/ioutil" |
| 6 | + "os" |
| 7 | + "path/filepath" |
| 8 | + "testing" |
| 9 | +) |
| 10 | + |
| 11 | +const ( |
| 12 | + cpTestPathParent = "/some" |
| 13 | + cpTestPath = "/some/path" |
| 14 | + cpTestName = "test" |
| 15 | + cpFullPath = "/some/path/test" |
| 16 | + |
| 17 | + cpContainerContents = "holla, i am the container" |
| 18 | + cpHostContents = "hello, i am the host" |
| 19 | +) |
| 20 | + |
| 21 | +// Test for #5656 |
| 22 | +// Check that garbage paths don't escape the container's rootfs |
| 23 | +func TestCpGarbagePath(t *testing.T) { |
| 24 | + out, exitCode, err := cmd(t, "run", "-d", "busybox", "/bin/sh", "-c", "mkdir -p '"+cpTestPath+"' && echo -n '"+cpContainerContents+"' > "+cpFullPath) |
| 25 | + if err != nil || exitCode != 0 { |
| 26 | + t.Fatal("failed to create a container", out, err) |
| 27 | + } |
| 28 | + |
| 29 | + cleanedContainerID := stripTrailingCharacters(out) |
| 30 | + defer deleteContainer(cleanedContainerID) |
| 31 | + |
| 32 | + out, _, err = cmd(t, "wait", cleanedContainerID) |
| 33 | + if err != nil || stripTrailingCharacters(out) != "0" { |
| 34 | + t.Fatal("failed to set up container", out, err) |
| 35 | + } |
| 36 | + |
| 37 | + if err := os.MkdirAll(cpTestPath, os.ModeDir); err != nil { |
| 38 | + t.Fatal(err) |
| 39 | + } |
| 40 | + |
| 41 | + hostFile, err := os.Create(cpFullPath) |
| 42 | + if err != nil { |
| 43 | + t.Fatal(err) |
| 44 | + } |
| 45 | + defer hostFile.Close() |
| 46 | + defer os.RemoveAll(cpTestPathParent) |
| 47 | + |
| 48 | + fmt.Fprintf(hostFile, "%s", cpHostContents) |
| 49 | + |
| 50 | + tmpdir, err := ioutil.TempDir("", "docker-integration") |
| 51 | + if err != nil { |
| 52 | + t.Fatal(err) |
| 53 | + } |
| 54 | + |
| 55 | + tmpname := filepath.Join(tmpdir, cpTestName) |
| 56 | + defer os.RemoveAll(tmpdir) |
| 57 | + |
| 58 | + path := filepath.Join("../../../../../../../../../../../../", cpFullPath) |
| 59 | + |
| 60 | + _, _, err = cmd(t, "cp", cleanedContainerID+":"+path, tmpdir) |
| 61 | + if err != nil { |
| 62 | + t.Fatalf("couldn't copy from garbage path: %s:%s %s", cleanedContainerID, path, err) |
| 63 | + } |
| 64 | + |
| 65 | + file, _ := os.Open(tmpname) |
| 66 | + defer file.Close() |
| 67 | + |
| 68 | + test, err := ioutil.ReadAll(file) |
| 69 | + if err != nil { |
| 70 | + t.Fatal(err) |
| 71 | + } |
| 72 | + |
| 73 | + if string(test) == cpHostContents { |
| 74 | + t.Errorf("output matched host file -- garbage path can escape container rootfs") |
| 75 | + } |
| 76 | + |
| 77 | + if string(test) != cpContainerContents { |
| 78 | + t.Errorf("output doesn't match the input for garbage path") |
| 79 | + } |
| 80 | + |
| 81 | + logDone("cp - garbage paths relative to container's rootfs") |
| 82 | +} |
| 83 | + |
| 84 | +// Check that relative paths are relative to the container's rootfs |
| 85 | +func TestCpRelativePath(t *testing.T) { |
| 86 | + out, exitCode, err := cmd(t, "run", "-d", "busybox", "/bin/sh", "-c", "mkdir -p '"+cpTestPath+"' && echo -n '"+cpContainerContents+"' > "+cpFullPath) |
| 87 | + if err != nil || exitCode != 0 { |
| 88 | + t.Fatal("failed to create a container", out, err) |
| 89 | + } |
| 90 | + |
| 91 | + cleanedContainerID := stripTrailingCharacters(out) |
| 92 | + defer deleteContainer(cleanedContainerID) |
| 93 | + |
| 94 | + out, _, err = cmd(t, "wait", cleanedContainerID) |
| 95 | + if err != nil || stripTrailingCharacters(out) != "0" { |
| 96 | + t.Fatal("failed to set up container", out, err) |
| 97 | + } |
| 98 | + |
| 99 | + if err := os.MkdirAll(cpTestPath, os.ModeDir); err != nil { |
| 100 | + t.Fatal(err) |
| 101 | + } |
| 102 | + |
| 103 | + hostFile, err := os.Create(cpFullPath) |
| 104 | + if err != nil { |
| 105 | + t.Fatal(err) |
| 106 | + } |
| 107 | + defer hostFile.Close() |
| 108 | + defer os.RemoveAll(cpTestPathParent) |
| 109 | + |
| 110 | + fmt.Fprintf(hostFile, "%s", cpHostContents) |
| 111 | + |
| 112 | + tmpdir, err := ioutil.TempDir("", "docker-integration") |
| 113 | + |
| 114 | + if err != nil { |
| 115 | + t.Fatal(err) |
| 116 | + } |
| 117 | + |
| 118 | + tmpname := filepath.Join(tmpdir, cpTestName) |
| 119 | + defer os.RemoveAll(tmpdir) |
| 120 | + |
| 121 | + path, _ := filepath.Rel("/", cpFullPath) |
| 122 | + |
| 123 | + _, _, err = cmd(t, "cp", cleanedContainerID+":"+path, tmpdir) |
| 124 | + if err != nil { |
| 125 | + t.Fatalf("couldn't copy from relative path: %s:%s %s", cleanedContainerID, path, err) |
| 126 | + } |
| 127 | + |
| 128 | + file, _ := os.Open(tmpname) |
| 129 | + defer file.Close() |
| 130 | + |
| 131 | + test, err := ioutil.ReadAll(file) |
| 132 | + if err != nil { |
| 133 | + t.Fatal(err) |
| 134 | + } |
| 135 | + |
| 136 | + if string(test) == cpHostContents { |
| 137 | + t.Errorf("output matched host file -- relative path can escape container rootfs") |
| 138 | + } |
| 139 | + |
| 140 | + if string(test) != cpContainerContents { |
| 141 | + t.Errorf("output doesn't match the input for relative path") |
| 142 | + } |
| 143 | + |
| 144 | + logDone("cp - relative paths relative to container's rootfs") |
| 145 | +} |
| 146 | + |
| 147 | +// Check that absolute paths are relative to the container's rootfs |
| 148 | +func TestCpAbsolutePath(t *testing.T) { |
| 149 | + out, exitCode, err := cmd(t, "run", "-d", "busybox", "/bin/sh", "-c", "mkdir -p '"+cpTestPath+"' && echo -n '"+cpContainerContents+"' > "+cpFullPath) |
| 150 | + if err != nil || exitCode != 0 { |
| 151 | + t.Fatal("failed to create a container", out, err) |
| 152 | + } |
| 153 | + |
| 154 | + cleanedContainerID := stripTrailingCharacters(out) |
| 155 | + defer deleteContainer(cleanedContainerID) |
| 156 | + |
| 157 | + out, _, err = cmd(t, "wait", cleanedContainerID) |
| 158 | + if err != nil || stripTrailingCharacters(out) != "0" { |
| 159 | + t.Fatal("failed to set up container", out, err) |
| 160 | + } |
| 161 | + |
| 162 | + if err := os.MkdirAll(cpTestPath, os.ModeDir); err != nil { |
| 163 | + t.Fatal(err) |
| 164 | + } |
| 165 | + |
| 166 | + hostFile, err := os.Create(cpFullPath) |
| 167 | + if err != nil { |
| 168 | + t.Fatal(err) |
| 169 | + } |
| 170 | + defer hostFile.Close() |
| 171 | + defer os.RemoveAll(cpTestPathParent) |
| 172 | + |
| 173 | + fmt.Fprintf(hostFile, "%s", cpHostContents) |
| 174 | + |
| 175 | + tmpdir, err := ioutil.TempDir("", "docker-integration") |
| 176 | + |
| 177 | + if err != nil { |
| 178 | + t.Fatal(err) |
| 179 | + } |
| 180 | + |
| 181 | + tmpname := filepath.Join(tmpdir, cpTestName) |
| 182 | + defer os.RemoveAll(tmpdir) |
| 183 | + |
| 184 | + path := cpFullPath |
| 185 | + |
| 186 | + _, _, err = cmd(t, "cp", cleanedContainerID+":"+path, tmpdir) |
| 187 | + if err != nil { |
| 188 | + t.Fatalf("couldn't copy from absolute path: %s:%s %s", cleanedContainerID, path, err) |
| 189 | + } |
| 190 | + |
| 191 | + file, _ := os.Open(tmpname) |
| 192 | + defer file.Close() |
| 193 | + |
| 194 | + test, err := ioutil.ReadAll(file) |
| 195 | + if err != nil { |
| 196 | + t.Fatal(err) |
| 197 | + } |
| 198 | + |
| 199 | + if string(test) == cpHostContents { |
| 200 | + t.Errorf("output matched host file -- absolute path can escape container rootfs") |
| 201 | + } |
| 202 | + |
| 203 | + if string(test) != cpContainerContents { |
| 204 | + t.Errorf("output doesn't match the input for absolute path") |
| 205 | + } |
| 206 | + |
| 207 | + logDone("cp - absolute paths relative to container's rootfs") |
| 208 | +} |
0 commit comments