From 3ecc508f934be9e5ce16eb6e1b95c2a7eae999ce Mon Sep 17 00:00:00 2001 From: Victor Oliveira Nascimento Date: Sun, 13 Mar 2022 20:16:47 -0300 Subject: [PATCH] fix(tests): remove duplicated tests This breaks on Emacs master (as of currently: 29). --- .github/workflows/ci.yml | 8 ++-- README.md | 5 ++ tests/elixir-mode-helper-test.el | 82 ++------------------------------ 3 files changed, 12 insertions(+), 83 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 810d6083..630e786d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,13 +10,13 @@ on: jobs: test: - name: mix test (Emacs ${{matrix.emacs_version}} | Elixir ${{matrix.elixir}} | Erlang/OTP ${{matrix.otp}}) + name: test (Emacs ${{matrix.emacs_version}} | Elixir ${{matrix.elixir}} | Erlang/OTP ${{matrix.otp}}) runs-on: ubuntu-latest strategy: matrix: - emacs_version: ['27.1', '26.3', '25.2'] - otp: ['21.3', '23.2'] - elixir: ['1.8.2', '1.11.4'] + emacs_version: ['27.2', '26.3', '25.3', 'snapshot'] + otp: ['23.3'] + elixir: ['1.8.2', '1.11.4', '1.13.3'] steps: - name: Setup Emacs diff --git a/README.md b/README.md index b8e8e7ab..6d935c7f 100644 --- a/README.md +++ b/README.md @@ -133,6 +133,11 @@ Alternatively, if you want to use `ruby-end-mode`, you can add the following to (ruby-end-mode +1))) ``` +## Notes + +This package is tested only with a single version of OTP and 3 versions of Elixir. Please, always report versions + (Emacs, Elixir and Erlang/OTP) when raising issues. + ## Elixir Tooling Integration If you looking for elixir tooling integration for Emacs, check: [alchemist.el](https://github.com/tonini/alchemist.el) diff --git a/tests/elixir-mode-helper-test.el b/tests/elixir-mode-helper-test.el index 8dfd7249..c0ed02fd 100644 --- a/tests/elixir-mode-helper-test.el +++ b/tests/elixir-mode-helper-test.el @@ -17,7 +17,8 @@ defmodule Module.Name do end") (goto-line 7) - (elixir-smie--heredoc-at-current-point-p))) + (elixir-smie--heredoc-at-current-point-p) + )) (should (not (with-temp-buffer (elixir-mode) (insert " @@ -44,8 +45,7 @@ defmodule Module.Name do end end") (goto-line 4) - (elixir-smie--previous-line-indentation)))) - ) + (elixir-smie--previous-line-indentation))))) (ert-deftest check-if-previous-line-blank () @@ -73,82 +73,6 @@ end") (goto-line 4) (elixir-smie--previous-line-empty-p)))) - -;;; elixir-mode-helper-test.el --- Tests for helper functions - -;;; Code: - -(ert-deftest check-if-currently-inside-heredoc () - (should (with-temp-buffer - (elixir-mode) - (insert " -defmodule Module.Name do - - @moduledoc \"\"\" - ## Examples - - .... - \"\"\" - -end") - (goto-line 7) - (elixir-smie--heredoc-at-current-point-p))) - (should (not (with-temp-buffer - (elixir-mode) - (insert " -defmodule Module.Name do - - @moduledoc \"\"\" - ## Examples - - .... - \"\"\" - -end") - (goto-line 3) - (elixir-smie--heredoc-at-current-point-p))))) - -(ert-deftest get-previous-line-indentation () - (should (equal 2 - (with-temp-buffer - (elixir-mode) - (insert " -defmodule Module.Name do - def what do - 1 + 1 - end -end") - (goto-line 4) - (elixir-smie--previous-line-indentation)))) - ) - - -(ert-deftest check-if-previous-line-blank () - (should (not (with-temp-buffer - (elixir-mode) - (insert " -defmodule Module.Name do - - def what do - 1 + 1 - end -end") - (goto-line 3) - (elixir-smie--previous-line-empty-p)))) - (should (with-temp-buffer - (elixir-mode) - (insert " -defmodule Module.Name do - - - def what do - 1 + 1 - end -end") - (goto-line 4) - (elixir-smie--previous-line-empty-p)))) - - (ert-deftest test-current-line-contains-built-in-keyword () (should (not (with-temp-buffer (elixir-mode)