Image banner is missing #257
Description
I am using emacs 27.1 from nixpkgs (and I have also tested with emacs 27.1 from arch linux repositories). Both are missing the image banner 🤔 when emacs starts... I have tried simplifying the code to avoid using imagemagick if it is not provided (which I think it was already done using the if) and use the new images api, but no luck so far...
@@ -450,21 +448,14 @@ If MESSAGEBUF is not nil then MSG is also written in message buffer."
"Display an image BANNER."
(when (file-exists-p banner)
(let* ((title dashboard-banner-logo-title)
- (spec
- (if (image-type-available-p 'imagemagick)
- (apply 'create-image banner 'imagemagick nil
- (append (when (> dashboard-image-banner-max-width 0)
- (list :max-width dashboard-image-banner-max-width))
- (when (> dashboard-image-banner-max-height 0)
- (list :max-height dashboard-image-banner-max-height))))
- (create-image banner)))
- (size (image-size spec))
+ (image (create-image banner (when (fboundp 'imagemagick-types) 'imagemagick)))
+ (size (image-size image))
(width (car size))
(left-margin (max 0 (floor (- dashboard-banner-length width) 2))))
(goto-char (point-min))
(insert "\n")
(insert (make-string left-margin ?\ ))
- (insert-image spec)
+ (insert-image image)
(insert "\n\n")
(when title
(dashboard-center-line title)
I am out of ideas on how to tests this 😟
Related #203