The text banner is not centered when using terminal Emacs #413
Description
Greetings,
When dashboard-startup-banner is set to 'logo and Emacs in opened in the terminal the package defaults to a text banner. This is natural and to be expected. However, that text banner is not centered even though dashboard-center-content is set to true. Interestingly, this bug only happens when the package defaults to the text banner but not when the user sets it himself. Here is a picture showing the bug:
And here is the minimal Emacs configuration needed to replicate my results:
; Straight.el setup
(defvar bootstrap-version)
(let ((bootstrap-file
(expand-file-name "straight/repos/straight.el/bootstrap.el" user-emacs-directory))
(bootstrap-version 5))
(unless (file-exists-p bootstrap-file)
(with-current-buffer
(url-retrieve-synchronously
"https://raw.githubusercontent.com/raxod502/straight.el/develop/install.el"
'silent 'inhibit-cookies)
(goto-char (point-max))
(eval-print-last-sexp)))
(load bootstrap-file nil 'nomessage))
; emacs-dashboard minimal setup
(straight-use-package 'dashboard)
(dashboard-setup-startup-hook)
(setq dashboard-startup-banner 'logo)
(setq dashboard-center-content t)
I would have liked to fix the problem myself and submit a fix, but I'm not fluent enough in elisp to do it. I believe the bug was introduced in 48860b1 since things worked fine before then. This is my first issue I've submitted to a open source project ever, so I apologize in advance for any errors that I may have committed here.
I bid you farewell.