From e69c86929e7480c867bd58f8607b2feb17db9442 Mon Sep 17 00:00:00 2001 From: Jason Dufair Date: Fri, 1 Mar 2019 09:04:09 -0500 Subject: [PATCH 1/3] Remove the "-face" suffix from declarations per elisp docs 39.12.2 --- README.org | 6 +++--- dashboard-widgets.el | 12 ++++++------ 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/README.org b/README.org index 9823735e..09759c91 100644 --- a/README.org +++ b/README.org @@ -105,11 +105,11 @@ Note that setting list-size for the agenda list is intentionally ignored; all ag It is possible to customize Dashboard's appearance using the following faces: -- ~dashboard-banner-logo-title-face~ :: +- ~dashboard-banner-logo-title~ :: Highlights the banner title. -- ~dashboard-text-banner-face~ :: +- ~dashboard-text-banner~ :: Highlights text banners. -- ~dashboard-heading-face~ :: +- ~dashboard-heading~ :: Highlights widget headings. - ~widget-button~ :: Highlights widget items. diff --git a/dashboard-widgets.el b/dashboard-widgets.el index 5e116806..a610bef0 100644 --- a/dashboard-widgets.el +++ b/dashboard-widgets.el @@ -97,17 +97,17 @@ Set to nil for unbounded.") ;; ;; Faces ;; -(defface dashboard-text-banner-face +(defface dashboard-text-banner '((t :inherit default)) "Face used for text banners." :group 'dashboard) -(defface dashboard-banner-logo-title-face +(defface dashboard-banner-logo-title '((t :inherit default)) "Face used for the banner title." :group 'dashboard) -(defface dashboard-heading-face +(defface dashboard-heading '((t :inherit default)) "Face used for widget headings." :group 'dashboard) @@ -157,7 +157,7 @@ If MESSAGEBUF is not nil then MSG is also written in message buffer." (defun dashboard-insert-heading (heading) "Insert a widget HEADING in dashboard buffer." - (insert (propertize heading 'face 'dashboard-heading-face))) + (insert (propertize heading 'face 'dashboard-heading))) ;; ;; BANNER @@ -180,7 +180,7 @@ If MESSAGEBUF is not nil then MSG is also written in message buffer." (insert (make-string margin ?\ )) (forward-line 1)))) (buffer-string)))) - (put-text-property 0 (length ascii-banner) 'face 'dashboard-text-banner-face ascii-banner) + (put-text-property 0 (length ascii-banner) 'face 'dashboard-text-banner ascii-banner) (insert ascii-banner))) (defun dashboard-insert-image-banner (banner) @@ -206,7 +206,7 @@ If MESSAGEBUF is not nil then MSG is also written in message buffer." (when title (insert (make-string (max 0 (floor (/ (- dashboard-banner-length (+ (length title) 1)) 2))) ?\ )) - (insert (format "%s\n\n" (propertize title 'face 'dashboard-banner-logo-title-face))))))) + (insert (format "%s\n\n" (propertize title 'face 'dashboard-banner-logo-title))))))) (defun dashboard-get-banner-path (index) "Return the full path to banner with index INDEX." From 6b4e452774598a11c4d0bcfac25c5091b3cf1442 Mon Sep 17 00:00:00 2001 From: Jason Dufair Date: Fri, 1 Mar 2019 09:08:27 -0500 Subject: [PATCH 2/3] Give section headings a face for easy visual scanning --- dashboard-widgets.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dashboard-widgets.el b/dashboard-widgets.el index a610bef0..e2bf72d6 100644 --- a/dashboard-widgets.el +++ b/dashboard-widgets.el @@ -108,7 +108,7 @@ Set to nil for unbounded.") :group 'dashboard) (defface dashboard-heading - '((t :inherit default)) + '((t (:inherit font-lock-function-name-face))) "Face used for widget headings." :group 'dashboard) From 9b0f96022301170cea10a47aa34c9d14d0ac226a Mon Sep 17 00:00:00 2001 From: Jason Dufair Date: Fri, 1 Mar 2019 16:10:41 -0500 Subject: [PATCH 3/3] Define obsolete face aliases --- dashboard-widgets.el | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/dashboard-widgets.el b/dashboard-widgets.el index 35801a02..96391eb9 100644 --- a/dashboard-widgets.el +++ b/dashboard-widgets.el @@ -117,6 +117,13 @@ Set to nil for unbounded.") "Face used for widget headings." :group 'dashboard) +(define-obsolete-face-alias + 'dashboard-text-banner-face 'dashboard-text-banner "1.2.6") +(define-obsolete-face-alias + 'dashboard-banner-logo-title-face 'dashboard-banner-logo-title "1.2.6") +(define-obsolete-face-alias + 'dashboard-heading-face 'dashboard-heading "1.2.6") + ;; ;; Generic widget helpers ;;