Make the icons clickable with the file names and performance improvements #129
Conversation
seagle0128
commented
May 22, 2019
- Fix Can not select item when using icons #128: Can not select item when using icons.
- Refactor: remove the advice for dashboard-insert-heading.
- Use lexical binding to improve performance.
- Eliminate compiler warnings.
Close #128. Refactor: remove the advice for dashboard-insert-heading.
There was a problem hiding this comment.
Some changes you removed from line 338 remove some relevant features.
-
The bullets for the org agenda
-
The tramp feature, which prevents dashboard from crashing when the remote is not available and stablishng unnecesary connections just to check the remote files when it is available.
Also the when-let macro leads to linting errors in the emacs 25 CI tests
|
My bad! I didn't realize it supports 25. Commit again. |
|
Thank you @seagle0128 and @ema2159 for all your work! 👍 |
This is a pretty nice and useful package, its fun to work with it! |
Fix: CI issue on Emacs 25. Fix: Unused lexical argument `list-size'. Fix: deadlocks while visiting remote directories.
|
Mr. @JesusMtnez, everything seems to be alright! Do your thing jaja you can merge this now |
|
Nice! Thank you, @JesusMtnez, @ema2159 and others! |