pdf-viewer: Opimize toggle dark mode logic for #453 #457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hollow Man <[email protected]>
Comment on lines
+247
to
+249
| self.inverted_mode_exclude_image = True | ||
| if (self.emacs_var_dict["eaf-pdf-dark-exclude-image"] == "false"): | ||
| self.inverted_mode_exclude_image = False |
There was a problem hiding this comment.
self.inverted_mode_exclude_image = self.emacs_var_dict["eaf-pdf-dark-exclue-image"] == "true"
Is better way.
Anyway I have fix this problem in newest version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted alternative solution in #453 by @Jdogzz
Use
ito toggle amongdark mode excluding images->dark mode including images->normal mode-> ...In addition, you can configure the emacs var dict to change the default behavior. If emacs var dict
eaf-pdf-dark-exclude-imageis true, the default dark mode will exclude images, otherwise it will include images.Signed-off-by: Hollow Man [email protected]