new Macro: appEmberSatisfies(range)
#2550
Conversation
| try { | ||
| let root = state.packageCache.get(state.packageCache.appRoot); | ||
|
|
||
| if (!root?.hasDependency(packageName)) { |
There was a problem hiding this comment.
I thought this was a copyPasta error 🍝 because the packageName is in module scope.. . it's only used in this try block so we could just make it a const in here 🤔
There was a problem hiding this comment.
why spend the cost of re-defining a variable every function evaluation?
it makes more sense for consts to remain in module space
There was a problem hiding this comment.
I mean that's premature optimisation right there, v8 will 100% inline it if it's a const 🤷
There was a problem hiding this comment.
yea, i mean, the activation energy to change it is worth more than anything the computer would do.
(and what energy is spent discussing such changes).
Additionally to my prior point, I use consts like this to avoid typos in strings.
I hate debugging string typos. So if I only write the word once, I can't have mismatches. 🎉
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]>
Co-authored-by: Chris Manson <[email protected]>
Why?:
This library is now a partial-polyfill for RFC#1068 tracked-tools/tracked-built-ins#440
I ran in to an issue where
dependencySatisfieswas always returning false (because the peerDep was not declared). We can't declare the peerDep because then we force all consumers oftracked-built-insto forward the peer. We've already learned that we can't successfully manage a fully correct package.json-declared dep graph. It's been best to just not declare peers, and rely on the resolve algo, as well as the assumption that the host app must provide ember-source.