Change type of Extensions #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pliner
approved these changes
Jul 28, 2023
Kludex
suggested changes
Jul 28, 2023
Co-authored-by: Marcelo Trylesinski <[email protected]>
Kludex
approved these changes
Jul 28, 2023
Kludex
approved these changes
Jul 28, 2023
Contributor
Author
|
Thank you @Kludex ! |
Contributor
|
Just coming back to this ...and... any reason for use to not use |
Contributor
Author
|
It makes no difference for httpx; for httpcore, it's just a bit of reusability. Other libraries built on top of httpcore can use more than just a dictionary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #761
Checklist