Avoid deprecated anyio.abc.BlockingPortal alias in testclient - #3500
Closed
kishansaaai wants to merge 2 commits into
Closed
Avoid deprecated anyio.abc.BlockingPortal alias in testclient#3500kishansaaai wants to merge 2 commits into
kishansaaai wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
starlette.testclientused theanyio.abc.BlockingPortalalias, which was formally deprecated in AnyIO 4.15.0 in favor ofanyio.from_thread.BlockingPortal(agronholm/anyio#1169).Because
_PortalFactoryTypeis evaluated at module load time (starlette/testclient.py:53), importingstarlette.testclientunder AnyIO 4.15.0 emitted aDeprecationWarning: The anyio.abc.BlockingPortal alias is deprecated, use anyio.from_thread.BlockingPortal instead.. When downstream test suites (e.g., inpydantic-ai) run underfilterwarnings = ["error"], test collection failed on import.This replaces the three occurrences of
anyio.abc.BlockingPortalwithanyio.from_thread.BlockingPortaland adds a regression test ensuringTestClientand importingstarlette.testclientemit noDeprecationWarning.Fixes #3497
Checklist