Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit a7bab0f

Browse files
kevmookevmoo
authored
[web] Pass the same optimization level to both stages of JS compiler (#169642)
Ensures that late variables names are cleaned up Fixes flutter/flutter#134423
1 parent c6fe412 commit a7bab0f

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

‎packages/flutter_tools/lib/src/web/compiler_config.dart‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ class JsCompilerConfig extends WebCompilerConfig {
9797
if (nativeNullAssertions) '--native-null-assertions',
9898
if (!sourceMaps) '--no-source-maps',
9999
if (buildMode == BuildMode.debug) '--enable-asserts',
100+
'-O${optimizationLevelForBuildMode(buildMode)}',
100101
];
101102

102103
@override
@@ -117,7 +118,6 @@ class JsCompilerConfig extends WebCompilerConfig {
117118
List<String> toCommandOptions(BuildMode buildMode) => <String>[
118119
if (minify ?? buildMode == BuildMode.release) '--minify' else '--no-minify',
119120
...toSharedCommandOptions(buildMode),
120-
'-O${optimizationLevelForBuildMode(buildMode)}',
121121
if (dumpInfo) '--stage=dump-info-all',
122122
if (noFrequencyBasedMinification) '--no-frequency-based-minification',
123123
if (csp) '--csp',

‎packages/flutter_tools/test/general.shard/build_system/targets/web_test.dart‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,7 @@ name: foo
523523
'-DFLUTTER_WEB_USE_SKWASM=false',
524524
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
525525
'--no-source-maps',
526+
'-O4',
526527
'-o',
527528
environment.buildDir.childFile('app.dill').absolute.path,
528529
'--packages=/.dart_tool/package_config.json',
@@ -566,6 +567,7 @@ name: foo
566567
'-DFLUTTER_WEB_USE_SKIA=true',
567568
'-DFLUTTER_WEB_USE_SKWASM=false',
568569
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
570+
'-O4',
569571
'-o',
570572
environment.buildDir.childFile('app.dill').absolute.path,
571573
'--packages=/.dart_tool/package_config.json',
@@ -609,6 +611,7 @@ name: foo
609611
'-DFLUTTER_WEB_USE_SKWASM=false',
610612
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
611613
'--no-source-maps',
614+
'-O4',
612615
'-o',
613616
environment.buildDir.childFile('app.dill').absolute.path,
614617
'--packages=/.dart_tool/package_config.json',
@@ -654,6 +657,7 @@ name: foo
654657
'-DFLUTTER_WEB_USE_SKWASM=false',
655658
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
656659
'--no-source-maps',
660+
'-O4',
657661
'-o',
658662
environment.buildDir.childFile('app.dill').absolute.path,
659663
'--packages=/.dart_tool/package_config.json',
@@ -698,6 +702,7 @@ name: foo
698702
'-DFLUTTER_WEB_USE_SKWASM=false',
699703
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
700704
'--no-source-maps',
705+
'-O4',
701706
'-o',
702707
environment.buildDir.childFile('app.dill').absolute.path,
703708
'--packages=/.dart_tool/package_config.json',
@@ -741,6 +746,7 @@ name: foo
741746
'-DFLUTTER_WEB_USE_SKWASM=false',
742747
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
743748
'--no-source-maps',
749+
'-O4',
744750
'-o',
745751
environment.buildDir.childFile('app.dill').absolute.path,
746752
'--packages=/.dart_tool/package_config.json',
@@ -785,6 +791,7 @@ name: foo
785791
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
786792
'--native-null-assertions',
787793
'--no-source-maps',
794+
'-O4',
788795
'-o',
789796
environment.buildDir.childFile('app.dill').absolute.path,
790797
'--packages=/.dart_tool/package_config.json',
@@ -831,6 +838,7 @@ name: foo
831838
'-DFLUTTER_WEB_USE_SKWASM=false',
832839
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
833840
'--no-source-maps',
841+
'-O3',
834842
'-o',
835843
environment.buildDir.childFile('app.dill').absolute.path,
836844
'--packages=/.dart_tool/package_config.json',
@@ -876,6 +884,7 @@ name: foo
876884
'-DFLUTTER_WEB_USE_SKWASM=false',
877885
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
878886
'--no-source-maps',
887+
'-O4',
879888
'-o',
880889
environment.buildDir.childFile('app.dill').absolute.path,
881890
'--packages=/.dart_tool/package_config.json',
@@ -936,6 +945,7 @@ name: foo
936945
'-DFLUTTER_WEB_USE_SKWASM=false',
937946
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
938947
'--no-source-maps',
948+
'-O4',
939949
'-o',
940950
environment.buildDir.childFile('app.dill').absolute.path,
941951
'--packages=/.dart_tool/package_config.json',
@@ -981,6 +991,7 @@ name: foo
981991
'-DFLUTTER_WEB_USE_SKIA=true',
982992
'-DFLUTTER_WEB_USE_SKWASM=false',
983993
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
994+
'-O4',
984995
'-o',
985996
environment.buildDir.childFile('app.dill').absolute.path,
986997
'--packages=/.dart_tool/package_config.json',
@@ -1026,6 +1037,7 @@ name: foo
10261037
'-DFLUTTER_WEB_USE_SKWASM=false',
10271038
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
10281039
'--no-source-maps',
1040+
'-O4',
10291041
'-o',
10301042
environment.buildDir.childFile('app.dill').absolute.path,
10311043
'--packages=/.dart_tool/package_config.json',
@@ -1074,6 +1086,7 @@ name: foo
10741086
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
10751087
'--no-source-maps',
10761088
'--enable-asserts',
1089+
'-O1',
10771090
'-o',
10781091
environment.buildDir.childFile('app.dill').absolute.path,
10791092
'--packages=/.dart_tool/package_config.json',
@@ -1119,6 +1132,7 @@ name: foo
11191132
'-DFLUTTER_WEB_USE_SKWASM=false',
11201133
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
11211134
'--no-source-maps',
1135+
'-O4',
11221136
'-o',
11231137
environment.buildDir.childFile('app.dill').absolute.path,
11241138
'--packages=/.dart_tool/package_config.json',
@@ -1165,6 +1179,7 @@ name: foo
11651179
'-DFLUTTER_WEB_USE_SKWASM=false',
11661180
'-DFLUTTER_WEB_CANVASKIT_URL=https://www.gstatic.com/flutter-canvaskit/abcdefghijklmnopqrstuvwxyz/',
11671181
'--no-source-maps',
1182+
'-O4',
11681183
'-o',
11691184
environment.buildDir.childFile('app.dill').absolute.path,
11701185
'--packages=/.dart_tool/package_config.json',

0 commit comments

Comments
 (0)