Remove generateSyntheticPackages and code that invoked it. (#169893)

matanlurey · web-flow · commit d4f60bddd26c · 2025-06-02T23:12:38.000Z
Towards flutter/flutter#102983.
diff --git a/packages/flutter_tools/lib/src/commands/create_base.dart b/packages/flutter_tools/lib/src/commands/create_base.dart
@@ -12,11 +12,8 @@ import '../android/gradle_utils.dart' as gradle;
 import '../base/common.dart';
 import '../base/file_system.dart';
 import '../base/utils.dart';
-import '../build_info.dart';
-import '../build_system/build_system.dart';
 import '../cache.dart';
 import '../convert.dart';
-import '../dart/generate_synthetic_packages.dart';
 import '../flutter_project_metadata.dart';
 import '../globals.dart' as globals;
 import '../project.dart';
@@ -494,31 +491,6 @@ mixin CreateBase on FlutterCommand {
     final bool windowsPlatform = templateContext['windows'] as bool? ?? false;
     final bool webPlatform = templateContext['web'] as bool? ?? false;
 
-    if (shouldCallPubGet) {
-      final Environment environment = Environment(
-        artifacts: globals.artifacts!,
-        logger: globals.logger,
-        cacheDir: globals.cache.getRoot(),
-        engineVersion: globals.flutterVersion.engineRevision,
-        fileSystem: globals.fs,
-        flutterRootDir: globals.fs.directory(Cache.flutterRoot),
-        outputDir: globals.fs.directory(getBuildDirectory()),
-        processManager: globals.processManager,
-        platform: globals.platform,
-        analytics: globals.analytics,
-        projectDir: project.directory,
-        packageConfigPath: packageConfigPath(),
-        generateDartPluginRegistry: true,
-      );
-
-      // Generate the l10n synthetic package that will be injected into the
-      // package_config in the call to pub.get() below.
-      await generateLocalizationsSyntheticPackage(
-        environment: environment,
-        buildSystem: globals.buildSystem,
-        buildTargets: globals.buildTargets,
-      );
-    }
     final List<SupportedPlatform> platformsForMigrateConfig = <SupportedPlatform>[
       SupportedPlatform.root,
     ];
diff --git a/packages/flutter_tools/lib/src/commands/packages.dart b/packages/flutter_tools/lib/src/commands/packages.dart
@@ -12,7 +12,6 @@ import '../build_info.dart';
 import '../build_system/build_system.dart';
 import '../build_system/targets/localizations.dart';
 import '../cache.dart';
-import '../dart/generate_synthetic_packages.dart';
 import '../dart/package_map.dart';
 import '../dart/pub.dart';
 import '../flutter_plugins.dart';
@@ -304,12 +303,7 @@ class PackagesGetCommand extends FlutterCommand {
         packageConfigPath: packageConfigPath(),
         generateDartPluginRegistry: true,
       );
-      if (rootProject.manifest.generateLocalizations &&
-          !await generateLocalizationsSyntheticPackage(
-            environment: environment,
-            buildSystem: globals.buildSystem,
-            buildTargets: globals.buildTargets,
-          )) {
+      if (rootProject.manifest.generateLocalizations) {
         // If localizations were enabled, but we are not using synthetic packages.
         final BuildResult result = await globals.buildSystem.build(
           const GenerateLocalizationsTarget(),
diff --git a/packages/flutter_tools/lib/src/dart/generate_synthetic_packages.dart b/packages/flutter_tools/lib/src/dart/generate_synthetic_packages.dart
diff --git a/packages/flutter_tools/lib/src/runner/flutter_command.dart b/packages/flutter_tools/lib/src/runner/flutter_command.dart
@@ -17,11 +17,9 @@ import '../base/io.dart';
 import '../base/os.dart';
 import '../base/utils.dart';
 import '../build_info.dart';
-import '../build_system/build_system.dart';
 import '../bundle.dart' as bundle;
 import '../cache.dart';
 import '../convert.dart';
-import '../dart/generate_synthetic_packages.dart';
 import '../dart/package_map.dart';
 import '../dart/pub.dart';
 import '../device.dart';
@@ -1837,33 +1835,11 @@ abstract class FlutterCommand extends Command<void> {
     project.checkForDeprecation(deprecationBehavior: deprecationBehavior);
 
     if (shouldRunPub) {
-      final Environment environment = Environment(
-        artifacts: globals.artifacts!,
-        logger: globals.logger,
-        cacheDir: globals.cache.getRoot(),
-        engineVersion: globals.flutterVersion.engineRevision,
-        fileSystem: globals.fs,
-        flutterRootDir: globals.fs.directory(Cache.flutterRoot),
-        outputDir: globals.fs.directory(getBuildDirectory()),
-        processManager: globals.processManager,
-        platform: globals.platform,
-        analytics: analytics,
-        projectDir: project.directory,
-        packageConfigPath: packageConfigPath(),
-        generateDartPluginRegistry: true,
-      );
-
       await pub.get(
         context: PubContext.getVerifyContext(name),
         project: project,
         checkUpToDate: cachePubGet,
       );
-
-      await generateLocalizationsSyntheticPackage(
-        environment: environment,
-        buildSystem: globals.buildSystem,
-        buildTargets: globals.buildTargets,
-      );
     }
 
     if (regeneratePlatformSpecificToolingDuringVerify) {
diff --git a/packages/flutter_tools/test/commands.shard/permeable/packages_test.dart b/packages/flutter_tools/test/commands.shard/permeable/packages_test.dart
@@ -15,7 +15,6 @@ import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/cache.dart';
 import 'package:flutter_tools/src/commands/packages.dart';
 import 'package:flutter_tools/src/dart/pub.dart';
-import 'package:flutter_tools/src/features.dart';
 import 'package:flutter_tools/src/globals.dart' as globals;
 import 'package:unified_analytics/unified_analytics.dart';
 import 'package:yaml/yaml.dart';
@@ -30,15 +29,6 @@ import '../../src/test_flutter_command_runner.dart';
 void main() {
   late FakeStdio mockStdio;
 
-  // TODO(matanlurey): Remove after `flutter_gen` is removed.
-  // See https://github.com/flutter/flutter/issues/102983 for details.
-  FeatureFlags disableExplicitPackageDependencies() {
-    return TestFeatureFlags(
-      // ignore: avoid_redundant_argument_values
-      isExplicitPackageDependenciesEnabled: false,
-    );
-  }
-
   setUp(() {
     mockStdio = FakeStdio()..stdout.terminalColumns = 80;
 
@@ -320,48 +310,6 @@ void main() {
       },
     );
 
-    testUsingContext(
-      'get generates synthetic package when l10n.yaml has synthetic-package: true',
-      () async {
-        final String projectPath = await createProject(
-          tempDir,
-          arguments: <String>['--no-pub', '--template=module'],
-        );
-        final Directory projectDir = globals.fs.directory(projectPath);
-        projectDir.childDirectory('lib').childDirectory('l10n').childFile('app_en.arb')
-          ..createSync(recursive: true)
-          ..writeAsStringSync('{ "hello": "Hello world!" }');
-        String pubspecFileContent = projectDir.childFile('pubspec.yaml').readAsStringSync();
-        pubspecFileContent = pubspecFileContent.replaceFirst(RegExp(r'\nflutter\:'), '''
-flutter:
-  generate: true
-''');
-        projectDir.childFile('pubspec.yaml').writeAsStringSync(pubspecFileContent);
-        projectDir.childFile('l10n.yaml').writeAsStringSync('synthetic-package: true');
-        await runCommandIn(projectPath, 'get');
-        expect(
-          projectDir
-              .childDirectory('.dart_tool')
-              .childDirectory('flutter_gen')
-              .childDirectory('gen_l10n')
-              .childFile('app_localizations.dart')
-              .existsSync(),
-          true,
-        );
-      },
-      overrides: <Type, Generator>{
-        Pub:
-            () => Pub(
-              fileSystem: globals.fs,
-              logger: globals.logger,
-              processManager: globals.processManager,
-              botDetector: globals.botDetector,
-              platform: globals.platform,
-            ),
-        FeatureFlags: disableExplicitPackageDependencies,
-      },
-    );
-
     testUsingContext(
       'get fetches packages for a workspace',
       () async {
diff --git a/packages/flutter_tools/test/general.shard/dart/generate_synthetic_packages_test.dart b/packages/flutter_tools/test/general.shard/dart/generate_synthetic_packages_test.dart
