Fix minify logic (#169607)

kevmoo · web-flow · commit f2625754b316 · 2025-05-28T23:52:39.000Z
It's meant to be ignored unless explicitly set. Introduced in flutter/flutter@cb3150f
diff --git a/packages/flutter_tools/lib/src/commands/build_web.dart b/packages/flutter_tools/lib/src/commands/build_web.dart
@@ -175,7 +175,7 @@ class BuildWebCommand extends BuildSubCommand {
     );
 
     final bool sourceMaps = boolArg('source-maps');
-    final bool minify = boolArg('minify');
+    final bool? minify = argResults!.wasParsed('minify') ? boolArg('minify') : null;
 
     final List<WebCompilerConfig> compilerConfigs;
 
diff --git a/packages/flutter_tools/lib/src/web/compiler_config.dart b/packages/flutter_tools/lib/src/web/compiler_config.dart
@@ -38,6 +38,7 @@ sealed class WebCompilerConfig {
   /// Returns which target this compiler outputs (js or wasm)
   CompileTarget get compileTarget;
   final WebRendererMode renderer;
+  List<String> toCommandOptions(BuildMode buildMode);
 
   String get buildKey;
 
@@ -112,6 +113,7 @@ class JsCompilerConfig extends WebCompilerConfig {
   /// Arguments to use in the full JS compile, but not CFE-only.
   ///
   /// Includes the contents of [toSharedCommandOptions].
+  @override
   List<String> toCommandOptions(BuildMode buildMode) => <String>[
     if (minify ?? buildMode == BuildMode.release) '--minify' else '--no-minify',
     ...toSharedCommandOptions(buildMode),
@@ -130,7 +132,7 @@ class JsCompilerConfig extends WebCompilerConfig {
       'nativeNullAssertions': nativeNullAssertions,
       'noFrequencyBasedMinification': noFrequencyBasedMinification,
       'minify': minify,
-      'sourceMaps': sourceMaps,
+      WebCompilerConfig.kSourceMapsEnabled: sourceMaps,
     };
     return jsonEncode(settings);
   }
@@ -167,6 +169,7 @@ class WasmCompilerConfig extends WebCompilerConfig {
         BuildMode.jitRelease => throw ArgumentError('Invalid build mode for web'),
       };
 
+  @override
   List<String> toCommandOptions(BuildMode buildMode) {
     final bool stripSymbols = buildMode == BuildMode.release && stripWasm;
     return <String>[
@@ -181,8 +184,8 @@ class WasmCompilerConfig extends WebCompilerConfig {
   String get buildKey {
     final Map<String, dynamic> settings = <String, dynamic>{
       ...super._buildKeyMap,
-      'stripWasm': stripWasm,
-      'sourceMaps': sourceMaps,
+      kStripWasm: stripWasm,
+      WebCompilerConfig.kSourceMapsEnabled: sourceMaps,
     };
     return jsonEncode(settings);
   }
diff --git a/packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart b/packages/flutter_tools/test/commands.shard/hermetic/build_web_test.dart
@@ -400,7 +400,7 @@ void main() {
   );
 
   testUsingContext(
-    'Defaults to web renderer canvaskit mode when no option is specified',
+    'Defaults to web renderer canvaskit and minify mode when no option is specified',
     () async {
       final TestWebBuildCommand buildCommand = TestWebBuildCommand(fileSystem: fileSystem);
       final CommandRunner<void> runner = createTestCommandRunner(buildCommand);
@@ -419,8 +419,17 @@ void main() {
           ) {
             expect(target, isA<WebServiceWorker>());
             final List<WebCompilerConfig> configs = (target as WebServiceWorker).compileConfigs;
-            expect(configs.length, 1);
-            expect(configs.first.renderer, WebRendererMode.canvaskit);
+            expect(configs, hasLength(1));
+            final WebCompilerConfig config = configs.single;
+            expect(config.renderer, WebRendererMode.canvaskit);
+            expect(config.compileTarget, CompileTarget.js);
+            final List<String> options = config.toCommandOptions(BuildMode.release);
+            expect(options, <String>[
+              '--minify',
+              '--native-null-assertions',
+              '--no-source-maps',
+              '-O4',
+            ]);
           }),
     },
   );
@@ -445,7 +454,7 @@ void main() {
           ) {
             expect(target, isA<WebServiceWorker>());
             final List<WebCompilerConfig> configs = (target as WebServiceWorker).compileConfigs;
-            expect(configs.length, 2);
+            expect(configs, hasLength(2));
             expect(configs[0].renderer, WebRendererMode.skwasm);
             expect(configs[0].compileTarget, CompileTarget.wasm);
             expect(configs[1].renderer, WebRendererMode.canvaskit);
