Small simplifications to FixedAxisArtistHelper.

anntzer · anntzer · commit 79fc9e581f1d · 2021-07-17T18:18:09.000+02:00
- change_tick_coords has never been used by any other function or in any
  example in the library's history, and is a custom API not even present
  on other AxisArtistHelpers, so deprecate it.
- _limits_inverted is only used in get_tick_iterators, so one can just
  test limits inversion there instead of carrying one bit of state
  around.
diff --git a/doc/api/next_api_changes/deprecations/20638-AL.rst b/doc/api/next_api_changes/deprecations/20638-AL.rst
@@ -0,0 +1,3 @@
+``FixedAxisArtistHelper.change_tick_coord``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+... is deprecated with no replacement.
diff --git a/lib/mpl_toolkits/axisartist/grid_helper_curvelinear.py b/lib/mpl_toolkits/axisartist/grid_helper_curvelinear.py
@@ -32,21 +32,11 @@ def __init__(self, grid_helper, side, nth_coord_ticks=None):
         self.nth_coord_ticks = nth_coord_ticks
 
         self.side = side
-        self._limits_inverted = False
 
     def update_lim(self, axes):
         self.grid_helper.update_lim(axes)
 
-        if self.nth_coord == 0:
-            xy1, xy2 = axes.get_ylim()
-        else:
-            xy1, xy2 = axes.get_xlim()
-
-        if xy1 > xy2:
-            self._limits_inverted = True
-        else:
-            self._limits_inverted = False
-
+    @_api.deprecated("3.5")
     def change_tick_coord(self, coord_number=None):
         if coord_number is None:
             self.nth_coord_ticks = 1 - self.nth_coord_ticks
@@ -60,18 +50,15 @@ def get_tick_transform(self, axes):
 
     def get_tick_iterators(self, axes):
         """tick_loc, tick_angle, tick_label"""
-
-        g = self.grid_helper
-
-        if self._limits_inverted:
+        v1, v2 = axes.get_ylim() if self.nth_coord == 0 else axes.get_xlim()
+        if v1 > v2:  # Inverted limits.
             side = {"left": "right", "right": "left",
                     "top": "bottom", "bottom": "top"}[self.side]
         else:
             side = self.side
-
+        g = self.grid_helper
         ti1 = g.get_tick_iterator(self.nth_coord_ticks, side)
         ti2 = g.get_tick_iterator(1-self.nth_coord_ticks, side, minor=True)
-
         return chain(ti1, ti2), iter([])
 
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	+``FixedAxisArtistHelper.change_tick_coord``
	`2`	`+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~`
	`3`	`+... is deprecated with no replacement.`