Merge pull request #4 from Sander0542/fix/swap-model-supports-vane

erwindouna · web-flow · commit 192d68d12b82 · 2025-09-23T07:27:51.000+02:00
fix: Swap ModelSupportsVaneHorizontal and ModelSupportsVaneVertical
diff --git a/src/pymelcloud/ata_device.py b/src/pymelcloud/ata_device.py
@@ -321,7 +321,8 @@ def vane_horizontal_positions(self) -> Optional[List[str]]:
         if self._device_conf.get("HideVaneControls", False):
             return []
         device = self._device_conf.get("Device", {})
-        if not device.get("ModelSupportsVaneHorizontal", False):
+        # ModelSupportsVaneVertical and ModelSupportsVaneHorizontal are swapped in the API
+        if not device.get("ModelSupportsVaneVertical", False):
             return []
 
         positions = [
@@ -351,7 +352,8 @@ def vane_vertical_positions(self) -> Optional[List[str]]:
         if self._device_conf.get("HideVaneControls", False):
             return []
         device = self._device_conf.get("Device", {})
-        if not device.get("ModelSupportsVaneVertical", False):
+        # ModelSupportsVaneHorizontal and ModelSupportsVaneVertical are swapped in the API
+        if not device.get("ModelSupportsVaneHorizontal", False):
             return []
 
         positions = [
