fix: update eslint-all.js to use Object.freeze for rules object
#20116
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
eslint-all.js to use Object.freeze for rules objecteslint-all.js to use Object.freeze for rules object
Member
I think we can treat this as a non-breaking change. @eslint/eslint-tsc thoughts? |
mdjermanovic
approved these changes
Sep 14, 2025
Member
mdjermanovic
left a comment
There was a problem hiding this comment.
Changes LGTM. Pending opinions on whether this is a breaking change.
Member
I agree this isn't a breaking change. |
Member
|
Agreed. |
nzakas
pushed a commit
that referenced
this pull request
Sep 23, 2025
…#20116) fix: update `eslint-all.js` to use `Object.freeze` for rules object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
In this PR, I've updated
eslint-all.jsto useObject.freezefor therulesobject.I noticed it was odd that the
allconfiguration didn't useObject.freeze, especially since therecommendedconfiguration does, and the TypeScript type signature indicates that the rules object isreadonly.eslint/packages/js/src/configs/eslint-recommended.js
Lines 19 to 22 in 1ace67d
eslint/packages/js/types/index.d.ts
Line 10 in 1ace67d
So, to keep things consistent across the rule configurations and with the type signature, I've updated
eslint-all.jsto useObject.freezefor therulesobject.Is there anything you'd like reviewers to focus on?
I'm not sure if this should be considered a breaking change. If anyone has another opinion, I'm happy to follow that suggestion.