Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Removes temp dir created during a circular fixes in multithread mode test.

What changes did you make? (Give an overview)

Updated a test in bin/eslint.js

Is there anything you'd like reviewers to focus on?

Similar to 16d8260 of #20067.

@mdjermanovic mdjermanovic requested a review from a team as a code owner September 22, 2025 07:44
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Sep 22, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Sep 22, 2025
@netlify
Copy link

netlify bot commented Sep 22, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 3ed8b8e
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68d0fe7d1bfbe500086ea5c5

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Sep 22, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Sep 22, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like another review before merging.

@lumirlumir lumirlumir moved this from Triaging to Second Review Needed in Triage Sep 22, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 0cb5897 into main Sep 23, 2025
30 checks passed
@fasttime fasttime deleted the test-remove-circularfixes-tmpdir branch September 23, 2025 03:41
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

4 participants