Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: correct Scope typings #20198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 30, 2025
Merged

fix: correct Scope typings #20198

merged 5 commits into from
Oct 30, 2025
+47 −1

Conversation

@jaymarvelz
Copy link
Contributor

@jaymarvelz jaymarvelz commented Oct 8, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

  • Added implicit?: { variables: Variable[]; set: Map<string, Variable>; left: Reference[] } to
    Scope.Scope. This field exists in the global scope.
  • Refined DefinitionType["ImplicitGlobalVariable"].node to: AssignmentExpression | ForInStatement | ForOfStatement (instead of Program).
  • Dropped "TDZ" from Scope.Scope["type"]. TDZ scopes were removed in [email protected]
  • Removed { type: "TDZ"; node: any; parent: null } from DefinitionType

Is there anything you'd like reviewers to focus on?

@jaymarvelz jaymarvelz requested a review from a team as a code owner October 8, 2025 12:10
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 8, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Oct 8, 2025
@netlify
Copy link

netlify bot commented Oct 8, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 25ee482
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/69037ff4fe3f5b000856c461
😎 Deploy Preview https://deploy-preview-20198--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

DMartens
DMartens reviewed Oct 9, 2025
View reviewed changes
DMartens
DMartens reviewed Oct 9, 2025
View reviewed changes
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Oct 14, 2025
@nzakas
Copy link
Member

nzakas commented Oct 14, 2025

@jaymarvelz please check the CI errors.

@jaymarvelz
Copy link
Contributor Author

jaymarvelz commented Oct 17, 2025

It looks like the TDZ removal is a breaking change. Would the team be open to handling this in a separate PR for v10?

@DMartens
Copy link
Contributor

DMartens commented Oct 17, 2025

Yes, the CI problem seems to be that the types of eslint and eslint-scope would be out-of-sync as TDZ is removed as a scope type.
I agree the best option would be to exclude the change in this PR and create 2 draft PRs: one for eslint and one for eslint-scope which would be merged for v10.

@jaymarvelz
Copy link
Contributor Author

jaymarvelz commented Oct 20, 2025 •
edited
Loading

@DMartens I checked the eslint-scope package and I don’t think any changes are needed there. The issue seems to be with @types/eslint-scope instead.

Opened #20231

@jaymarvelz jaymarvelz requested a review from DMartens October 29, 2025 12:02
@DMartens
Copy link
Contributor

DMartens commented Oct 29, 2025 •
edited
Loading

Sorry for dropping the ball on this. Changes LGTM, thanks.
(Cannot currently merge as the EasyCLA check is blocked, so I am re-running the checks hoping this is resolved)

@DMartens DMartens merged commit 927272d into eslint:main Oct 30, 2025
32 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Oct 30, 2025
@Pixel998 Pixel998 added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DMartens DMartens DMartens approved these changes

Assignees

No one assigned

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly contributor pool

Projects

Triage
Status: Complete

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaymarvelz @nzakas @DMartens @Pixel998