Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sethamus
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

The feature flags documentation page was updated to handle cases where there are no active or inactive flags.

What changes did you make? (Give an overview)

Added conditional logic in flags.md so that if flags.active or flags.inactive is empty, the page no longer renders an empty table. Instead, it shows a short message: “There are currently no active/inactive flags.”

Rationale

ESLint v10 removes all currently inactive flags (unstable_ts_config, unstable_config_lookup_from_file), so the page would otherwise render an empty table.

Is there anything you'd like reviewers to focus on?

@sethamus sethamus requested a review from a team as a code owner October 18, 2025 04:02
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Oct 18, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Oct 18, 2025
@netlify
Copy link

netlify bot commented Oct 18, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit eed87b2
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/68f311448b640e0008f54729
😎 Deploy Preview https://deploy-preview-20222--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Waiting 1~2 days for others to review.

@aladdin-add aladdin-add moved this from Needs Triage to Second Review Needed in Triage Oct 18, 2025
@aladdin-add aladdin-add added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 18, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 7b9446f into eslint:main Oct 18, 2025
32 of 33 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Oct 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants