feat: add condition to check TS parser #744
Conversation
✅ Deploy Preview for es-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for new-eslint ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for hi-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ja-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for zh-hans-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for fr-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for pt-br-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for de-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like another review before merging.
nzakas
left a comment
There was a problem hiding this comment.
LGTM. Would like @mdjermanovic to verify before mergin.
| (typeof parser === "object" && | ||
| parser.meta.name === "typescript-eslint/parser") || | ||
| parser === "@typescript-eslint/parser" || | ||
| parser === typeScriptESLintParser |
There was a problem hiding this comment.
I'm not sure I understand this change. Shouldn't the Open in Playground button send "parser":"@typescript-eslint/parser" in options.languageOptions, not the parser object?
There was a problem hiding this comment.
I tried "parser":"@typescript-eslint/parser" but got this error, and it is not working as expected:
There was a problem hiding this comment.
Can you share a branch with a code change that is causing this error?
Note that we want to pass "parser":"@typescript-eslint/parser" to the playground, not to the code that underlines errors in code example on the docs site.
There was a problem hiding this comment.
Seems you are right, "parser":"@typescript-eslint/parser" is working and have implemented in eslint/eslint#19671.
So I think this PR can be closed, thanks.
|
Closing it based on discussion #744 (comment). |
Prerequisites checklist
What is the purpose of this pull request?
https://github.com/eslint/eslint/blob/f46fc6c137c951bc73cf3bd9446053c1b11f769b/docs/.eleventy.js#L215-L217
To set the parser option to
@typescript-eslint/parserin playground onlanguageOptions.parser = typeScriptESLintParseroption, this will enable the TS parser when someone directly open the playground fromopen in playgroundbutton in docs.What changes did you make? (Give an overview)
Added a condition to check if
parser === typeScriptESLintParserthen set the playground parser to@typescript-eslint/parser.Related Issues
Is there anything you'd like reviewers to focus on?
Need to add this change before adding playground button for TypeScript code example eslint/eslint#19671