Thanks to visit codestin.com
Credit goes to github.com

Skip to content

UpdaterClass::printError() should accept Print class #4007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
puuu opened this issue Dec 21, 2017 · 4 comments
Closed

UpdaterClass::printError() should accept Print class #4007

puuu opened this issue Dec 21, 2017 · 4 comments
Labels
component: libraries good first issue If you want to help, this is is a good place to start type: enhancement

Comments

@puuu
Copy link

puuu commented Dec 21, 2017

UpdaterClass::printError() required a Stream object, but only use the Print class subset. Please change Stream to Print, to enable debugging to other Print objects that are not inherit from Stream.
@igrr igrr added component: libraries good first issue If you want to help, this is is a good place to start type: enhancement labels Jan 2, 2018
@ijm7
Copy link
Contributor

ijm7 commented Jan 6, 2018

Hi, is anyone doing this? I would like to look into it.

@devyte
Copy link
Collaborator

devyte commented Jan 6, 2018

@ijm7 afaik, not at this time, so go ahead. If you make a pr, I'll review it.

@ijm7 ijm7 mentioned this issue Jan 7, 2018
Merged
@ijm7
Copy link
Contributor

ijm7 commented Oct 5, 2018

Just realised that this issue is still sitting open, it should probably be closed.

@d-a-v
Copy link
Collaborator

d-a-v commented Oct 5, 2018

fixed by #4117, thanks!

@d-a-v d-a-v closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: libraries good first issue If you want to help, this is is a good place to start type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@igrr @d-a-v @devyte @ijm7 @puuu