Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MD5 Verification fails on HTTPUpdate after unsuccessful OTAUpdate #4257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CriPstian opened this issue Aug 14, 2020 · 4 comments
Closed

MD5 Verification fails on HTTPUpdate after unsuccessful OTAUpdate #4257

CriPstian opened this issue Aug 14, 2020 · 4 comments
Labels
Status: Stale Issue is stale stage (outdated/stuck)

Comments

@CriPstian
Copy link
Contributor

Hardware:

Board: esp32doit-devkit-v1
Core Installation version: 1.0.4
IDE name: CLion
Flash Frequency: 40Mhz
PSRAM enabled: no
Upload Speed: 115200
Computer OS: Ubuntu

Description:

MD5 Verification fails on HTTP Update (with no x-MD5 header response) after unsuccessful OTA Update because the _target_md5 string in Updater class is not restored to default value.

Sketch:

No need for a sketch, This is a reproducible issue by following two basic steps:

  1. Fail an OTAUpdate by cancelling the update in the middle of the process
  2. Trigger an HTTPUpdate with a server that has no x-MD5 header set on the response.
    => The update will fail with MD5 Check fail

Debug Messages:

MD5 Failed: expected:<_target_md5>, calculated:<md5>
@CriPstian
Copy link
Contributor Author

I've created a small PR #4260 for cleaning up the MD5 related fields since every use of the Updater class would leave garbage values at the site

@CriPstian CriPstian mentioned this issue Aug 19, 2020
Merged
@CriPstian
Copy link
Contributor Author

This issue continues to create issues on my side. Is anybody up for review?

@stale
Copy link

stale bot commented Nov 21, 2020

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: Stale Issue is stale stage (outdated/stuck) label Nov 21, 2020
@CriPstian
Copy link
Contributor Author

This issue was fixed by #4260

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Stale Issue is stale stage (outdated/stuck)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CriPstian