From efb6e0d8b15bb9284ee6fa65185f54cdec6241d9 Mon Sep 17 00:00:00 2001 From: thebigpotatoe Date: Sun, 27 Sep 2020 19:03:28 +1000 Subject: [PATCH 1/3] Changed MDNSResponder::addService to return a bool --- libraries/ESPmDNS/src/ESPmDNS.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libraries/ESPmDNS/src/ESPmDNS.cpp b/libraries/ESPmDNS/src/ESPmDNS.cpp index 2211f67b9c7..9a76f623c91 100644 --- a/libraries/ESPmDNS/src/ESPmDNS.cpp +++ b/libraries/ESPmDNS/src/ESPmDNS.cpp @@ -130,7 +130,7 @@ void MDNSResponder::disableWorkstation(){ } } -void MDNSResponder::addService(char *name, char *proto, uint16_t port){ +bool MDNSResponder::addService(char *name, char *proto, uint16_t port){ char _name[strlen(name)+2]; char _proto[strlen(proto)+2]; if (name[0] == '_') { @@ -146,7 +146,9 @@ void MDNSResponder::addService(char *name, char *proto, uint16_t port){ if(mdns_service_add(NULL, _name, _proto, port, NULL, 0)) { log_e("Failed adding service %s.%s.\n", name, proto); + return false; } + return true; } bool MDNSResponder::addServiceTxt(char *name, char *proto, char *key, char *value){ From 87e810eecc79945e403f883080108a10f51cb697 Mon Sep 17 00:00:00 2001 From: thebigpotatoe Date: Sun, 27 Sep 2020 19:04:28 +1000 Subject: [PATCH 2/3] Updated MDNSResponder::addService to return a bool --- libraries/ESPmDNS/src/ESPmDNS.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libraries/ESPmDNS/src/ESPmDNS.h b/libraries/ESPmDNS/src/ESPmDNS.h index e66fbdb7e62..0d52d43b916 100644 --- a/libraries/ESPmDNS/src/ESPmDNS.h +++ b/libraries/ESPmDNS/src/ESPmDNS.h @@ -65,11 +65,11 @@ class MDNSResponder { setInstanceName(String(name)); } - void addService(char *service, char *proto, uint16_t port); - void addService(const char *service, const char *proto, uint16_t port){ + bool addService(char *service, char *proto, uint16_t port); + bool addService(const char *service, const char *proto, uint16_t port){ addService((char *)service, (char *)proto, port); } - void addService(String service, String proto, uint16_t port){ + bool addService(String service, String proto, uint16_t port){ addService(service.c_str(), proto.c_str(), port); } From d09cdce480db74f47ee0ffb6ffad6824054419ba Mon Sep 17 00:00:00 2001 From: thebigpotatoe Date: Sun, 27 Sep 2020 19:12:48 +1000 Subject: [PATCH 3/3] Update ESPmDNS.h --- libraries/ESPmDNS/src/ESPmDNS.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libraries/ESPmDNS/src/ESPmDNS.h b/libraries/ESPmDNS/src/ESPmDNS.h index 0d52d43b916..8f56ea42fde 100644 --- a/libraries/ESPmDNS/src/ESPmDNS.h +++ b/libraries/ESPmDNS/src/ESPmDNS.h @@ -67,10 +67,10 @@ class MDNSResponder { bool addService(char *service, char *proto, uint16_t port); bool addService(const char *service, const char *proto, uint16_t port){ - addService((char *)service, (char *)proto, port); + return addService((char *)service, (char *)proto, port); } bool addService(String service, String proto, uint16_t port){ - addService(service.c_str(), proto.c_str(), port); + return addService(service.c_str(), proto.c_str(), port); } bool addServiceTxt(char *name, char *proto, char * key, char * value);