Remove oauth2client from IoT and Functions samples (GoogleCloudPlatform#3255)

busunkim96 · web-flow · commit 89840a049edf · 2020-04-03T14:51:02.000-07:00
* chore: remove oauth2client from functions and iot

* fix: fix import

* fix: correct syntax

* fix: correct import for service_account

* fix: fix path
diff --git a/functions/billing/main.py b/functions/billing/main.py
@@ -26,7 +26,6 @@
 # [START functions_billing_limit_appengine]
 # [START functions_billing_stop]
 from googleapiclient import discovery
-from oauth2client.client import GoogleCredentials
 # [END functions_billing_stop]
 # [END functions_billing_limit]
 # [END functions_billing_limit_appengine]
@@ -80,7 +79,6 @@ def stop_billing(data, context):
         'cloudbilling',
         'v1',
         cache_discovery=False,
-        credentials=GoogleCredentials.get_application_default()
     )
 
     projects = billing.projects()
@@ -130,7 +128,6 @@ def limit_use(data, context):
         'compute',
         'v1',
         cache_discovery=False,
-        credentials=GoogleCredentials.get_application_default()
     )
     instances = compute.instances()
 
@@ -190,8 +187,7 @@ def limit_use_appengine(data, context):
     appengine = discovery.build(
         'appengine',
         'v1',
-        cache_discovery=False,
-        credentials=GoogleCredentials.get_application_default()
+        cache_discovery=False
     )
     apps = appengine.apps()
 
diff --git a/functions/billing/requirements.txt b/functions/billing/requirements.txt
@@ -1,5 +1,4 @@
 slackclient==2.5.0
 # [START functions_billing_limit_appengine_deps]
-oauth2client==4.1.3
 google-api-python-client==1.7.11
 # [START functions_billing_limit_appengine_deps]
diff --git a/functions/slack/requirements.txt b/functions/slack/requirements.txt
@@ -1,4 +1,3 @@
 google-api-python-client==1.7.11
 flask==1.1.1
-oauth2client==4.1.3
 slackeventsapi==2.1.0
diff --git a/iot/api-client/end_to_end_example/cloudiot_pubsub_example_server.py b/iot/api-client/end_to_end_example/cloudiot_pubsub_example_server.py
@@ -45,7 +45,7 @@
 from google.cloud import pubsub
 from googleapiclient import discovery
 from googleapiclient.errors import HttpError
-from oauth2client.service_account import ServiceAccountCredentials
+from google.oauth2 import service_account
 
 
 API_SCOPES = ['https://www.googleapis.com/auth/cloud-platform']
@@ -58,8 +58,8 @@ class Server(object):
     """Represents the state of the server."""
 
     def __init__(self, service_account_json):
-        credentials = ServiceAccountCredentials.from_json_keyfile_name(
-            service_account_json, API_SCOPES)
+        credentials = service_account.Credentials.from_service_account_file(
+            service_account_json).with_scopes(API_SCOPES)
         if not credentials:
             sys.exit('Could not load service account credential '
                      'from {}'.format(service_account_json))
diff --git a/iot/api-client/end_to_end_example/requirements.txt b/iot/api-client/end_to_end_example/requirements.txt
@@ -3,6 +3,5 @@ google-api-python-client==1.7.11
 google-auth-httplib2==0.0.3
 google-auth==1.11.2
 google-cloud-pubsub==1.1.0
-oauth2client==4.1.3
 pyjwt==1.7.1
 paho-mqtt==1.5.0
diff --git a/iot/api-client/manager/requirements.txt b/iot/api-client/manager/requirements.txt
@@ -5,6 +5,5 @@ google-auth-httplib2==0.0.3
 google-auth==1.11.2
 google-cloud-iot==1.0.0
 google-cloud-pubsub==1.1.0
-oauth2client==4.1.3
 paho-mqtt==1.5.0
 pyjwt==1.7.1
